From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59135) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPufT-0004FZ-Fx for qemu-devel@nongnu.org; Sun, 31 Jan 2016 11:16:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aPufQ-0000sA-9S for qemu-devel@nongnu.org; Sun, 31 Jan 2016 11:16:03 -0500 From: Sergey Fedorov Date: Sun, 31 Jan 2016 19:15:46 +0300 Message-Id: <1454256948-10485-1-git-send-email-serge.fdrv@gmail.com> Subject: [Qemu-devel] [PATCH v3 0/2] Architectural watchpoint check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-arm@nongnu.org Cc: Peter Maydell , Peter Crosthwaite , Paolo Bonzini , Sergey Fedorov , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Richard Henderson This series is intended to fix ARM watchpoint emulation misbehavior. QEMU hangs when QEMU watchpoint fires but it does not pass additional architectural checks in ARM CPU debug exception handler. For details, please see individual patches. The most relevant parts of the original discussion about ARM breakpoint and watchpoint emulation misbehavior can be found at: https://lists.gnu.org/archive/html/qemu-devel/2015-08/msg02715.html https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg00527.html Changes in v2: * Check moved before setting cpu->watchpoint_hit * Pointer to watchpoint being checked passed to debug_check_watchpoint() callback * BP_WATCHPOINT_HIT flag cleared from flags from wp->flags in no-fire case * Comment for debug_check_watchpoint() callback improved Sergey Fedorov (2): cpu: Add callback to check architectural watchpoint match target-arm: Implement checking of fired watchpoint exec.c | 6 ++++++ include/qom/cpu.h | 4 ++++ qom/cpu.c | 9 +++++++++ target-arm/cpu.c | 1 + target-arm/internals.h | 3 +++ target-arm/op_helper.c | 35 +++++++++++++++++++++-------------- 6 files changed, 44 insertions(+), 14 deletions(-) -- 1.9.1