From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRcdF-0004D8-L4 for qemu-devel@nongnu.org; Fri, 05 Feb 2016 04:24:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRcdC-0007pt-EK for qemu-devel@nongnu.org; Fri, 05 Feb 2016 04:24:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33499) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRcdC-0007ph-70 for qemu-devel@nongnu.org; Fri, 05 Feb 2016 04:24:46 -0500 From: Fam Zheng Date: Fri, 5 Feb 2016 17:24:13 +0800 Message-Id: <1454664263-25969-3-git-send-email-famz@redhat.com> In-Reply-To: <1454664263-25969-1-git-send-email-famz@redhat.com> References: <1454664263-25969-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH 02/12] Makefile: Rules for docker testing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org, jsnow@redhat.com, stefanha@redhat.com, sw@weilnetz.de, Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , david@gibson.dropbear.id.au This adds a group of make targets to run docker tests, all are available in source tree without running ./configure. The usage is shown by "make docker". Besides the fixed ones, dynamic targets for building each image and running each test in each image are generated automatically by make, scanning $(SRC_PATH)/tests/docker/ files with specific patterns. Alternative to manually list particular targets (docker-run-FOO@BAR) set, you can control which tests/images to run by filtering variables, TESTS= and IMAGES=, which are expressed in Makefile pattern syntax, "foo% %bar ...". For example: $ make docker-run IMAGES="ubuntu fedora" Unfortunately, it's impossible to propagate "-j $JOBS" into make in containers, however since each combination is made a first class target is the top Makefile, "make -j$N docker-run" still parallels the tests coarsely. Signed-off-by: Fam Zheng --- Makefile | 4 +- tests/docker/Makefile.include | 88 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 91 insertions(+), 1 deletion(-) create mode 100644 tests/docker/Makefile.include diff --git a/Makefile b/Makefile index d0de2d4..7da70f4 100644 --- a/Makefile +++ b/Makefile @@ -6,7 +6,7 @@ BUILD_DIR=$(CURDIR) # Before including a proper config-host.mak, assume we are in the source tree SRC_PATH=. -UNCHECKED_GOALS := %clean TAGS cscope ctags +UNCHECKED_GOALS := %clean TAGS cscope ctags docker docker-% # All following code might depend on configuration variables ifneq ($(wildcard config-host.mak),) @@ -651,3 +651,5 @@ endif # Include automatically generated dependency files # Dependencies in Makefile.objs files come from our recursive subdir rules -include $(wildcard *.d tests/*.d) + +include $(SRC_PATH)/tests/docker/Makefile.include diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include new file mode 100644 index 0000000..ca84c35 --- /dev/null +++ b/tests/docker/Makefile.include @@ -0,0 +1,88 @@ +# Makefile for Docker tests + +$(if $(quiet-command),,$(eval include $(SRC_PATH)/rules.mak)) + +.PHONY: docker docker-build docker-run docker-clean + +DOCKER_SUFFIX = .docker + +DOCKER_IMAGES := $(patsubst %$(DOCKER_SUFFIX),%, $(shell \ + ls $(SRC_PATH)/tests/docker/ | grep '$(DOCKER_SUFFIX)$$')) + +DOCKER_SCRIPTS := $(shell ls $(SRC_PATH)/tests/docker/ | grep '\.sh$$') +DOCKER_TESTS := $(filter test-%, $(DOCKER_SCRIPTS)) +DOCKER_TOOLS := $(filter-out test-%, $(DOCKER_SCRIPTS)) + +TESTS ?= % +IMAGES ?= % + +$(foreach i,$(DOCKER_IMAGES), \ + $(eval docker-build: docker-build-$i) \ + $(foreach t,$(DOCKER_SCRIPTS), \ + $(eval docker-build-$i docker-run-$t@$i: IMAGE=$i) \ + $(eval docker-run-$t@$i: SCRIPT=$t) \ + $(eval docker-run-$t@$i: docker-build-$i) \ + $(if $(filter test-%,$t), \ + $(eval docker-run: docker-run-$t@$i) \ + $(eval docker-run-$t@: docker-run-$t@$i) \ + $(eval docker-run-@$i: docker-run-$t@$i)) \ +)) + +docker: + @echo 'Building QEMU and running tests or tools inside Docker containers' + @echo + @echo 'Available targets:' + @echo + @echo ' docker: Print this help.' + @echo ' docker-run: Run all image/test combinations.' + @echo ' You can override the test cases to run by providing' + @echo ' TESTS="foo bar" in the make command, and the image set' + @echo ' by providing IMAGES="baz qux".' + @echo ' docker-clean: Kill and remove residual docker testing containers.' + @echo ' docker-build: Build all images.' + @echo ' docker-build-IMG: Build image "IMG".' + @echo ' "IMG" is one of the listed image name."' + @echo ' docker-run-FOO@BAR: Run "FOO" in container "BAR".' + @echo ' "FOO" must be one of the listed test/tool name."' + @echo ' "BAR" must be one of the listed image name."' + @echo ' docker-run-FOO@: Run "FOO" in all containers.' + @echo ' "FOO" must be one of the listed test name."' + @echo ' docker-run-@BAR: Run all tests in container "BAR".' + @echo ' "BAR" must be one of the listed image name."' + @echo + @echo 'Available images:' + @echo ' $(DOCKER_IMAGES)' + @echo + @echo 'Available tests:' + @echo ' $(DOCKER_TESTS)' + @echo + @echo 'Available tools:' + @echo ' $(DOCKER_TOOLS)' + +docker-build-%: + @if test -z "$(IMAGE)"; then echo "Invalid target"; exit 1; fi + $(if $(filter $(IMAGES),$(IMAGE)), $(call quiet-command,\ + $(SRC_PATH)/tests/docker/docker_build qemu:$(IMAGE) \ + $(SRC_PATH)/tests/docker/$(IMAGE).docker \ + $(if $V,-v,), " BUILD $(IMAGE)")) + +docker-run-%: + @if test -z "$(IMAGE)" || test -z "$(SCRIPT)"; \ + then echo "Invalid target"; exit 1; \ + fi + $(if $(filter $(TESTS),$(SCRIPT)),$(if $(filter $(IMAGES),$(IMAGE)), \ + $(call quiet-command,\ + $(SRC_PATH)/tests/docker/docker_run \ + --privileged -t --rm --net=none \ + -v $$(realpath $(SRC_PATH)):/var/tmp/qemu \ + -e QEMU_SRC=/var/tmp/qemu \ + -e V=$(V) \ + -v /var/tmp/qemu-docker-ccache:/var/tmp/ccache \ + -e CCACHE_DIR=/var/tmp/ccache \ + qemu:$(IMAGE) \ + /var/tmp/qemu/tests/docker/run \ + /var/tmp/qemu/tests/docker/$(SCRIPT); \ + , " RUN $(SCRIPT) in $(IMAGE)"))) + +docker-clean: + $(call quiet-command, $(SRC_PATH)/tests/docker/docker_clean) -- 2.4.3