From: Hollis Blanchard <hollis_blanchard@mentor.com>
To: qemu-devel@nongnu.org
Cc: stefanha@gmail.com, Hollis Blanchard <hollis_blanchard@mentor.com>
Subject: [Qemu-devel] [PATCH] trace: only create simple backend trace files when an event is emitted.
Date: Mon, 8 Feb 2016 10:51:55 -0800 [thread overview]
Message-ID: <1454957515-29258-1-git-send-email-hollis_blanchard@mentor.com> (raw)
In-Reply-To: <20160208153014.GD31586@stefanha-x1.localdomain>
Previously, trace record files (created by st_set_trace_file_enabled(true))
were created by the simple backend at initialization time, even if no events
were actually enabled.
As a consequence, the working directory would become littered with trace-PID
files just by enabling the simple backend at configure time, even when no
-trace options were used.
---
I've been using this to avoid creation of empty trace record files. I haven't
done any scientific performance studies, but an extra function
call/conditional/return when recording every trace event doesn't seem to have
any noticeable effect.
Signed-off-by: Hollis Blanchard <hollis_blanchard@mentor.com>
---
trace/simple.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/trace/simple.c b/trace/simple.c
index 3fdcc82..67ccc3c 100644
--- a/trace/simple.c
+++ b/trace/simple.c
@@ -209,6 +209,8 @@ int trace_record_start(TraceBufferRecord *rec, TraceEventID event, size_t datasi
uint64_t event_u64 = event;
uint64_t timestamp_ns = get_clock();
+ st_set_trace_file_enabled(true);
+
do {
old_idx = g_atomic_int_get(&trace_idx);
smp_rmb();
@@ -320,6 +322,7 @@ void st_set_trace_file_enabled(bool enable)
*/
void st_set_trace_file(const char *file)
{
+ /* Tracing will be re-enabled when the next event is written. */
st_set_trace_file_enabled(false);
g_free(trace_file_name);
@@ -330,8 +333,6 @@ void st_set_trace_file(const char *file)
} else {
trace_file_name = g_strdup_printf("%s", file);
}
-
- st_set_trace_file_enabled(true);
}
void st_print_trace_file_status(FILE *stream, int (*stream_printf)(FILE *stream, const char *fmt, ...))
--
1.9.1
next prev parent reply other threads:[~2016-02-08 18:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 23:13 [Qemu-devel] trace: timestamps, core IDs, and file creation Hollis Blanchard
2016-02-08 15:30 ` Stefan Hajnoczi
2016-02-08 16:29 ` Lluís Vilanova
2016-02-08 18:51 ` Hollis Blanchard [this message]
2016-02-08 20:02 ` [Qemu-devel] [PATCH] trace: only create simple backend trace files when an event is emitted Alex Bennée
2016-02-15 15:52 ` Stefan Hajnoczi
2016-02-15 15:54 ` Stefan Hajnoczi
2016-02-08 19:59 ` [Qemu-devel] trace: timestamps, core IDs, and file creation Hollis Blanchard
2016-02-15 15:29 ` Stefan Hajnoczi
2016-02-08 18:01 ` Alex Bennée
2016-02-08 18:34 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454957515-29258-1-git-send-email-hollis_blanchard@mentor.com \
--to=hollis_blanchard@mentor.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).