qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Sascha Silbe <silbe@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,
	Kevin Wolf <kwolf@redhat.com>,
	qemu-block@nongnu.org
Cc: Tu Bo <tubo@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 3/3] qemu-iotests: 140: use virtio-scsi instead of IDE
Date: Tue,  9 Feb 2016 14:15:13 +0100	[thread overview]
Message-ID: <1455023713-104799-4-git-send-email-silbe@linux.vnet.ibm.com> (raw)
In-Reply-To: <1455023713-104799-1-git-send-email-silbe@linux.vnet.ibm.com>

IDE is only implemented by very few architectures (mostly PC). Use
virtio-scsi instead so the test works on all architectures that
support virtio. In particular, this fixes qemu-iotests on s390x.

Fixes: 16dee418 ("iotests: Add test for eject under NBD server")
Signed-off-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
---
 tests/qemu-iotests/140 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/qemu-iotests/140 b/tests/qemu-iotests/140
index f78c317..0c448e6 100755
--- a/tests/qemu-iotests/140
+++ b/tests/qemu-iotests/140
@@ -49,8 +49,8 @@ _make_test_img 64k
 $QEMU_IO -c 'write -P 42 0 64k' "$TEST_IMG" | _filter_qemu_io
 
 keep_stderr=y \
-_launch_qemu -drive if=ide,media=cdrom,id=drv,file="$TEST_IMG",format=$IMGFMT \
-    2> >(_filter_nbd)
+_launch_qemu -drive if=none,media=cdrom,id=drv,file="$TEST_IMG",format=$IMGFMT \
+    -device virtio-scsi -device scsi-cd,drive=drv 2> >(_filter_nbd)
 
 _send_qemu_cmd $QEMU_HANDLE \
     "{ 'execute': 'qmp_capabilities' }" \
-- 
2.1.4

  parent reply	other threads:[~2016-02-09 13:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-09 13:15 [Qemu-devel] [PATCH 0/3] qemu-iotests: fix 140 on s390x Sascha Silbe
2016-02-09 13:15 ` [Qemu-devel] [PATCH 1/3] qdev-monitor: sort alias table by typename Sascha Silbe
2016-02-10 10:20   ` Halil Pasic
2016-02-11  8:53   ` Markus Armbruster
2016-02-11 16:32     ` Sascha Silbe
2016-02-09 13:15 ` [Qemu-devel] [PATCH 2/3] qdev-monitor: add missing aliases for virtio-{9p, balloon, rng, scsi} Sascha Silbe
2016-02-11  9:01   ` Markus Armbruster
2016-02-11  9:18     ` Cornelia Huck
2016-02-11 16:18       ` Sascha Silbe
2016-02-15 16:03         ` Cornelia Huck
2016-02-18 21:27           ` Sascha Silbe
2016-02-09 13:15 ` Sascha Silbe [this message]
2016-02-10 16:15   ` [Qemu-devel] [PATCH 3/3] qemu-iotests: 140: use virtio-scsi instead of IDE Max Reitz
2016-02-10 19:26     ` Sascha Silbe
2016-02-15 19:18       ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455023713-104799-4-git-send-email-silbe@linux.vnet.ibm.com \
    --to=silbe@linux.vnet.ibm.com \
    --cc=agraf@suse.de \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=tubo@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).