From: Ian Campbell <ian.campbell@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: qemu-devel@nongnu.org, xen-devel@lists.xen.org
Subject: Re: [Qemu-devel] [PATCH 1/5] xen: drop support for Xen 4.1 and older.
Date: Wed, 10 Feb 2016 10:30:05 +0000 [thread overview]
Message-ID: <1455100205.19857.148.camel@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1602091635460.27008@kaball.uk.xensource.com>
On Tue, 2016-02-09 at 16:50 +0000, Stefano Stabellini wrote:
> > @@ -2218,15 +2127,10 @@ EOF
> > fi
> >
> > if test "$xen_pci_passthrough" != "no"; then
> > - if test "$xen" = "yes" && test "$linux" = "yes" &&
> > - test "$xen_ctrl_version" -ge 340; then
> > + if test "$xen" = "yes" && test "$linux" = "yes"; then
> > xen_pci_passthrough=yes
> > else
> > if test "$xen_pci_passthrough" = "yes"; then
>
> Given that the code has been greatly simplified, I think that we can get
> rid of the test above.
Which one? I think we still need to check for both Linux and Xen being
present and handle users passing --enable-xen-pci-passthrough when those
conditions don't hold.
It might be possible to fold the else if, i.e.
if test "$xen_pci_passthrough" != "no"; then
if test "$xen" = "yes" && test "$linux" = "yes"; then
xen_pci_passthrough=yes
elif test "$xen_pci_passthrough" = "yes"; then
error_exit "User requested feature Xen PCI Passthrough" \
" but this feature requires /sys from Linux"
else
xen_pci_passthrough=no
fi
fi
?
next prev parent reply other threads:[~2016-02-10 10:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 16:16 [Qemu-devel] [PATCH 0/5] Drop support for Xen 4.1 and older from qemu-xen Ian Campbell
2016-02-09 16:17 ` [Qemu-devel] [PATCH 1/5] xen: drop support for Xen 4.1 and older Ian Campbell
2016-02-09 16:27 ` Peter Maydell
2016-02-09 16:50 ` Stefano Stabellini
2016-02-10 10:30 ` Ian Campbell [this message]
2016-02-10 10:45 ` Stefano Stabellini
2016-02-09 16:17 ` [Qemu-devel] [PATCH 2/5] xen: drop xen_xc_hvm_inject_msi wrapper Ian Campbell
2016-02-09 16:54 ` Stefano Stabellini
2016-02-09 16:17 ` [Qemu-devel] [PATCH 3/5] xen: drop XenXC and associated interface wrappers Ian Campbell
2016-02-09 17:18 ` Stefano Stabellini
2016-02-09 16:17 ` [Qemu-devel] [PATCH 4/5] xen: move xenforeignmemory compat layer into common place Ian Campbell
2016-02-09 17:18 ` Stefano Stabellini
2016-02-09 16:17 ` [Qemu-devel] [PATCH 5/5] xen: Drop __XEN_LATEST_INTERFACE_VERSION__ checks from prior to Xen 4.2 Ian Campbell
2016-02-09 17:23 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455100205.19857.148.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).