From: Marcel Apfelbaum <marcel@redhat.com>
To: qemu-devel@nongnu.org
Cc: marcel@redhat.com, lvivier@redhat.com, jasowang@redhat.com,
qemu-stable@nongnu.org, mst@redhat.com
Subject: [Qemu-devel] [PATCH 0/2] hw/virtio: fix double use of a virtio flag
Date: Wed, 10 Feb 2016 14:22:19 +0200 [thread overview]
Message-ID: <1455106941-2934-1-git-send-email-marcel@redhat.com> (raw)
To the obvious question of "how did that happen?"
I can say we had an unlucky break.
Both Jason and me worked on a new different virtio features in the same
time, and they were both merged in the same pull request.
We both saw BIT 3 as the last used
https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg03041.html
Commits 1811e64c and a6df8adf use the same virtio feature bit 4
for different features.
Fix it by using different bits.
While at it, group all the virtio flags into an enum to avoid that
in the feature.
Marcel Apfelbaum (2):
hw/virtio: fix double use of a virtio flag
hw/virtio: group virtio flags into an enum
hw/virtio/virtio-pci.h | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
--
2.4.3
next reply other threads:[~2016-02-10 12:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 12:22 Marcel Apfelbaum [this message]
2016-02-10 12:22 ` [Qemu-devel] [PATCH 1/2] hw/virtio: fix double use of a virtio flag Marcel Apfelbaum
2016-02-10 12:57 ` Laurent Vivier
2016-02-10 13:19 ` Laurent Vivier
2016-02-23 3:34 ` Jason Wang
2016-02-10 12:22 ` [Qemu-devel] [PATCH 2/2] hw/virtio: group virtio flags into an enum Marcel Apfelbaum
2016-02-10 13:07 ` Laurent Vivier
2016-02-10 13:24 ` Marcel Apfelbaum
2016-02-23 3:39 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455106941-2934-1-git-send-email-marcel@redhat.com \
--to=marcel@redhat.com \
--cc=jasowang@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).