From: Eric Blake <eblake@redhat.com>
To: luoyonggang@gmail.com, "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-level <qemu-devel@nongnu.org>
Subject: Re: [PATCH 4/5] meson: !/bin/sh are msys2 friendly.
Date: Tue, 25 Aug 2020 08:59:01 -0500 [thread overview]
Message-ID: <146febe9-64ae-96de-e2df-4a65a320de9b@redhat.com> (raw)
In-Reply-To: <CAE2XoE_jgZg8wjKZ5J5gPaR5VLORosJDv3+kr=re+LHqzbNoVg@mail.gmail.com>
On 8/25/20 4:11 AM, 罗勇刚(Yonggang Luo) wrote:
> Hi, works, msys2 sh compiled and run
Top-formatting makes it harder to read, compared to interleaving your
responses.
msys2 sh _is_ bash, so that's not answering the question Dan asked.
>>> +++ b/scripts/undefsym.sh
>>> @@ -1,4 +1,4 @@
>>> -#! /usr/bin/env bash
>>> +#!/bin/sh
>>
>> Does this script actually work on non-bash shells ? If not, then this
>> change will likely break on plaforms where /bin/sh is not bash.
A quick look at the script sees:
comm -12 \
<( $NM -P -g $staticlib | awk '$2!="U"{print "-Wl,-u," $1}' | sort -u) \
<( $NM -P -g "$@" | awk '$2=="U"{print "-Wl,-u," $1}' | sort -u)
<() is a bash'ism, so you _are_ breaking things on platforms like Debian
where /bin/sh is dash rather than bash.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-08-25 14:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 8:34 [PATCH 1/5] meson: SIMPLE_PATH_RE should match the full path token. Or the $ and : contained in path would not matched. if the path are start with C:/ and E:/ luoyonggang
2020-08-25 8:34 ` [PATCH 2/5] meson: fixes relpath may fail on win32. for example C:/msys64/mingw64/x.exe relative to E:/path/qemu-build would fail luoyonggang
2020-08-25 9:04 ` Daniel P. Berrangé
2020-08-25 8:34 ` [PATCH 3/5] meson: Mingw64 gcc doesn't recognize system include_type for sdl2 luoyonggang
2020-08-25 8:34 ` [PATCH 4/5] meson: !/bin/sh are msys2 friendly luoyonggang
2020-08-25 8:59 ` Daniel P. Berrangé
2020-08-25 9:11 ` 罗勇刚(Yonggang Luo)
2020-08-25 13:59 ` Eric Blake [this message]
2020-08-25 14:21 ` 罗勇刚(Yonggang Luo)
2020-08-25 8:35 ` [PATCH 5/5] configure: replace all $PWD with $build_path that can handling msys2 properly luoyonggang
2020-08-25 9:04 ` Daniel P. Berrangé
2020-08-25 9:05 ` [PATCH 1/5] meson: SIMPLE_PATH_RE should match the full path token. Or the $ and : contained in path would not matched. if the path are start with C:/ and E:/ Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=146febe9-64ae-96de-e2df-4a65a320de9b@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=luoyonggang@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).