From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH 4/9] drop arch-specific graphic_* initialization.
Date: Tue, 21 Feb 2017 23:14:54 +0100 [thread overview]
Message-ID: <1487715299-21102-5-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1487715299-21102-1-git-send-email-kraxel@redhat.com>
Now that sparc and ppc can deal with uninitialized graphic_* variables
we can drop the #ifdefs and also move the variables out of arch_init.c
as they are not arch specific any more.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
arch_init.c | 11 -----------
vl.c | 3 +++
2 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 0810116..f41af1c 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -34,17 +34,6 @@
#include "hw/acpi/acpi.h"
#include "qemu/help_option.h"
-#ifdef TARGET_SPARC
-int graphic_width = 1024;
-int graphic_height = 768;
-int graphic_depth = 8;
-#else
-int graphic_width = 800;
-int graphic_height = 600;
-int graphic_depth = 32;
-#endif
-
-
#if defined(TARGET_ALPHA)
#define QEMU_ARCH QEMU_ARCH_ALPHA
#elif defined(TARGET_ARM)
diff --git a/vl.c b/vl.c
index 27d9829..3be883e 100644
--- a/vl.c
+++ b/vl.c
@@ -135,6 +135,9 @@ const char *bios_name = NULL;
enum vga_retrace_method vga_retrace_method = VGA_RETRACE_DUMB;
int request_opengl = -1;
int display_opengl;
+int graphic_width;
+int graphic_height;
+int graphic_depth;
const char* keyboard_layout = NULL;
ram_addr_t ram_size;
const char *mem_path = NULL;
--
1.8.3.1
next prev parent reply other threads:[~2017-02-21 22:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 22:14 [Qemu-devel] [PATCH 0/9] wire up -g <width>x<height> switch for virtio and qxl Gerd Hoffmann
2017-02-21 22:14 ` [Qemu-devel] [PATCH 1/9] sysemu: add defines for sparc & ppc graphics_* Gerd Hoffmann
2017-02-28 14:50 ` Thomas Huth
2017-02-21 22:14 ` [Qemu-devel] [PATCH 2/9] sparc: use sparc_graphic_* defines Gerd Hoffmann
2017-02-21 22:14 ` [Qemu-devel] [PATCH 3/9] ppc: use ppc_graphic_* defines Gerd Hoffmann
2017-02-21 22:45 ` Hervé Poussineau
2017-02-22 1:11 ` David Gibson
2017-02-21 22:14 ` Gerd Hoffmann [this message]
2017-02-21 22:14 ` [Qemu-devel] [PATCH 5/9] enable -g command line switch for all archs Gerd Hoffmann
2017-02-28 14:53 ` Thomas Huth
2017-02-21 22:14 ` [Qemu-devel] [PATCH 6/9] virtio-gpu: use graphic_* variables Gerd Hoffmann
2017-02-24 9:21 ` Paolo Bonzini
2017-02-24 14:15 ` Gerd Hoffmann
2017-02-21 22:14 ` [Qemu-devel] [PATCH 7/9] qxl: " Gerd Hoffmann
2017-02-24 9:21 ` Paolo Bonzini
2017-02-21 22:14 ` [Qemu-devel] [PATCH 8/9] update -g command line switch documentation Gerd Hoffmann
2017-02-22 0:37 ` Laszlo Ersek
2017-02-21 22:14 ` [Qemu-devel] [PATCH 9/9] [RfC] stdvga: use graphic_* variables Gerd Hoffmann
2017-02-24 8:40 ` [Qemu-devel] [PATCH 0/9] wire up -g <width>x<height> switch for virtio and qxl Mark Cave-Ayland
2017-02-24 13:30 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487715299-21102-5-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).