qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com
Subject: Re: [PATCH 0/4] Convert remaining submodules to meson, cleanup env var handling
Date: Mon, 5 Oct 2020 12:15:11 -0500	[thread overview]
Message-ID: <148b5429-5668-2ae1-6506-53bc47160408@linaro.org> (raw)
In-Reply-To: <20201005135613.435932-1-pbonzini@redhat.com>

On 10/5/20 8:56 AM, Paolo Bonzini wrote:
> The main purpose of this series is to have a correct and consistent
> handling of CFLAGS/CXXFLAGS/LDFLAGS environment variables:
> 
> - correct: avoid that the -pie flag, used for the compiler checks in
> the configure script, ends up being passed to Meson if an LDFLAGS
> environment variable exists (patch 3)
> 
> - consistent: ensure that CFLAGS that are set in the configure
> script are persistent even if Meson is restarted; to do so,
> make the configure script store them in the cross file it generates.
> 
> In order to avoid having to deal with recursive make, patches 1
> and 2 integrate the Meson-based build system with the build of
> embedded slirp and libfdt.  This follows the lead of Richard's
> patches to do the same with Capstone.
> 
> Based-on: <20201003093851.324923-1-richard.henderson@linaro.org>
> Supersedes: <20200923092617.1593722-1-pbonzini@redhat.com>
> 
> Paolo Bonzini (4):
>   slirp: Convert Makefile bits to meson bits
>   dtc: Convert Makefile bits to meson bits
>   configure: do not clobber environment CFLAGS/CXXFLAGS/LDFLAGS
>   configure: consistently pass CFLAGS/CXXFLAGS/LDFLAGS to meson

Tested-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


      parent reply	other threads:[~2020-10-05 17:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-05 13:56 [PATCH 0/4] Convert remaining submodules to meson, cleanup env var handling Paolo Bonzini
2020-10-05 13:56 ` [PATCH 1/4] slirp: Convert Makefile bits to meson bits Paolo Bonzini
2020-10-05 13:56 ` [PATCH 2/4] dtc: " Paolo Bonzini
2020-10-05 14:13   ` Philippe Mathieu-Daudé
2020-10-05 14:16     ` Paolo Bonzini
2020-10-05 13:56 ` [PATCH 3/4] configure: do not clobber environment CFLAGS/CXXFLAGS/LDFLAGS Paolo Bonzini
2020-10-05 13:56 ` [PATCH 4/4] configure: consistently pass CFLAGS/CXXFLAGS/LDFLAGS to meson Paolo Bonzini
2020-10-05 17:15 ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=148b5429-5668-2ae1-6506-53bc47160408@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).