From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1317CA9EA0 for ; Fri, 25 Oct 2019 12:22:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97CA22084C for ; Fri, 25 Oct 2019 12:22:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97CA22084C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNybi-0006sg-Bb for qemu-devel@archiver.kernel.org; Fri, 25 Oct 2019 08:22:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50255) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNyYo-0001ch-1A for qemu-devel@nongnu.org; Fri, 25 Oct 2019 08:19:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNyYl-0006jM-UK for qemu-devel@nongnu.org; Fri, 25 Oct 2019 08:19:16 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:33555) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iNyYl-0006it-L5 for qemu-devel@nongnu.org; Fri, 25 Oct 2019 08:19:15 -0400 Received: from [192.168.100.1] ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.103]) with ESMTPSA (Nemesis) id 1N79Ey-1hwFaE2w0a-017RqA; Fri, 25 Oct 2019 14:19:10 +0200 Subject: Re: [PATCH v2 06/12] linux-user/sparc: Use WREG_SP constant in sparc/signal.c To: Richard Henderson , qemu-devel@nongnu.org References: <20191025113921.9412-1-richard.henderson@linaro.org> <20191025113921.9412-7-richard.henderson@linaro.org> From: Laurent Vivier Autocrypt: addr=laurent@vivier.eu; prefer-encrypt=mutual; keydata= mQINBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABtCJMYXVyZW50IFZp dmllciA8bGF1cmVudEB2aXZpZXIuZXU+iQI4BBMBAgAiBQJWBTDeAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAAKCRDzDDi9Py++PCEdD/oD8LD5UWxhQrMQCsUgLlXCSM7sxGLkwmmF ozqSSljEGRhffxZvO35wMFcdX9Z0QOabVoFTKrT04YmvbjsErh/dP5zeM/4EhUByeOS7s6Yl HubMXVQTkak9Wa9Eq6irYC6L41QNzz/oTwNEqL1weV1+XC3TNnht9B76lIaELyrJvRfgsp9M rE+PzGPo5h7QHWdL/Cmu8yOtPLa8Y6l/ywEJ040IoiAUfzRoaJs2csMXf0eU6gVBhCJ4bs91 jtWTXhkzdl4tdV+NOwj3j0ukPy+RjqeL2Ej+bomnPTOW8nAZ32dapmu7Fj7VApuQO/BSIHyO NkowMMjB46yohEepJaJZkcgseaus0x960c4ua/SUm/Nm6vioRsxyUmWd2nG0m089pp8LPopq WfAk1l4GciiMepp1Cxn7cnn1kmG6fhzedXZ/8FzsKjvx/aVeZwoEmucA42uGJ3Vk9TiVdZes lqMITkHqDIpHjC79xzlWkXOsDbA2UY/P18AtgJEZQPXbcrRBtdSifCuXdDfHvI+3exIdTpvj BfbgZAar8x+lcsQBugvktlQWPfAXZu4Shobi3/mDYMEDOE92dnNRD2ChNXg2IuvAL4OW40wh gXlkHC1ZgToNGoYVvGcZFug1NI+vCeCFchX+L3bXyLMg3rAfWMFPAZLzn42plIDMsBs+x2yP +bkCDQRWBSYZARAAvFJBFuX9A6eayxUPFaEczlMbGXugs0mazbOYGlyaWsiyfyc3PStHLFPj rSTaeJpPCjBJErwpZUN4BbpkBpaJiMuVO6egrC8Xy8/cnJakHPR2JPEvmj7Gm/L9DphTcE15 92rxXLesWzGBbuYxKsj8LEnrrvLyi3kNW6B5LY3Id+ZmU8YTQ2zLuGV5tLiWKKxc6s3eMXNq wrJTCzdVd6ThXrmUfAHbcFXOycUyf9vD+s+WKpcZzCXwKgm7x1LKsJx3UhuzT8ier1L363RW ZaJBZ9CTPiu8R5NCSn9V+BnrP3wlFbtLqXp6imGhazT9nJF86b5BVKpF8Vl3F0/Y+UZ4gUwL d9cmDKBcmQU/JaRUSWvvolNu1IewZZu3rFSVgcpdaj7F/1aC0t5vLdx9KQRyEAKvEOtCmP4m 38kU/6r33t3JuTJnkigda4+Sfu5kYGsogeYG6dNyjX5wpK5GJIJikEhdkwcLM+BUOOTi+I9u tX03BGSZo7FW/J7S9y0l5a8nooDs2gBRGmUgYKqQJHCDQyYut+hmcr+BGpUn9/pp2FTWijrP inb/Pc96YDQLQA1q2AeAFv3Rx3XoBTGl0RCY4KZ02c0kX/dm3eKfMX40XMegzlXCrqtzUk+N 8LeipEsnOoAQcEONAWWo1HcgUIgCjhJhBEF0AcELOQzitbJGG5UAEQEAAYkCHwQYAQIACQUC VgUmGQIbDAAKCRDzDDi9Py++PCD3D/9VCtydWDdOyMTJvEMRQGbx0GacqpydMEWbE3kUW0ha US5jz5gyJZHKR3wuf1En/3z+CEAEfP1M3xNGjZvpaKZXrgWaVWfXtGLoWAVTfE231NMQKGoB w2Dzx5ivIqxikXB6AanBSVpRpoaHWb06tPNxDL6SVV9lZpUn03DSR6gZEZvyPheNWkvz7bE6 FcqszV/PNvwm0C5Ju7NlJA8PBAQjkIorGnvN/vonbVh5GsRbhYPOc/JVwNNr63P76rZL8Gk/ hb3xtcIEi5CCzab45+URG/lzc6OV2nTj9Lg0SNcRhFZ2ILE3txrmI+aXmAu26+EkxLLfqCVT ohb2SffQha5KgGlOSBXustQSGH0yzzZVZb+HZPEvx6d/HjQ+t9sO1bCpEgPdZjyMuuMp9N1H ctbwGdQM2Qb5zgXO+8ZSzwC+6rHHIdtcB8PH2j+Nd88dVGYlWFKZ36ELeZxD7iJflsE8E8yg OpKgu3nD0ahBDqANU/ZmNNarBJEwvM2vfusmNnWm3QMIwxNuJghRyuFfx694Im1js0ZY3LEU JGSHFG4ZynA+ZFUPA6Xf0wHeJOxGKCGIyeKORsteIqgnkINW9fnKJw2pgk8qHkwVc3Vu+wGS ZiJK0xFusPQehjWTHn9WjMG1zvQ5TQQHxau/2FkP45+nRPco6vVFQe8JmgtRF8WFJA== Message-ID: <14bcf010-dc45-e625-081d-8e09e60bd493@vivier.eu> Date: Fri, 25 Oct 2019 14:19:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191025113921.9412-7-richard.henderson@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:a3NKM99kBgWnNDQNkgVx9CoLrahHsv87BZTvrdhZyl1BFzmpwWs csG1O7pFPtJpsycInbvzttuG3zOAS7KuJw7DRwBtV4zl1NaWe2cnLwUF/rVyq+SVSM2DeHM V7Emw+ho+3gtl7JcnOEuL7EyN3LnmN+0xu8CKmKeq2ZlSTjNu2qURVuMSfL9lqbOzn4mkMF iqYcKMxcOnkX1O+ZdvsOQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:Ykn6uv+OeEo=:mEi7/PgM/MuBgK72e8ZQlz rVIegCF3tsIhIhQFv12Shb3sIF+zaH7BnHyFMIynZYy4OOo1hRqj99stcgdx4Domjs3m00qCh vL4jJOnQ+I0SHHuvP145f3opYnvIQ1im4ZgvJ+tWIUT66lpNhyXHllhfjsAyh9QQUzZpqrFec t6IdYhPFpqCTLjrNU7zh813NeR1uYt9ftx5ap8OP3hY1ia+2MsM7m9je6A8np/vqayWSiHAlh iFZik5fK4wXzkv9ON5xiYQbkXXfwMRdhp51HWO5T2T4BwZjX7RDyRhoUJ/KqcmHz/gUcfy8p4 +M3tBFMaYG/2mETDxW7hxWRfDRdL85P7uWm8o/KsNeLdByByjiiA6zOZNIDVBYvp2+rm8svJc waah9Yp+BOWWtCA8cq8Hbx8s8lGSG7Djk+wlsav11aGWglnIkHRFx8LSftBMSj7evKLXPCqLP EEGlYHKtsEPIHUR/OKcIj9ur+qng+KS6C4fgTUGpuXw3VBu4+FeZQUCv4W860lmfDQmdsL+UM rbZurK/Ok4OPyAtDTeOFc4ZYJkGJqF1WU4nZpu8s8ekH1PNN2GML79BJNPJJi/Pfsh81QyPJO X4mFmRLs7L7SScSsnqX6Od3Va0IyGFPDuRS/WVvN7lHYGlWYbio9X5ojczjBuEwkrYXmVM0AN OjlgN/HBBT9XYZE6D40ZhxyIqxHxK6jlUkYdT+RklVRtNFQ9PRTqwAiuyZIcuz+9pXLqED+9i eGQ5WC3TAIeGzvCuPaWW9xka+W/pRoHgHUsK9iQ+jp4dmz7xb3W3UE95irWMDLbpKHCXjuNm8 ttg9T+5bAVAQh5X1oJE3m32fCOFTz1ccLzvmuIgFKPn4OJ7Cq+LhaVqnOuGxjhzp6hbTddbYO C1JO5p/l4cSu8xS6Pldue3k6w702PS/m2dRy0VVbM= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.126.135 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 25/10/2019 à 13:39, Richard Henderson a écrit : > s/UREG_FP/WREG_SP/g > > This is non-obvious because the UREG_FP constant is fact wrong. > However, the previous search-and-replace patch made it clear that > UREG_FP expands to WREG_O6, and we can see from the enumeration in > target/sparc/cpu.h that WREG_O6 is in fact WREG_SP, the stack pointer. > > The UREG_SP define is unused; remove it. > > Signed-off-by: Richard Henderson > --- > linux-user/sparc/signal.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/linux-user/sparc/signal.c b/linux-user/sparc/signal.c > index a967e2db73..0db4c5f84f 100644 > --- a/linux-user/sparc/signal.c > +++ b/linux-user/sparc/signal.c > @@ -104,9 +104,6 @@ struct target_rt_signal_frame { > qemu_siginfo_fpu_t fpu_state; > }; > > -#define UREG_FP WREG_O6 > -#define UREG_SP WREG_I6 > - > static inline abi_ulong get_sigframe(struct target_sigaction *sa, > CPUSPARCState *env, > unsigned long framesize) > @@ -201,7 +198,7 @@ void setup_frame(int sig, struct target_sigaction *ka, > goto sigsegv; > > /* 3. signal handler back-trampoline and parameters */ > - env->regwptr[UREG_FP] = sf_addr; > + env->regwptr[WREG_SP] = sf_addr; > env->regwptr[WREG_O0] = sig; > env->regwptr[WREG_O1] = sf_addr + > offsetof(struct target_signal_frame, info); > @@ -255,7 +252,7 @@ long do_sigreturn(CPUSPARCState *env) > sigset_t host_set; > int i; > > - sf_addr = env->regwptr[UREG_FP]; > + sf_addr = env->regwptr[WREG_SP]; > trace_user_do_sigreturn(env, sf_addr); > if (!lock_user_struct(VERIFY_READ, sf, sf_addr, 1)) { > goto segv_and_exit; > Reviewed-by: Laurent Vivier