[Qemu-devel] [Bug 1817345] [NEW] configure script breaks when $source_path contains white spaces

[Qemu-devel] [Bug 1817345] [NEW] configure script breaks when $source_path contains white spaces

[Antonio Ospite]

Public bug reported:

Hi,

I noticed that the configure script breaks when the qemu source
directory is in a path containing white spaces, in particular the list
of targets is not correctly generated when calling "./configure --help".

Steps to reproduce the problem:

$ mkdir "dir with spaces"
$ cd dir\ with\ spaces/
$ git clone https://git.qemu.org/git/qemu.git
$ cd qemu/
$ ./configure --help | grep -A3 target-list


Actual result:

  --target-list=LIST       set target list (default: build everything)
                           Available targets: dir with *-softmmu dir with 
                           *-linux-user


Expected result:

  --target-list=LIST       set target list (default: build everything)
                           Available targets: aarch64-softmmu alpha-softmmu 
                           arm-softmmu cris-softmmu hppa-softmmu i386-softmmu 
                           lm32-softmmu m68k-softmmu microblaze-softmmu 


This happens because the $mak_wilds variable uses spaces to separate different paths, maybe newlines may be used, which are less likely to be in directory names.

BTW "shellcheck" may help finding some other problems.

Qemu version:

$ git describe 
v3.1.0-1960-ga05838cb2a

Thanks,
   Antonio

** Affects: qemu
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1817345

Title:
  configure script breaks when $source_path contains white spaces

Status in QEMU:
  New

Bug description:
  Hi,

  I noticed that the configure script breaks when the qemu source
  directory is in a path containing white spaces, in particular the list
  of targets is not correctly generated when calling "./configure
  --help".

  Steps to reproduce the problem:

  $ mkdir "dir with spaces"
  $ cd dir\ with\ spaces/
  $ git clone https://git.qemu.org/git/qemu.git
  $ cd qemu/
  $ ./configure --help | grep -A3 target-list

  
  Actual result:

    --target-list=LIST       set target list (default: build everything)
                             Available targets: dir with *-softmmu dir with 
                             *-linux-user

  
  Expected result:

    --target-list=LIST       set target list (default: build everything)
                             Available targets: aarch64-softmmu alpha-softmmu 
                             arm-softmmu cris-softmmu hppa-softmmu i386-softmmu 
                             lm32-softmmu m68k-softmmu microblaze-softmmu 

  
  This happens because the $mak_wilds variable uses spaces to separate different paths, maybe newlines may be used, which are less likely to be in directory names.

  BTW "shellcheck" may help finding some other problems.

  Qemu version:

  $ git describe 
  v3.1.0-1960-ga05838cb2a

  Thanks,
     Antonio

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1817345/+subscriptions

[Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces

[Michael Tokarev]

I think it is better to just disallow building in a path containing
spaces, -- there are so many packages and other tools that fails in this
config, might require lots of work to fix this AND to ensure all future
changes are still working, and there's an easy workaround

Just my few cents.

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1817345

Title:
  configure script breaks when $source_path contains white spaces

Status in QEMU:
  New

Bug description:
  Hi,

  I noticed that the configure script breaks when the qemu source
  directory is in a path containing white spaces, in particular the list
  of targets is not correctly generated when calling "./configure
  --help".

  Steps to reproduce the problem:

  $ mkdir "dir with spaces"
  $ cd dir\ with\ spaces/
  $ git clone https://git.qemu.org/git/qemu.git
  $ cd qemu/
  $ ./configure --help | grep -A3 target-list

  
  Actual result:

    --target-list=LIST       set target list (default: build everything)
                             Available targets: dir with *-softmmu dir with 
                             *-linux-user

  
  Expected result:

    --target-list=LIST       set target list (default: build everything)
                             Available targets: aarch64-softmmu alpha-softmmu 
                             arm-softmmu cris-softmmu hppa-softmmu i386-softmmu 
                             lm32-softmmu m68k-softmmu microblaze-softmmu 

  
  This happens because the $mak_wilds variable uses spaces to separate different paths, maybe newlines may be used, which are less likely to be in directory names.

  BTW "shellcheck" may help finding some other problems.

  Qemu version:

  $ git describe 
  v3.1.0-1960-ga05838cb2a

  Thanks,
     Antonio

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1817345/+subscriptions

Re: [Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces

[Peter Maydell]

On Sun, 24 Feb 2019 at 19:46, Michael Tokarev
<1817345@bugs.launchpad.net> wrote:
> I think it is better to just disallow building in a path containing
> spaces, -- there are so many packages and other tools that fails in this
> config, might require lots of work to fix this AND to ensure all future
> changes are still working, and there's an easy workaround

Certainly I bet that the problems with spaces in the path do
not stop with the handling of the target-list help message.
Make does not really get on at all with spaces...
It would probably be helpful if we made configure complain
if it finds spaces in the build or source paths.

thanks
-- PMM

[Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces

[Antonio Ospite]

I am OK with just checking and complaining.

Linux too solves the problem in this way:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/Makefile?id=51193b76bfff5027cf96ba63effae808ad67cca7

A general "shellcheck" pass wouldn't hurt, tho.

Thank you,
   Antonio

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1817345

Title:
  configure script breaks when $source_path contains white spaces

Status in QEMU:
  New

Bug description:
  Hi,

  I noticed that the configure script breaks when the qemu source
  directory is in a path containing white spaces, in particular the list
  of targets is not correctly generated when calling "./configure
  --help".

  Steps to reproduce the problem:

  $ mkdir "dir with spaces"
  $ cd dir\ with\ spaces/
  $ git clone https://git.qemu.org/git/qemu.git
  $ cd qemu/
  $ ./configure --help | grep -A3 target-list

  
  Actual result:

    --target-list=LIST       set target list (default: build everything)
                             Available targets: dir with *-softmmu dir with 
                             *-linux-user

  
  Expected result:

    --target-list=LIST       set target list (default: build everything)
                             Available targets: aarch64-softmmu alpha-softmmu 
                             arm-softmmu cris-softmmu hppa-softmmu i386-softmmu 
                             lm32-softmmu m68k-softmmu microblaze-softmmu 

  
  This happens because the $mak_wilds variable uses spaces to separate different paths, maybe newlines may be used, which are less likely to be in directory names.

  BTW "shellcheck" may help finding some other problems.

  Qemu version:

  $ git describe 
  v3.1.0-1960-ga05838cb2a

  Thanks,
     Antonio

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1817345/+subscriptions

[Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces

[Deepika Choudhary]

If calling from any Unix shell, and the parameter has spaces, then we
need to quote it.we can also use single quotes, these are more powerful.
They stop the shell from interpreting anything ($, !, \, *, ", etc,
except ').


can't we use this approach here??

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1817345

Title:
  configure script breaks when $source_path contains white spaces

Status in QEMU:
  New

Bug description:
  Hi,

  I noticed that the configure script breaks when the qemu source
  directory is in a path containing white spaces, in particular the list
  of targets is not correctly generated when calling "./configure
  --help".

  Steps to reproduce the problem:

  $ mkdir "dir with spaces"
  $ cd dir\ with\ spaces/
  $ git clone https://git.qemu.org/git/qemu.git
  $ cd qemu/
  $ ./configure --help | grep -A3 target-list

  
  Actual result:

    --target-list=LIST       set target list (default: build everything)
                             Available targets: dir with *-softmmu dir with 
                             *-linux-user

  
  Expected result:

    --target-list=LIST       set target list (default: build everything)
                             Available targets: aarch64-softmmu alpha-softmmu 
                             arm-softmmu cris-softmmu hppa-softmmu i386-softmmu 
                             lm32-softmmu m68k-softmmu microblaze-softmmu 

  
  This happens because the $mak_wilds variable uses spaces to separate different paths, maybe newlines may be used, which are less likely to be in directory names.

  BTW "shellcheck" may help finding some other problems.

  Qemu version:

  $ git describe 
  v3.1.0-1960-ga05838cb2a

  Thanks,
     Antonio

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1817345/+subscriptions

[Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces

[Peter Maydell]

Deepika: the tricky part is the makefiles, not the configure script...

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1817345

Title:
  configure script breaks when $source_path contains white spaces

Status in QEMU:
  New

Bug description:
  Hi,

  I noticed that the configure script breaks when the qemu source
  directory is in a path containing white spaces, in particular the list
  of targets is not correctly generated when calling "./configure
  --help".

  Steps to reproduce the problem:

  $ mkdir "dir with spaces"
  $ cd dir\ with\ spaces/
  $ git clone https://git.qemu.org/git/qemu.git
  $ cd qemu/
  $ ./configure --help | grep -A3 target-list

  
  Actual result:

    --target-list=LIST       set target list (default: build everything)
                             Available targets: dir with *-softmmu dir with 
                             *-linux-user

  
  Expected result:

    --target-list=LIST       set target list (default: build everything)
                             Available targets: aarch64-softmmu alpha-softmmu 
                             arm-softmmu cris-softmmu hppa-softmmu i386-softmmu 
                             lm32-softmmu m68k-softmmu microblaze-softmmu 

  
  This happens because the $mak_wilds variable uses spaces to separate different paths, maybe newlines may be used, which are less likely to be in directory names.

  BTW "shellcheck" may help finding some other problems.

  Qemu version:

  $ git describe 
  v3.1.0-1960-ga05838cb2a

  Thanks,
     Antonio

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1817345/+subscriptions

Re: [Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces

[Deepika Choudhary]

Oh~
Okay!

On Sun, Mar 10, 2019, 02:30 Peter Maydell <peter.maydell@linaro.org>
wrote:

> Deepika: the tricky part is the makefiles, not the configure script...
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1817345
>
> Title:
>   configure script breaks when $source_path contains white spaces
>
> Status in QEMU:
>   New
>
> Bug description:
>   Hi,
>
>   I noticed that the configure script breaks when the qemu source
>   directory is in a path containing white spaces, in particular the list
>   of targets is not correctly generated when calling "./configure
>   --help".
>
>   Steps to reproduce the problem:
>
>   $ mkdir "dir with spaces"
>   $ cd dir\ with\ spaces/
>   $ git clone https://git.qemu.org/git/qemu.git
>   $ cd qemu/
>   $ ./configure --help | grep -A3 target-list
>
>
>   Actual result:
>
>     --target-list=LIST       set target list (default: build everything)
>                              Available targets: dir with *-softmmu dir
> with
>                              *-linux-user
>
>
>   Expected result:
>
>     --target-list=LIST       set target list (default: build everything)
>                              Available targets: aarch64-softmmu
> alpha-softmmu
>                              arm-softmmu cris-softmmu hppa-softmmu
> i386-softmmu
>                              lm32-softmmu m68k-softmmu microblaze-softmmu
>
>
>   This happens because the $mak_wilds variable uses spaces to separate
> different paths, maybe newlines may be used, which are less likely to be in
> directory names.
>
>   BTW "shellcheck" may help finding some other problems.
>
>   Qemu version:
>
>   $ git describe
>   v3.1.0-1960-ga05838cb2a
>
>   Thanks,
>      Antonio
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/qemu/+bug/1817345/+subscriptions
>

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1817345

Title:
  configure script breaks when $source_path contains white spaces

Status in QEMU:
  New

Bug description:
  Hi,

  I noticed that the configure script breaks when the qemu source
  directory is in a path containing white spaces, in particular the list
  of targets is not correctly generated when calling "./configure
  --help".

  Steps to reproduce the problem:

  $ mkdir "dir with spaces"
  $ cd dir\ with\ spaces/
  $ git clone https://git.qemu.org/git/qemu.git
  $ cd qemu/
  $ ./configure --help | grep -A3 target-list

  
  Actual result:

    --target-list=LIST       set target list (default: build everything)
                             Available targets: dir with *-softmmu dir with 
                             *-linux-user

  
  Expected result:

    --target-list=LIST       set target list (default: build everything)
                             Available targets: aarch64-softmmu alpha-softmmu 
                             arm-softmmu cris-softmmu hppa-softmmu i386-softmmu 
                             lm32-softmmu m68k-softmmu microblaze-softmmu 

  
  This happens because the $mak_wilds variable uses spaces to separate different paths, maybe newlines may be used, which are less likely to be in directory names.

  BTW "shellcheck" may help finding some other problems.

  Qemu version:

  $ git describe 
  v3.1.0-1960-ga05838cb2a

  Thanks,
     Antonio

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1817345/+subscriptions

[Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces

[Peter Maydell]

Antonio has submitted a patchset here:
https://patchew.org/QEMU/20190503082728.16485-1-ao2@ao2.it/


** Changed in: qemu
       Status: New => In Progress

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1817345

Title:
  configure script breaks when $source_path contains white spaces

Status in QEMU:
  In Progress

Bug description:
  Hi,

  I noticed that the configure script breaks when the qemu source
  directory is in a path containing white spaces, in particular the list
  of targets is not correctly generated when calling "./configure
  --help".

  Steps to reproduce the problem:

  $ mkdir "dir with spaces"
  $ cd dir\ with\ spaces/
  $ git clone https://git.qemu.org/git/qemu.git
  $ cd qemu/
  $ ./configure --help | grep -A3 target-list

  
  Actual result:

    --target-list=LIST       set target list (default: build everything)
                             Available targets: dir with *-softmmu dir with 
                             *-linux-user

  
  Expected result:

    --target-list=LIST       set target list (default: build everything)
                             Available targets: aarch64-softmmu alpha-softmmu 
                             arm-softmmu cris-softmmu hppa-softmmu i386-softmmu 
                             lm32-softmmu m68k-softmmu microblaze-softmmu 

  
  This happens because the $mak_wilds variable uses spaces to separate different paths, maybe newlines may be used, which are less likely to be in directory names.

  BTW "shellcheck" may help finding some other problems.

  Qemu version:

  $ git describe 
  v3.1.0-1960-ga05838cb2a

  Thanks,
     Antonio

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1817345/+subscriptions

[Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces

[Peter Maydell]

Antonio has submitted a patchset here:
https://patchew.org/QEMU/20190503082728.16485-1-ao2@ao2.it/


** Changed in: qemu
       Status: New => In Progress

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1817345

Title:
  configure script breaks when $source_path contains white spaces

Status in QEMU:
  In Progress

Bug description:
  Hi,

  I noticed that the configure script breaks when the qemu source
  directory is in a path containing white spaces, in particular the list
  of targets is not correctly generated when calling "./configure
  --help".

  Steps to reproduce the problem:

  $ mkdir "dir with spaces"
  $ cd dir\ with\ spaces/
  $ git clone https://git.qemu.org/git/qemu.git
  $ cd qemu/
  $ ./configure --help | grep -A3 target-list

  
  Actual result:

    --target-list=LIST       set target list (default: build everything)
                             Available targets: dir with *-softmmu dir with 
                             *-linux-user

  
  Expected result:

    --target-list=LIST       set target list (default: build everything)
                             Available targets: aarch64-softmmu alpha-softmmu 
                             arm-softmmu cris-softmmu hppa-softmmu i386-softmmu 
                             lm32-softmmu m68k-softmmu microblaze-softmmu 

  
  This happens because the $mak_wilds variable uses spaces to separate different paths, maybe newlines may be used, which are less likely to be in directory names.

  BTW "shellcheck" may help finding some other problems.

  Qemu version:

  $ git describe 
  v3.1.0-1960-ga05838cb2a

  Thanks,
     Antonio

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1817345/+subscriptions

[Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces

[Peter Maydell]

Antonio's patches are in git and will be in the upcoming 4.1.0 release.


** Changed in: qemu
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1817345

Title:
  configure script breaks when $source_path contains white spaces

Status in QEMU:
  Fix Committed

Bug description:
  Hi,

  I noticed that the configure script breaks when the qemu source
  directory is in a path containing white spaces, in particular the list
  of targets is not correctly generated when calling "./configure
  --help".

  Steps to reproduce the problem:

  $ mkdir "dir with spaces"
  $ cd dir\ with\ spaces/
  $ git clone https://git.qemu.org/git/qemu.git
  $ cd qemu/
  $ ./configure --help | grep -A3 target-list

  
  Actual result:

    --target-list=LIST       set target list (default: build everything)
                             Available targets: dir with *-softmmu dir with 
                             *-linux-user

  
  Expected result:

    --target-list=LIST       set target list (default: build everything)
                             Available targets: aarch64-softmmu alpha-softmmu 
                             arm-softmmu cris-softmmu hppa-softmmu i386-softmmu 
                             lm32-softmmu m68k-softmmu microblaze-softmmu 

  
  This happens because the $mak_wilds variable uses spaces to separate different paths, maybe newlines may be used, which are less likely to be in directory names.

  BTW "shellcheck" may help finding some other problems.

  Qemu version:

  $ git describe 
  v3.1.0-1960-ga05838cb2a

  Thanks,
     Antonio

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1817345/+subscriptions

[Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces

[Thomas Huth]

Patch included here:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=4ace32e22713ffd79deb22

** Changed in: qemu
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1817345

Title:
  configure script breaks when $source_path contains white spaces

Status in QEMU:
  Fix Released

Bug description:
  Hi,

  I noticed that the configure script breaks when the qemu source
  directory is in a path containing white spaces, in particular the list
  of targets is not correctly generated when calling "./configure
  --help".

  Steps to reproduce the problem:

  $ mkdir "dir with spaces"
  $ cd dir\ with\ spaces/
  $ git clone https://git.qemu.org/git/qemu.git
  $ cd qemu/
  $ ./configure --help | grep -A3 target-list

  
  Actual result:

    --target-list=LIST       set target list (default: build everything)
                             Available targets: dir with *-softmmu dir with 
                             *-linux-user

  
  Expected result:

    --target-list=LIST       set target list (default: build everything)
                             Available targets: aarch64-softmmu alpha-softmmu 
                             arm-softmmu cris-softmmu hppa-softmmu i386-softmmu 
                             lm32-softmmu m68k-softmmu microblaze-softmmu 

  
  This happens because the $mak_wilds variable uses spaces to separate different paths, maybe newlines may be used, which are less likely to be in directory names.

  BTW "shellcheck" may help finding some other problems.

  Qemu version:

  $ git describe 
  v3.1.0-1960-ga05838cb2a

  Thanks,
     Antonio

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1817345/+subscriptions