From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:49996) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxziZ-0001SG-9J for qemu-devel@nongnu.org; Sun, 24 Feb 2019 14:45:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gxziY-0000Eo-8I for qemu-devel@nongnu.org; Sun, 24 Feb 2019 14:45:43 -0500 Received: from indium.canonical.com ([91.189.90.7]:37332) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gxziX-00007U-W7 for qemu-devel@nongnu.org; Sun, 24 Feb 2019 14:45:42 -0500 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.86_2 #2 (Debian)) id 1gxziP-0001Po-Oe for ; Sun, 24 Feb 2019 19:45:33 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id 875A12E80CC for ; Sun, 24 Feb 2019 19:45:33 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Sun, 24 Feb 2019 19:38:56 -0000 From: Michael Tokarev <1817345@bugs.launchpad.net> Reply-To: Bug 1817345 <1817345@bugs.launchpad.net> Sender: bounces@canonical.com References: <155085278488.30597.14551761138419562879.malonedeb@chaenomeles.canonical.com> Message-Id: <155103713660.11385.8973225882401821375.malone@gac.canonical.com> Errors-To: bounces@canonical.com Subject: [Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org I think it is better to just disallow building in a path containing spaces, -- there are so many packages and other tools that fails in this config, might require lots of work to fix this AND to ensure all future changes are still working, and there's an easy workaround Just my few cents. -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1817345 Title: configure script breaks when $source_path contains white spaces Status in QEMU: New Bug description: Hi, I noticed that the configure script breaks when the qemu source directory is in a path containing white spaces, in particular the list of targets is not correctly generated when calling "./configure --help". Steps to reproduce the problem: $ mkdir "dir with spaces" $ cd dir\ with\ spaces/ $ git clone https://git.qemu.org/git/qemu.git $ cd qemu/ $ ./configure --help | grep -A3 target-list = Actual result: --target-list=3DLIST set target list (default: build everything) Available targets: dir with *-softmmu dir with = *-linux-user = Expected result: --target-list=3DLIST set target list (default: build everything) Available targets: aarch64-softmmu alpha-softm= mu = arm-softmmu cris-softmmu hppa-softmmu i386-sof= tmmu = lm32-softmmu m68k-softmmu microblaze-softmmu = = This happens because the $mak_wilds variable uses spaces to separate diff= erent paths, maybe newlines may be used, which are less likely to be in dir= ectory names. BTW "shellcheck" may help finding some other problems. Qemu version: $ git describe = v3.1.0-1960-ga05838cb2a Thanks, Antonio To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1817345/+subscriptions