From: umarcor <1817239@bugs.launchpad.net>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [Bug 1817239] Re: add '--targets' option to qemu-binfmt-conf.sh
Date: Sat, 09 Mar 2019 01:35:41 -0000 [thread overview]
Message-ID: <155209534203.9449.13630241082296365109.malone@gac.canonical.com> (raw)
In-Reply-To: 155080581544.22842.8774442486795126526.malonedeb@wampee.canonical.com
I submitted a first version some days ago, which homogeneized the
implementation, as suggested by Laurent Vivier. It received some
feedback from Eric Blake. A patchset (v3) is ready for review:
https://patchew.org/QEMU/20190306031221.GA53@03612eec87fc/#
The feature requested in this issue is included in the patchset:
[Qemu-devel] [PATCH v3 6/10] qemu-binfmt-conf.sh: generalize <CPU> to positional <CPUS>
https://patchew.org/QEMU/20190306031221.GA53@03612eec87fc/20190306045019.GF75@03612eec87fc/
Note that, instead of adding a parameter named `--target`, positional
arguments are used, which where not being processed at all.
** Changed in: qemu
Status: New => In Progress
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1817239
Title:
add '--targets' option to qemu-binfmt-conf.sh
Status in QEMU:
In Progress
Bug description:
I'd like to ask for the addition of option '--targets' to scripts
/qemu-binfmt-conf.sh, in order to allow registering the interpreters
for the given list of architectures only, instead of using all of the
ones defined in qemu_target_list. The following is a possible patch
that implements it:
qemu-binfmt-conf.sh | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/qemu-binfmt-conf.sh b/qemu-binfmt-conf.sh
index b5a1674..be4a19b 100644
--- a/qemu-binfmt-conf.sh
+++ b/qemu-binfmt-conf.sh
@@ -170,6 +170,7 @@ usage() {
Usage: qemu-binfmt-conf.sh [--qemu-path PATH][--debian][--systemd CPU]
[--help][--credential yes|no][--exportdir PATH]
[--persistent yes|no][--qemu-suffix SUFFIX]
+ [--targets TARGETS]
Configure binfmt_misc to use qemu interpreter
@@ -189,6 +190,8 @@ Usage: qemu-binfmt-conf.sh [--qemu-path PATH][--debian][--systemd CPU]
--persistent: if yes, the interpreter is loaded when binfmt is
configured and remains in memory. All future uses
are cloned from the open file.
+ --targets: comma-separated list of targets. If provided, only
+ the targets in the list are registered.
To import templates with update-binfmts, use :
@@ -324,7 +327,7 @@ CREDENTIAL=no
PERSISTENT=no
QEMU_SUFFIX=""
-options=$(getopt -o ds:Q:S:e:hc:p: -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential:,persistent: -- "$@")
+options=$(getopt -o ds:Q:S:e:hc:p:t: -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential:,persistent:,targets: -- "$@")
eval set -- "$options"
while true ; do
@@ -380,6 +383,10 @@ while true ; do
shift
PERSISTENT="$1"
;;
+ -t|--targets)
+ shift
+ qemu_target_list="$(echo "$1" | tr ',' ' ')"
+ ;;
*)
break
;;
--
2.20.1
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1817239/+subscriptions
next prev parent reply other threads:[~2019-03-09 1:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 3:23 [Qemu-devel] [Bug 1817239] [NEW] add '--targets' option to qemu-binfmt-conf.sh umarcor
2019-02-22 7:32 ` Laurent Vivier
2019-03-09 1:35 ` umarcor [this message]
2020-11-04 23:04 ` [Bug 1817239] " John Snow
2021-04-20 8:21 ` Thomas Huth
2021-06-20 4:17 ` Launchpad Bug Tracker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155209534203.9449.13630241082296365109.malone@gac.canonical.com \
--to=1817239@bugs.launchpad.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).