From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL v3 03/12] Include qemu/module.h where needed, drop it from qemu-common.h
Date: Mon, 24 Jun 2019 19:14:27 +0200 [thread overview]
Message-ID: <1553aaa3-aae1-074c-a885-f7d185fcfb58@amsat.org> (raw)
In-Reply-To: <20190612112747.16374-2-armbru@redhat.com>
Hi Markus,
On 6/12/19 1:27 PM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Message-Id: <20190523143508.25387-4-armbru@redhat.com>
> [Rebased with conflicts resolved automatically, except for
> hw/usb/dev-hub.c hw/misc/exynos4210_rng.c hw/misc/bcm2835_rng.c
> hw/misc/aspeed_scu.c hw/display/virtio-vga.c hw/arm/stm32f205_soc.c;
> ui/cocoa.m fixed up]
> ---
[...]
> hw/core/empty_slot.c | 1 +
[...]
> diff --git a/hw/core/empty_slot.c b/hw/core/empty_slot.c
> index 239f78e2a7..c694532046 100644
> --- a/hw/core/empty_slot.c
> +++ b/hw/core/empty_slot.c
> @@ -12,6 +12,7 @@
> #include "qemu/osdep.h"
> #include "hw/hw.h"
> #include "hw/sysbus.h"
> +#include "qemu/module.h"
> #include "hw/empty_slot.h"
>
> //#define DEBUG_EMPTY_SLOT
Why is this include required in this file?
I think I'm missing how modules are used.
Thanks,
Phil.
next prev parent reply other threads:[~2019-06-24 17:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 11:27 [Qemu-devel] [PULL v3 00/12] Miscellaneous patches for 2019-06-11 Markus Armbruster
2019-06-12 11:27 ` [Qemu-devel] [PULL v3 03/12] Include qemu/module.h where needed, drop it from qemu-common.h Markus Armbruster
2019-06-24 17:14 ` Philippe Mathieu-Daudé [this message]
2019-06-12 13:43 ` [Qemu-devel] [PULL v3 00/12] Miscellaneous patches for 2019-06-11 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553aaa3-aae1-074c-a885-f7d185fcfb58@amsat.org \
--to=f4bug@amsat.org \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).