qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>
Cc: michael.roth@amd.com, Markus Armbruster <armbru@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [RFC] adding a generic QAPI event for failed device hotunplug
Date: Fri, 5 Mar 2021 15:16:10 -0300	[thread overview]
Message-ID: <155911cc-8764-1a65-4bb3-2fc0628d52e5@gmail.com> (raw)

Hi,

Recent changes in pseries code (not yet pushed, available at David's
ppc-for-6.0) are using the QAPI event MEM_UNPLUG_ERROR to report memory
hotunplug errors in the pseries machine.

The pseries machine is also using a timeout to cancel CPU hotunplugs that
takes too long to finish (in which we're assuming a guest side error) and
it would be desirable to also send a QAPI event for this case as well.

At this moment, there is no "CPU_UNPLUG_ERROR" in QAPI (guess ACPI doesn't
need it). Before sending patches to implement this new event I had a talk
with David Gibson and he suggested that, instead of adding a new CPU_UNPLUG_ERROR
event, we could add a generic event (e.g. DEVICE_UNPLUG_ERROR) that can be
used by the pseries machine in both error scenarios (MEM and CPU).

This could also be used by x86 as well, although I believe the use of
MEM_UNPLUG_ERROR would need to be kept for awhile to avoid breaking ABI.


Any suggestions/comments?



Thanks,


DHB


             reply	other threads:[~2021-03-05 18:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-05 18:16 Daniel Henrique Barboza [this message]
2021-03-06  6:57 ` [RFC] adding a generic QAPI event for failed device hotunplug Markus Armbruster
2021-03-08 14:22   ` Daniel Henrique Barboza
2021-03-08 17:04     ` Markus Armbruster
2021-03-08 18:01       ` Daniel Henrique Barboza
2021-03-09  3:22         ` David Gibson
2021-03-09  6:22           ` Markus Armbruster
2021-03-11 20:50             ` Daniel Henrique Barboza
2021-03-12  1:19               ` David Gibson
2021-03-12  8:12                 ` Markus Armbruster
2021-03-19  7:55                   ` Markus Armbruster
2021-03-22  6:39                   ` David Gibson
2021-03-22 12:06                     ` Paolo Bonzini
2021-03-23  3:33                       ` David Gibson
2021-03-23 13:06                         ` Igor Mammedov
2021-03-29  5:35                           ` David Gibson
2021-03-29  9:38                             ` Paolo Bonzini
2021-03-12 13:38                 ` Laine Stump
2021-03-22  6:43                   ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=155911cc-8764-1a65-4bb3-2fc0628d52e5@gmail.com \
    --to=danielhb413@gmail.com \
    --cc=armbru@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=michael.roth@amd.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).