From: Alistair Francis <alistair@alistair23.me>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [Bug 1832535] Re: [riscv/regression] Missing tlb flush introduced in refactoring
Date: Wed, 19 Jun 2019 00:52:54 -0000 [thread overview]
Message-ID: <156090557500.21587.14659841562107909557.malone@gac.canonical.com> (raw)
In-Reply-To: 156034277180.16851.16263953909128956213.malonedeb@soybean.canonical.com
Hello,
Thanks for reporting a bug.
Can you please include details to reproduce the problems that you are
seeing? This includes images and command line arguments.
Do you also mind including the diff of what fixes the problem for you?
Alistair
** Changed in: qemu
Status: New => Incomplete
** Changed in: qemu
Assignee: (unassigned) => Alistair Francis (alistair2323)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1832535
Title:
[riscv/regression] Missing tlb flush introduced in refactoring
Status in QEMU:
Incomplete
Bug description:
Hello,
In qemu-system-riscv64, following a QEMU update, I get all sort of
weird and not easily reproducible crashes in my risc-v guest.
I have bissected this issue to commit c7b951718815694284501ed01fec7acb8654db7b.
Some TLB flushes were removed in the following places:
target/riscv/cpu_helper.c: `csr_write_helper(env, s, CSR_MSTATUS);` -> `env->mstatus = s;` (twice)
target/riscv/op_helper.c: `csr_write_helper(env, s, CSR_MSTATUS);` -> `env->mstatus = s;` (twice)
Adding TLB flushes in all 4 places fixes the issues for me.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1832535/+subscriptions
next prev parent reply other threads:[~2019-06-19 1:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 12:32 [Qemu-devel] [Bug 1832535] [NEW] [riscv/regression] Missing tlb flush introduced in refactoring QEMU
2019-06-19 0:52 ` Alistair Francis [this message]
2019-06-20 13:22 ` [Qemu-devel] [Bug 1832535] " QEMU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156090557500.21587.14659841562107909557.malone@gac.canonical.com \
--to=alistair@alistair23.me \
--cc=1832535@bugs.launchpad.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).