From: no-reply@patchew.org
To: kpouget@redhat.com
Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC] spice-core: allow setting properties from QMP
Date: Wed, 19 Jun 2019 05:39:25 -0700 (PDT) [thread overview]
Message-ID: <156094796445.27226.1027934106005620089@ce79690b2cb9> (raw)
In-Reply-To: <20190619123042.4822-1-kpouget@redhat.com>
Patchew URL: https://patchew.org/QEMU/20190619123042.4822-1-kpouget@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [RFC] spice-core: allow setting properties from QMP
Type: series
Message-id: 20190619123042.4822-1-kpouget@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
* [new tag] patchew/20190619123042.4822-1-kpouget@redhat.com -> patchew/20190619123042.4822-1-kpouget@redhat.com
Switched to a new branch 'test'
51809fd99d spice-core: allow setting properties from QMP
=== OUTPUT BEGIN ===
ERROR: open brace '{' following function declarations go on the next line
#61: FILE: ui/spice-core.c:506:
+void qmp_set_spice(const char *property, const char *value, Error **errp) {
ERROR: Error messages should not contain newlines
#67: FILE: ui/spice-core.c:512:
+ "the property %s=%s\n", invalid_codecs, property, value);
WARNING: line over 80 characters
#70: FILE: ui/spice-core.c:515:
+ error_setg(errp, "Setting an unknown spice property (%s=%s)\n", property, value);
ERROR: Error messages should not contain newlines
#70: FILE: ui/spice-core.c:515:
+ error_setg(errp, "Setting an unknown spice property (%s=%s)\n", property, value);
ERROR: Missing Signed-off-by: line(s)
total: 4 errors, 1 warnings, 44 lines checked
Commit 51809fd99d76 (spice-core: allow setting properties from QMP) has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190619123042.4822-1-kpouget@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
next prev parent reply other threads:[~2019-06-19 12:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 12:30 [Qemu-devel] [RFC] spice-core: allow setting properties from QMP Kevin Pouget
2019-06-19 12:39 ` no-reply [this message]
2019-06-19 15:19 ` Eric Blake
2019-06-20 11:54 ` Kevin Pouget
2019-06-21 7:16 ` Frediano Ziglio
2019-06-21 7:56 ` Kevin Pouget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156094796445.27226.1027934106005620089@ce79690b2cb9 \
--to=no-reply@patchew.org \
--cc=kpouget@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).