Re: [Qemu-devel] [PATCH v12 0/5]

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/1560953834-29584-1-git-send-email-aleksandar.markovic@rt-rk.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v12 0/5]
Type: series
Message-id: 1560953834-29584-1-git-send-email-aleksandar.markovic@rt-rk.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]               patchew/1560953834-29584-1-git-send-email-aleksandar.markovic@rt-rk.com -> patchew/1560953834-29584-1-git-send-email-aleksandar.markovic@rt-rk.com
Switched to a new branch 'test'
da94588f68 linux-user: Fix flock structure for MIPS O64 ABI
61a9980aca linux-user: Add support for strace for statx() syscall
5058c9cfc7 linux-user: Add support for translation of statx() syscall
7b71d1b65a linux-user: Add support for setsockopt() option SOL_ALG
174903e7a9 linux-user: Add support for setsockopt() options IPV6_<ADD|DROP>_MEMBERSHIP

=== OUTPUT BEGIN ===
1/5 Checking commit 174903e7a97c (linux-user: Add support for setsockopt() options IPV6_<ADD|DROP>_MEMBERSHIP)
2/5 Checking commit 7b71d1b65a34 (linux-user: Add support for setsockopt() option SOL_ALG)
3/5 Checking commit 5058c9cfc7de (linux-user: Add support for translation of statx() syscall)
WARNING: architecture specific defines should be avoided
#60: FILE: linux-user/syscall.c:323:
+#if defined(TARGET_NR_statx) && defined(__NR_statx)

WARNING: architecture specific defines should be avoided
#72: FILE: linux-user/syscall.c:6529:
+#if defined(TARGET_NR_statx) && defined(__NR_statx)

WARNING: architecture specific defines should be avoided
#142: FILE: linux-user/syscall.c:10239:
+#if defined(__NR_statx)

total: 0 errors, 3 warnings, 207 lines checked

Patch 3/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/5 Checking commit 61a9980acaf8 (linux-user: Add support for strace for statx() syscall)
ERROR: storage class should be at the beginning of the declaration
#27: FILE: linux-user/strace.c:979:
+UNUSED static struct flags statx_flags[] = {

ERROR: storage class should be at the beginning of the declaration
#49: FILE: linux-user/strace.c:1001:
+UNUSED static struct flags statx_mask[] = {

total: 2 errors, 0 warnings, 104 lines checked

Patch 4/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/5 Checking commit da94588f687d (linux-user: Fix flock structure for MIPS O64 ABI)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1560953834-29584-1-git-send-email-aleksandar.markovic@rt-rk.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com