From: Shivaprasad G Bhat <sbhat@linux.ibm.com>
To: qemu-ppc@nongnu.org, david@gibson.dropbear.id.au
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 2/4] ppc: fix memory leak in spapr_dt_drc()
Date: Wed, 17 Jul 2019 03:20:01 -0500 [thread overview]
Message-ID: <156335159028.82682.5404622104535818162.stgit@lep8c.aus.stglabs.ibm.com> (raw)
In-Reply-To: <156335150620.82682.9535735857478533420.stgit@lep8c.aus.stglabs.ibm.com>
Leaking the drc_name while preparing the DT properties.
Fixing that.
Also, remove the const qualifier from spapr_drc_name().
Signed-off-by: Shivaprasad G Bhat <sbhat@linux.ibm.com>
---
hw/ppc/spapr_drc.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
index bacadfcac5..695a0b2285 100644
--- a/hw/ppc/spapr_drc.c
+++ b/hw/ppc/spapr_drc.c
@@ -226,7 +226,7 @@ static uint32_t drc_set_unusable(SpaprDrc *drc)
return RTAS_OUT_SUCCESS;
}
-static const char *spapr_drc_name(SpaprDrc *drc)
+static char *spapr_drc_name(SpaprDrc *drc)
{
SpaprDrcClass *drck = SPAPR_DR_CONNECTOR_GET_CLASS(drc);
@@ -827,6 +827,7 @@ int spapr_dt_drc(void *fdt, int offset, Object *owner, uint32_t drc_type_mask)
Object *obj;
SpaprDrc *drc;
SpaprDrcClass *drck;
+ char *drc_name = NULL;
uint32_t drc_index, drc_power_domain;
if (!strstart(prop->type, "link<", NULL)) {
@@ -856,8 +857,10 @@ int spapr_dt_drc(void *fdt, int offset, Object *owner, uint32_t drc_type_mask)
g_array_append_val(drc_power_domains, drc_power_domain);
/* ibm,drc-names */
- drc_names = g_string_append(drc_names, spapr_drc_name(drc));
+ drc_name = spapr_drc_name(drc);
+ drc_names = g_string_append(drc_names, drc_name);
drc_names = g_string_insert_len(drc_names, -1, "\0", 1);
+ g_free(drc_name);
/* ibm,drc-types */
drc_types = g_string_append(drc_types, drck->typename);
next prev parent reply other threads:[~2019-07-17 8:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 8:19 [Qemu-devel] [PATCH v2 0/4] ppc: Fix some memory leaks Shivaprasad G Bhat
2019-07-17 8:19 ` [Qemu-devel] [PATCH v2 1/4] ppc: fix memory leak in spapr_caps_add_properties Shivaprasad G Bhat
2019-07-17 10:41 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2019-07-18 4:19 ` [Qemu-devel] " David Gibson
2019-07-17 8:20 ` Shivaprasad G Bhat [this message]
2019-07-17 10:47 ` [Qemu-devel] [Qemu-ppc] [PATCH v2 2/4] ppc: fix memory leak in spapr_dt_drc() Greg Kurz
2019-07-18 4:20 ` [Qemu-devel] " David Gibson
2019-07-17 8:20 ` [Qemu-devel] [PATCH v2 3/4] ppc: fix leak in h_client_architecture_support Shivaprasad G Bhat
2019-07-17 10:47 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2019-07-18 4:21 ` [Qemu-devel] " David Gibson
2019-07-17 8:20 ` [Qemu-devel] [PATCH v2 4/4] ppc: dont overwrite initialized idle_timer Shivaprasad G Bhat
2019-07-17 14:58 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156335159028.82682.5404622104535818162.stgit@lep8c.aus.stglabs.ibm.com \
--to=sbhat@linux.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).