From: Paolo Bonzini <pbonzini@redhat.com>
To: David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Claudio Fontana" <cfontana@suse.de>,
"Igor Mammedov" <imammedo@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Stefan Berger" <stefanb@linux.ibm.com>
Subject: Re: [PATCH v4 0/4] softmmu/memory_mapping: optimize dump/tpm for virtio-mem
Date: Sat, 2 Oct 2021 11:55:14 +0200 [thread overview]
Message-ID: <15636272-1702-93c7-2c7d-59d889168350@redhat.com> (raw)
In-Reply-To: <20210727082545.17934-1-david@redhat.com>
On 27/07/21 10:25, David Hildenbrand wrote:
> Minor fixes and cleanups, followed by an optimization for virtio-mem
> regarding guest dumps and tpm.
>
> virtio-mem logically plugs/unplugs memory within a sparse memory region
> and notifies via the RamDiscardMgr interface when parts become
> plugged (populated) or unplugged (discarded).
>
> Currently, guest_phys_blocks_append() appends the whole (sparse)
> virtio-mem managed region and therefore tpm code might zero the hole
> region and dump code will dump the whole region. Let's only add logically
> plugged (populated) parts of that region, skipping over logically
> unplugged (discarded) parts by reusing the RamDiscardMgr infrastructure
> introduced to handle virtio-mem + VFIO properly.
Queued, thanks.
Paolo
> v3 -> v4:
> - "tpm: mark correct memory region range dirty when clearing RAM"
> -- Finally get it right :) I tried triggering that code without luck. So
> I ended up forcing that call path, verifying that the offset into
> memory regions is now correct.
>
> v2 -> v3:
> - "tpm: mark correct memory region range dirty when clearing RAM"
> -- Fix calculation of offset into memory region (thanks Peter!)
> - "softmmu/memory_mapping: reuse qemu_get_guest_simple_memory_mapping()"
> -- Dropped
>
> v1 -> v2:
> - "softmmu/memory_mapping: factor out adding physical memory ranges"
> -- Simplify based on RamDiscardManager changes: add using a
> MemoryRegionSection
> - "softmmu/memory_mapping: optimize for RamDiscardManager sections"
> -- Simplify based on RamDiscardManager changes
>
> David Hildenbrand (4):
> tpm: mark correct memory region range dirty when clearing RAM
> softmmu/memory_mapping: never merge ranges accross memory regions
> softmmu/memory_mapping: factor out adding physical memory ranges
> softmmu/memory_mapping: optimize for RamDiscardManager sections
>
> hw/tpm/tpm_ppi.c | 5 +++-
> softmmu/memory_mapping.c | 64 ++++++++++++++++++++++++++--------------
> 2 files changed, 46 insertions(+), 23 deletions(-)
>
next prev parent reply other threads:[~2021-10-02 9:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 8:25 [PATCH v4 0/4] softmmu/memory_mapping: optimize dump/tpm for virtio-mem David Hildenbrand
2021-07-27 8:25 ` [PATCH v4 1/4] tpm: mark correct memory region range dirty when clearing RAM David Hildenbrand
2021-07-27 15:46 ` Peter Xu
2021-07-27 8:25 ` [PATCH v4 2/4] softmmu/memory_mapping: never merge ranges accross memory regions David Hildenbrand
2021-07-27 8:25 ` [PATCH v4 3/4] softmmu/memory_mapping: factor out adding physical memory ranges David Hildenbrand
2021-07-27 8:25 ` [PATCH v4 4/4] softmmu/memory_mapping: optimize for RamDiscardManager sections David Hildenbrand
2021-10-02 9:55 ` Paolo Bonzini [this message]
2021-10-04 7:39 ` [PATCH v4 0/4] softmmu/memory_mapping: optimize dump/tpm for virtio-mem David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15636272-1702-93c7-2c7d-59d889168350@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=alex.williamson@redhat.com \
--cc=cfontana@suse.de \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).