Re: [Qemu-devel] [PULL 00/36] QEMU patches for 2018-08-20

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/1566284395-30287-1-git-send-email-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PULL 00/36] QEMU patches for 2018-08-20
Message-id: 1566284395-30287-1-git-send-email-pbonzini@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1566284395-30287-1-git-send-email-pbonzini@redhat.com -> patchew/1566284395-30287-1-git-send-email-pbonzini@redhat.com
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/edk2' (https://git.qemu.org/git/edk2.git) registered for path 'roms/edk2'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/opensbi' (https://git.qemu.org/git/opensbi.git) registered for path 'roms/opensbi'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://git.qemu.org/git/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'slirp' (https://git.qemu.org/git/libslirp.git) registered for path 'slirp'
Submodule 'tests/fp/berkeley-softfloat-3' (https://git.qemu.org/git/berkeley-softfloat-3.git) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://git.qemu.org/git/berkeley-testfloat-3.git) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 'ba1ab360eebe6338bb8d7d83a9220ccf7e213af3'
Cloning into 'roms/edk2'...
Submodule path 'roms/edk2': checked out '20d2e5a125e34fc8501026613a71549b2a1a3e54'
Submodule 'SoftFloat' (https://github.com/ucb-bar/berkeley-softfloat-3.git) registered for path 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3'
Submodule 'CryptoPkg/Library/OpensslLib/openssl' (https://github.com/openssl/openssl) registered for path 'CryptoPkg/Library/OpensslLib/openssl'
Cloning into 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3'...
Submodule path 'roms/edk2/ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'CryptoPkg/Library/OpensslLib/openssl'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl': checked out '50eaac9f3337667259de725451f201e784599687'
Submodule 'boringssl' (https://boringssl.googlesource.com/boringssl) registered for path 'boringssl'
Submodule 'krb5' (https://github.com/krb5/krb5) registered for path 'krb5'
Submodule 'pyca.cryptography' (https://github.com/pyca/cryptography.git) registered for path 'pyca-cryptography'
Cloning into 'boringssl'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/boringssl': checked out '2070f8ad9151dc8f3a73bffaa146b5e6937a583f'
Cloning into 'krb5'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/krb5': checked out 'b9ad6c49505c96a088326b62a52568e3484f2168'
Cloning into 'pyca-cryptography'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/pyca-cryptography': checked out '09403100de2f6f1cdd0d484dcb8e620f1c335c8f'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out 'c79e0ecb84f4f1ee3f73f521622e264edd1bf174'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/opensbi'...
Submodule path 'roms/opensbi': checked out 'ce228ee0919deb9957192d723eecc8aaae2697c6'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out 'bf0e13698872450164fa7040da36a95d2d4b326f'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a5cab58e9a3fb6e168aba919c5669bea406573b4'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '0f4fe84658165e96ce35870fd19fc634e182e77b'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out '261ca8e779e5138869a45f174caa49be6a274501'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd3689267f92c5956e09cc7d1baa4700141662bff'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'slirp'...
Submodule path 'slirp': checked out '126c04acbabd7ad32c2b018fe10dfac2a3bc1210'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
4b3b98e x86: Intel AVX512_BF16 feature enabling
49cf949 scsi: lsi: exit infinite loop while executing script (CVE-2019-12068)
28f466a test-bitmap: test set 1 bit case for bitmap_set
b5ae146 migration: do not rom_reset() during incoming migration
810eb3b HACKING: Document 'struct' keyword usage
f0b1664 kvm: vmxcap: Enhance with latest features
5ec49f7 cpus-common: assert BQL nesting within cpu-exclusive sections
5887e64 cpus-common: nuke finish_safe_work
ba02024 icount: remove unnecessary gen_io_end calls
7090243 icount: clean up cpu_can_io at the entry to the block
455f9c1 replay: rename step-related variables and functions
f279de7 replay: refine replay-time module
c051b41 replay: fix replay shutdown
bf310b1 util/qemu-timer: refactor deadline calculation for external timers
6bffd44 replay: document development rules
5a4417d replay: add missing fix for internal function
ab5d0a9 kconfig: do not select VMMOUSE
7f8a5ee timer: last, remove last bits of last
89d81e5 replay: Remove host_clock_last
9ede085 timer: Remove reset notifiers
9a6a12f mc146818rtc: Remove reset notifiers
3a47d60 memory: fix race between TCG and accesses to dirty bitmap
aefebb9 target/i386: Return 'indefinite integer value' for invalid SSE fp->int conversions
2f10f92 i386/kvm: initialize struct at full before ioctl call
1e45f05 tests: Fix uninitialized byte in test_visitor_in_fuzz
6af6152 test-throttle: Fix uninitialized use of burst_length
68c0617 target-i386: kvm: 'kvm_get_supported_msrs' cleanup
5acd668 9p: simplify source file selection
ad1d30f configure: Define target access alignment in configure
35467e3 memory: assert on out of scope notification
5913693 hw/i386/pc: Map into memory the initrd
ff22b21 elf-ops.h: Map into memory the ELF to load
b6a6457 loader: Handle memory-mapped ELFs
ff1bf69 target-i386: adds PV_SCHED_YIELD CPUID feature bit
866b9b0 kvm: i386: halt poll control MSR support

=== OUTPUT BEGIN ===
1/35 Checking commit 866b9b0b2c9d (kvm: i386: halt poll control MSR support)
2/35 Checking commit ff1bf69bc8b9 (target-i386: adds PV_SCHED_YIELD CPUID feature bit)
3/35 Checking commit b6a64576d120 (loader: Handle memory-mapped ELFs)
4/35 Checking commit ff22b21d41c9 (elf-ops.h: Map into memory the ELF to load)
WARNING: Block comments use a leading /* on a separate line
#85: FILE: include/hw/elf_ops.h:529:
+            /* Some ELF files really do have segments of zero size;

total: 0 errors, 1 warnings, 128 lines checked

Patch 4/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/35 Checking commit 5913693ff255 (hw/i386/pc: Map into memory the initrd)
6/35 Checking commit 35467e34932a (memory: assert on out of scope notification)
7/35 Checking commit ad1d30fa710d (configure: Define target access alignment in configure)
8/35 Checking commit 5acd6682980b (9p: simplify source file selection)
9/35 Checking commit 68c0617afd28 (target-i386: kvm: 'kvm_get_supported_msrs' cleanup)
10/35 Checking commit 6af61523d934 (test-throttle: Fix uninitialized use of burst_length)
11/35 Checking commit 1e45f05d0703 (tests: Fix uninitialized byte in test_visitor_in_fuzz)
12/35 Checking commit 2f10f92d6a60 (i386/kvm: initialize struct at full before ioctl call)
13/35 Checking commit aefebb923eea (target/i386: Return 'indefinite integer value' for invalid SSE fp->int conversions)
ERROR: spaces required around that '*' (ctx:WxV)
#46: FILE: target/i386/ops_sse.h:720:
+    static inline RETTYPE x86_##FN(FLOATTYPE a, float_status *s)        \
                                                              ^

WARNING: line over 80 characters
#141: FILE: target/i386/ops_sse.h:797:
+    d->ZMM_L(0) = x86_float32_to_int32_round_to_zero(s->ZMM_S(0), &env->sse_status);

WARNING: line over 80 characters
#142: FILE: target/i386/ops_sse.h:798:
+    d->ZMM_L(1) = x86_float32_to_int32_round_to_zero(s->ZMM_S(1), &env->sse_status);

WARNING: line over 80 characters
#143: FILE: target/i386/ops_sse.h:799:
+    d->ZMM_L(2) = x86_float32_to_int32_round_to_zero(s->ZMM_S(2), &env->sse_status);

WARNING: line over 80 characters
#144: FILE: target/i386/ops_sse.h:800:
+    d->ZMM_L(3) = x86_float32_to_int32_round_to_zero(s->ZMM_S(3), &env->sse_status);

WARNING: line over 80 characters
#151: FILE: target/i386/ops_sse.h:805:
+    d->ZMM_L(0) = x86_float64_to_int32_round_to_zero(s->ZMM_D(0), &env->sse_status);

WARNING: line over 80 characters
#152: FILE: target/i386/ops_sse.h:806:
+    d->ZMM_L(1) = x86_float64_to_int32_round_to_zero(s->ZMM_D(1), &env->sse_status);

WARNING: line over 80 characters
#160: FILE: target/i386/ops_sse.h:812:
+    d->MMX_L(0) = x86_float32_to_int32_round_to_zero(s->ZMM_S(0), &env->sse_status);

WARNING: line over 80 characters
#161: FILE: target/i386/ops_sse.h:813:
+    d->MMX_L(1) = x86_float32_to_int32_round_to_zero(s->ZMM_S(1), &env->sse_status);

WARNING: line over 80 characters
#168: FILE: target/i386/ops_sse.h:818:
+    d->MMX_L(0) = x86_float64_to_int32_round_to_zero(s->ZMM_D(0), &env->sse_status);

WARNING: line over 80 characters
#169: FILE: target/i386/ops_sse.h:819:
+    d->MMX_L(1) = x86_float64_to_int32_round_to_zero(s->ZMM_D(1), &env->sse_status);

total: 1 errors, 10 warnings, 162 lines checked

Patch 13/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

14/35 Checking commit 3a47d606e090 (memory: fix race between TCG and accesses to dirty bitmap)
WARNING: line over 80 characters
#49: FILE: exec.c:909:
+        newas->tcg_as_listener.log_global_after_sync = tcg_log_global_after_sync;

WARNING: Block comments use a leading /* on a separate line
#65: FILE: exec.c:3155:
+    /* Wait for the CPU to end the current TB.  This avoids the following

WARNING: line over 80 characters
#131: FILE: memory.c:2133:
+    snapshot = cpu_physical_memory_snapshot_and_clear_dirty(mr, addr, size, client);

total: 0 errors, 3 warnings, 104 lines checked

Patch 14/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/35 Checking commit 9a6a12f4f07f (mc146818rtc: Remove reset notifiers)
16/35 Checking commit 9ede0850dcee (timer: Remove reset notifiers)
17/35 Checking commit 89d81e5838d1 (replay: Remove host_clock_last)
18/35 Checking commit 7f8a5ee5bb59 (timer: last, remove last bits of last)
19/35 Checking commit ab5d0a99df0e (kconfig: do not select VMMOUSE)
20/35 Checking commit 5a4417d17998 (replay: add missing fix for internal function)
21/35 Checking commit 6bffd44ac48e (replay: document development rules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 46 lines checked

Patch 21/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/35 Checking commit bf310b1e3286 (util/qemu-timer: refactor deadline calculation for external timers)
23/35 Checking commit c051b4186e05 (replay: fix replay shutdown)
24/35 Checking commit f279de73e091 (replay: refine replay-time module)
25/35 Checking commit 455f9c1bb327 (replay: rename step-related variables and functions)
26/35 Checking commit 70902434ca0b (icount: clean up cpu_can_io at the entry to the block)
27/35 Checking commit ba02024681a4 (icount: remove unnecessary gen_io_end calls)
28/35 Checking commit 5887e64f22b3 (cpus-common: nuke finish_safe_work)
29/35 Checking commit 5ec49f74b713 (cpus-common: assert BQL nesting within cpu-exclusive sections)
30/35 Checking commit f0b166449809 (kvm: vmxcap: Enhance with latest features)
31/35 Checking commit 810eb3b2376b (HACKING: Document 'struct' keyword usage)
32/35 Checking commit b5ae1460501f (migration: do not rom_reset() during incoming migration)
33/35 Checking commit 28f466a77a16 (test-bitmap: test set 1 bit case for bitmap_set)
34/35 Checking commit 49cf949845b9 (scsi: lsi: exit infinite loop while executing script (CVE-2019-12068))
WARNING: Block comments use a leading /* on a separate line
#39: FILE: hw/scsi/lsi53c895a.c:1140:
+        /* Some windows drivers make the device spin waiting for a memory

WARNING: Block comments use * on subsequent lines
#40: FILE: hw/scsi/lsi53c895a.c:1141:
+        /* Some windows drivers make the device spin waiting for a memory
+           location to change.  If we have been executed a lot of code then

total: 0 errors, 2 warnings, 71 lines checked

Patch 34/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
35/35 Checking commit 4b3b98eade19 (x86: Intel AVX512_BF16 feature enabling)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1566284395-30287-1-git-send-email-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com