From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Bishara AbuHattoum <bishara@daynix.com>, qemu-devel@nongnu.org
Cc: Yan Vugenfirer <yan@daynix.com>, Basil Salman <basil@daynix.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] qga-win: network-get-interfaces command name field bug fix
Date: Thu, 12 Sep 2019 18:35:02 -0500 [thread overview]
Message-ID: <156833130242.26182.17002244700908394194@sif> (raw)
In-Reply-To: <20190819131620.1302-2-bishara@daynix.com>
Quoting Bishara AbuHattoum (2019-08-19 08:16:20)
> Network interface name is fetched as an encoded WCHAR array, (wide
> character), then it is decoded using the guest's CP_ACP Windows code
> page, which is the default code page as configure in the guest's
> Windows, then it is returned as a byte array, (char array).
>
> As stated in the BZ#1733165, when renaming a network interface to a
> Chinese name and invoking this command, the returned name field has
> the (\ufffd) value for each Chinese character the name had, this
> value is an indication that the code page does not have the decoding
> information for the given character.
>
> This bug is a result of using the CP_ACP code page for decoding which
> is an interchangeable code page, instead CP_UTF8 code page should be
> used for decoding the network interface's name.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1733165
>
> Signed-off-by: Bishara AbuHattoum <bishara@daynix.com>
Thanks, applied to qga tree:
https://github.com/mdroth/qemu/commits/qga
> ---
> qga/commands-win32.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/qga/commands-win32.c b/qga/commands-win32.c
> index 6b67f16faf..64b1c754b0 100644
> --- a/qga/commands-win32.c
> +++ b/qga/commands-win32.c
> @@ -1387,12 +1387,12 @@ static IP_ADAPTER_ADDRESSES *guest_get_adapters_addresses(Error **errp)
> static char *guest_wctomb_dup(WCHAR *wstr)
> {
> char *str;
> - size_t i;
> + size_t str_size;
>
> - i = wcslen(wstr) + 1;
> - str = g_malloc(i);
> - WideCharToMultiByte(CP_ACP, WC_COMPOSITECHECK,
> - wstr, -1, str, i, NULL, NULL);
> + str_size = WideCharToMultiByte(CP_UTF8, 0, wstr, -1, NULL, 0, NULL, NULL);
> + /* add 1 to str_size for NULL terminator */
> + str = g_malloc(str_size + 1);
> + WideCharToMultiByte(CP_UTF8, 0, wstr, -1, str, str_size, NULL, NULL);
> return str;
> }
>
> --
> 2.17.2
>
next prev parent reply other threads:[~2019-09-13 22:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 13:16 [Qemu-devel] [PATCH 0/1] BZ#1733165: network-get-interfaces Chinese NIC name Bishara AbuHattoum
2019-08-19 13:16 ` [Qemu-devel] [PATCH 1/1] qga-win: network-get-interfaces command name field bug fix Bishara AbuHattoum
2019-09-03 8:42 ` Bishara AbuHattoum
2019-09-12 23:35 ` Michael Roth [this message]
2019-09-03 8:42 ` [Qemu-devel] [PATCH 0/1] BZ#1733165: network-get-interfaces Chinese NIC name Bishara AbuHattoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156833130242.26182.17002244700908394194@sif \
--to=mdroth@linux.vnet.ibm.com \
--cc=basil@daynix.com \
--cc=bishara@daynix.com \
--cc=qemu-devel@nongnu.org \
--cc=yan@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).