QEMU-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: no-reply@patchew.org
To: armbru@redhat.com
Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org,
	mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v3 00/16] qapi: Schema language cleanups & doc improvements
Date: Fri, 13 Sep 2019 19:49:36 -0700 (PDT)
Message-ID: <156842937572.31080.2162917881478968917@5dec9699b7de> (raw)
In-Reply-To: <20190913201349.24332-1-armbru@redhat.com>

Patchew URL: https://patchew.org/QEMU/20190913201349.24332-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v3 00/16] qapi: Schema language cleanups & doc improvements
Message-id: 20190913201349.24332-1-armbru@redhat.com
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
9491787 qapi: Tweak code to match docs/devel/qapi-code-gen.txt
6fb4a27 docs/devel/qapi-code-gen: Improve QAPI schema language doc
a474494 docs/devel/qapi-code-gen: Rewrite introduction to schema
6640272 docs/devel/qapi-code-gen: Rewrite compatibility considerations
d3cec78 docs/devel/qapi-code-gen: Reorder sections for readability
b48aba3 qapi: Adjust frontend errors to say enum value, not member
70ce619 qapi: Permit omitting all flat union branches
4ecd688 qapi: Permit alternates with just one branch
6fb8f9e qapi: Permit 'boxed' with empty type
c5e9097 qapi: Drop support for escape sequences other than \\
113836f qapi: Restrict strings to printable ASCII
fe760f3 tests/qapi-schema: Demonstrate bad reporting of funny characters
776df7c docs/devel/qapi-code-gen: Minor specification fixes
181a438 qapi: Drop support for boxed alternate arguments
57f9740 qapi: Drop check_type()'s redundant parameter @allow_optional
7975c5d scripts/git.orderfile: Match QAPI schema more precisely

=== OUTPUT BEGIN ===
1/16 Checking commit 7975c5d69cca (scripts/git.orderfile: Match QAPI schema more precisely)
2/16 Checking commit 57f9740b5d6c (qapi: Drop check_type()'s redundant parameter @allow_optional)
3/16 Checking commit 181a4384e8b8 (qapi: Drop support for boxed alternate arguments)
4/16 Checking commit 776df7cd45c6 (docs/devel/qapi-code-gen: Minor specification fixes)
5/16 Checking commit fe760f39461c (tests/qapi-schema: Demonstrate bad reporting of funny characters)
6/16 Checking commit 113836f31dd5 (qapi: Restrict strings to printable ASCII)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#109: 
new file mode 100644

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#126: FILE: tests/qapi-schema/string-code-point-127.json:2:
+{ 'command': '⌦' }
               ^

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#152: FILE: tests/qapi-schema/string-code-point-31.json:2:
+{ 'command': '␟' }
               ^

total: 2 errors, 1 warnings, 76 lines checked

Patch 6/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/16 Checking commit c5e90975c8c5 (qapi: Drop support for escape sequences other than \\)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#74: 
deleted file mode 100644

total: 0 errors, 1 warnings, 53 lines checked

Patch 7/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/16 Checking commit 6fb8f9e7baa7 (qapi: Permit 'boxed' with empty type)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#130: 
deleted file mode 100644

total: 0 errors, 1 warnings, 129 lines checked

Patch 8/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/16 Checking commit 4ecd688cd6a1 (qapi: Permit alternates with just one branch)
10/16 Checking commit 70ce619cf6af (qapi: Permit omitting all flat union branches)
11/16 Checking commit b48aba3a338c (qapi: Adjust frontend errors to say enum value, not member)
12/16 Checking commit d3cec7869722 (docs/devel/qapi-code-gen: Reorder sections for readability)
13/16 Checking commit 66402729d139 (docs/devel/qapi-code-gen: Rewrite compatibility considerations)
14/16 Checking commit a474494a010b (docs/devel/qapi-code-gen: Rewrite introduction to schema)
15/16 Checking commit 6fb4a273e1f6 (docs/devel/qapi-code-gen: Improve QAPI schema language doc)
16/16 Checking commit 9491787d3689 (qapi: Tweak code to match docs/devel/qapi-code-gen.txt)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190913201349.24332-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

  parent reply index

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-13 20:13 Markus Armbruster
2019-09-13 20:13 ` [Qemu-devel] [PATCH v3 01/16] scripts/git.orderfile: Match QAPI schema more precisely Markus Armbruster
2019-09-13 20:13 ` [Qemu-devel] [PATCH v3 02/16] qapi: Drop check_type()'s redundant parameter @allow_optional Markus Armbruster
2019-09-13 20:13 ` [Qemu-devel] [PATCH v3 03/16] qapi: Drop support for boxed alternate arguments Markus Armbruster
2019-09-13 20:13 ` [Qemu-devel] [PATCH v3 04/16] docs/devel/qapi-code-gen: Minor specification fixes Markus Armbruster
2019-09-13 20:13 ` [Qemu-devel] [PATCH v3 05/16] tests/qapi-schema: Demonstrate bad reporting of funny characters Markus Armbruster
2019-09-13 20:13 ` [Qemu-devel] [PATCH v3 06/16] qapi: Restrict strings to printable ASCII Markus Armbruster
2019-09-13 20:13 ` [Qemu-devel] [PATCH v3 07/16] qapi: Drop support for escape sequences other than \\ Markus Armbruster
2019-09-17 16:18   ` Eric Blake
2019-09-13 20:13 ` [Qemu-devel] [PATCH v3 08/16] qapi: Permit 'boxed' with empty type Markus Armbruster
2019-09-13 20:13 ` [Qemu-devel] [PATCH v3 09/16] qapi: Permit alternates with just one branch Markus Armbruster
2019-09-13 20:13 ` [Qemu-devel] [PATCH v3 10/16] qapi: Permit omitting all flat union branches Markus Armbruster
2019-09-17 16:20   ` Eric Blake
2019-09-23 11:46     ` Markus Armbruster
2019-09-13 20:13 ` [Qemu-devel] [PATCH v3 11/16] qapi: Adjust frontend errors to say enum value, not member Markus Armbruster
2019-09-13 20:13 ` [Qemu-devel] [PATCH v3 12/16] docs/devel/qapi-code-gen: Reorder sections for readability Markus Armbruster
2019-09-13 20:13 ` [Qemu-devel] [PATCH v3 13/16] docs/devel/qapi-code-gen: Rewrite compatibility considerations Markus Armbruster
2019-09-17 16:22   ` Eric Blake
2019-09-13 20:13 ` [Qemu-devel] [PATCH v3 14/16] docs/devel/qapi-code-gen: Rewrite introduction to schema Markus Armbruster
2019-09-13 20:13 ` [Qemu-devel] [PATCH v3 15/16] docs/devel/qapi-code-gen: Improve QAPI schema language doc Markus Armbruster
2019-09-13 20:13 ` [Qemu-devel] [PATCH v3 16/16] qapi: Tweak code to match docs/devel/qapi-code-gen.txt Markus Armbruster
2019-09-14  2:49 ` no-reply [this message]
2019-09-17 16:31 ` [Qemu-devel] [PATCH v3 00/16] qapi: Schema language cleanups & doc improvements Eric Blake
2019-09-23 11:49   ` Markus Armbruster
2019-09-23 18:29 ` Markus Armbruster

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=156842937572.31080.2162917881478968917@5dec9699b7de \
    --to=no-reply@patchew.org \
    --cc=armbru@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

QEMU-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/qemu-devel/0 qemu-devel/git/0.git
	git clone --mirror https://lore.kernel.org/qemu-devel/1 qemu-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 qemu-devel qemu-devel/ https://lore.kernel.org/qemu-devel \
		qemu-devel@nongnu.org
	public-inbox-index qemu-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.nongnu.qemu-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git