qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: pbonzini@redhat.com
Cc: qemu-devel@nongnu.org
Subject: Re: [PULL 00/30] Misc patches for 2010-10-02
Date: Wed, 2 Oct 2019 11:29:05 -0700 (PDT)	[thread overview]
Message-ID: <157004094479.27524.4743050765316894832@8230166b0665> (raw)
In-Reply-To: <1570035113-56848-1-git-send-email-pbonzini@redhat.com>

Patchew URL: https://patchew.org/QEMU/1570035113-56848-1-git-send-email-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1570035113-56848-1-git-send-email-pbonzini@redhat.com
Subject: [PULL 00/30] Misc patches for 2010-10-02

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
ece968f accel/kvm: ensure ret always set
f809af7 tests/docker: only enable ubsan for test-clang
42bb4d8 win32: work around main-loop busy loop on socket/fd event
6dc6f67 tests: skip serial test on windows
81d8378 util: WSAEWOULDBLOCK on connect should map to EINPROGRESS
68a8749 Fix wrong behavior of cpu_memory_rw_debug() function in SMM
ba6a8cb memory: allow memory_region_register_iommu_notifier() to fail
31fb63b vfio: Turn the container error into an Error handle
9cb898e i386: Add CPUID bit for CLZERO and XSAVEERPTR
223539f docker: test-debug: disable LeakSanitizer
ddc831e lm32: do not leak memory on object_new/object_unref
7e7f903 cris: do not leak struct cris_disasm_data
71ddec4 mips: fix memory leaks in board initialization
0a4aae1 hppa: fix leak from g_strdup_printf
1681302 mcf5208: fix leak from qemu_allocate_irqs
975e236 microblaze: fix leak of fdevice tree blob
3b04059 ide: fix leak from qemu_allocate_irqs
ef7140c hw/isa: Introduce a CONFIG_ISA_SUPERIO switch for isa-superio.c
22144ad Makefile: Remove generated files when doing 'distclean'
b2315db replay: don't synchronize memory operations in replay mode
a8748fb qemu-pr-helper: fix crash in mpath_reconstruct_sense
62af60b target/i386/kvm: Silence warning from Valgrind about uninitialized bytes
354aebb target/i386: work around KVM_GET_MSRS bug for secondary execution controls
6dec780 target/i386: add VMX features
0aabf14 vmxcap: correct the name of the variables
79691b9 target/i386: add VMX definitions
31a4f80 target/i386: expand feature words to 64 bits
107c503 target/i386: introduce generic feature dependency mechanism
2444ee0 target/i386: handle filtered_features in a new function mark_unavailable_features
ebcabe7 tests/migration: Add a test for auto converge

=== OUTPUT BEGIN ===
1/30 Checking commit ebcabe7df2b9 (tests/migration: Add a test for auto converge)
2/30 Checking commit 2444ee0a386b (target/i386: handle filtered_features in a new function mark_unavailable_features)
ERROR: suspect code indent for conditional statements (4, 9)
#27: FILE: target/i386/cpu.c:3103:
+    for (w = 0; w < FEATURE_WORDS; w++) {
+         if (cpu->filtered_features[w]) {

ERROR: suspect code indent for conditional statements (9, 13)
#28: FILE: target/i386/cpu.c:3104:
+         if (cpu->filtered_features[w]) {
+             return true;

WARNING: line over 80 characters
#139: FILE: target/i386/cpu.c:5215:
+            mark_unavailable_features(cpu, FEAT_7_0_EBX, CPUID_7_0_EBX_INTEL_PT, prefix);

total: 2 errors, 1 warnings, 147 lines checked

Patch 2/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/30 Checking commit 107c50351a12 (target/i386: introduce generic feature dependency mechanism)
WARNING: line over 80 characters
#126: FILE: target/i386/cpu.c:5114:
+            uint32_t unavailable_features = env->features[d->to.index] & d->to.mask;

WARNING: line over 80 characters
#133: FILE: target/i386/cpu.c:5116:
+            /* Not an error unless the dependent feature was added explicitly.  */

ERROR: line over 90 characters
#135: FILE: target/i386/cpu.c:5118:
+                                      unavailable_features & env->user_features[d->to.index],

total: 1 errors, 2 warnings, 110 lines checked

Patch 3/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/30 Checking commit 31a4f805635b (target/i386: expand feature words to 64 bits)
WARNING: line over 80 characters
#153: FILE: target/i386/cpu.c:3442:
+    assert(bitnr < 32 || !(name && feature_word_info[w].type == CPUID_FEATURE_WORD));

WARNING: line over 80 characters
#209: FILE: target/i386/cpu.c:5117:
+            uint64_t unavailable_features = env->features[d->to.index] & d->to.mask;

total: 0 errors, 2 warnings, 235 lines checked

Patch 4/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/30 Checking commit 79691b91fef6 (target/i386: add VMX definitions)
6/30 Checking commit 0aabf142d06c (vmxcap: correct the name of the variables)
7/30 Checking commit 6dec78064317 (target/i386: add VMX features)
ERROR: line over 90 characters
#32: FILE: target/i386/cpu.c:1244:
+            "vmx-cr8-store-exit", "vmx-flexpriority", "vmx-vnmi-pending", "vmx-movdr-exit",

WARNING: line over 80 characters
#34: FILE: target/i386/cpu.c:1246:
+            "vmx-msr-bitmap", "vmx-monitor-exit", "vmx-pause-exit", "vmx-secondary-ctls",

WARNING: line over 80 characters
#45: FILE: target/i386/cpu.c:1257:
+            "vmx-apicv-x2apic", "vmx-vpid", "vmx-wbinvd-exit", "vmx-unrestricted-guest",

WARNING: line over 80 characters
#47: FILE: target/i386/cpu.c:1259:
+            "vmx-invpcid-exit", "vmx-vmfunc", "vmx-shadow-vmcs", "vmx-encls-exit",

WARNING: Block comments use a leading /* on a separate line
#84: FILE: target/i386/cpu.c:1296:
+            NULL, NULL /* vmx-exit-host-addr-space-size */, NULL, NULL,

ERROR: line over 90 characters
#103: FILE: target/i386/cpu.c:1315:
+            NULL, "vmx-entry-load-perf-global-ctrl", "vmx-entry-load-pat", "vmx-entry-load-efer",

WARNING: line over 80 characters
#145: FILE: target/i386/cpu.c:1357:
+                "vmx-invvpid-all-context", "vmx-invept-single-context-noglobals",

WARNING: line over 80 characters
#166: FILE: target/i386/cpu.c:1378:
+        /* Just to be safe - we don't support setting the MSEG version field.  */

WARNING: line over 80 characters
#216: FILE: target/i386/cpu.c:1441:
+        .from = { FEAT_VMX_PROCBASED_CTLS,  VMX_CPU_BASED_ACTIVATE_SECONDARY_CONTROLS },

WARNING: line over 80 characters
#245: FILE: target/i386/cpu.c:1470:
+        .to = { FEAT_VMX_SECONDARY_CTLS,    VMX_SECONDARY_EXEC_UNRESTRICTED_GUEST },

WARNING: Block comments use a leading /* on a separate line
#366: FILE: target/i386/kvm.c:2464:
+    /* If a feature bit is set, the control can be either set or clear.

ERROR: code indent should never use tabs
#427: FILE: target/i386/kvm.c:2525:
+^I     MSR_VMX_EPT_UC | MSR_VMX_EPT_WB : 0);$

WARNING: line over 80 characters
#438: FILE: target/i386/kvm.c:2536:
+                                         f[FEAT_VMX_EXIT_CTLS]) | fixed_vmx_exit);

total: 3 errors, 10 warnings, 448 lines checked

Patch 7/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

8/30 Checking commit 354aebbf3e19 (target/i386: work around KVM_GET_MSRS bug for secondary execution controls)
WARNING: line over 80 characters
#26: FILE: target/i386/kvm.c:483:
+        if (kvm_arch_get_supported_cpuid(s, 0xD, 1, R_ECX) & CPUID_XSAVE_XSAVES) {

WARNING: line over 80 characters
#32: FILE: target/i386/kvm.c:489:
+        if (kvm_arch_get_supported_cpuid(s, 7, 0, R_EBX) & CPUID_7_0_EBX_INVPCID) {

WARNING: line over 80 characters
#35: FILE: target/i386/kvm.c:492:
+        if (kvm_arch_get_supported_cpuid(s, 7, 0, R_EBX) & CPUID_7_0_EBX_RDSEED) {

WARNING: line over 80 characters
#38: FILE: target/i386/kvm.c:495:
+        if (kvm_arch_get_supported_cpuid(s, 0x80000001, 0, R_EDX) & CPUID_EXT2_RDTSCP) {

total: 0 errors, 4 warnings, 23 lines checked

Patch 8/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/30 Checking commit 62af60b3e536 (target/i386/kvm: Silence warning from Valgrind about uninitialized bytes)
10/30 Checking commit a8748fbecf3f (qemu-pr-helper: fix crash in mpath_reconstruct_sense)
11/30 Checking commit b2315db46b26 (replay: don't synchronize memory operations in replay mode)
12/30 Checking commit 22144ade9a59 (Makefile: Remove generated files when doing 'distclean')
13/30 Checking commit ef7140c5d5ab (hw/isa: Introduce a CONFIG_ISA_SUPERIO switch for isa-superio.c)
14/30 Checking commit 3b04059cc6e9 (ide: fix leak from qemu_allocate_irqs)
15/30 Checking commit 975e23643625 (microblaze: fix leak of fdevice tree blob)
16/30 Checking commit 1681302ceb65 (mcf5208: fix leak from qemu_allocate_irqs)
17/30 Checking commit 0a4aae1a68b7 (hppa: fix leak from g_strdup_printf)
18/30 Checking commit 71ddec44dba9 (mips: fix memory leaks in board initialization)
19/30 Checking commit 7e7f903148f1 (cris: do not leak struct cris_disasm_data)
ERROR: space prohibited between function name and open parenthesis '('
#23: FILE: disas/cris.c:1298:
+cris_parse_disassembler_options (struct cris_disasm_data *disdata,

ERROR: code indent should never use tabs
#24: FILE: disas/cris.c:1299:
+^I^I^I^I char *disassembler_options,$

ERROR: space prohibited between function name and open parenthesis '('
#39: FILE: disas/cris.c:1305:
+       || (strcmp (disassembler_options, "nocase") != 0));

ERROR: space prohibited between function name and open parenthesis '('
#55: FILE: disas/cris.c:2734:
+  cris_parse_disassembler_options (&disdata, info->disassembler_options,

ERROR: code indent should never use tabs
#56: FILE: disas/cris.c:2735:
+^I^I^I^I   cris_dis_v0_v10);$

ERROR: space prohibited between function name and open parenthesis '('
#69: FILE: disas/cris.c:2746:
+  cris_parse_disassembler_options (&disdata, info->disassembler_options,

ERROR: code indent should never use tabs
#70: FILE: disas/cris.c:2747:
+^I^I^I^I   cris_dis_v32);$

ERROR: space prohibited between function name and open parenthesis '('
#83: FILE: disas/cris.c:2761:
+  cris_parse_disassembler_options (&disdata, info->disassembler_options,

ERROR: code indent should never use tabs
#84: FILE: disas/cris.c:2762:
+^I^I^I^I   cris_dis_common_v10_v32);$

ERROR: space prohibited between function name and open parenthesis '('
#97: FILE: disas/cris.c:2774:
+  cris_parse_disassembler_options (&disdata, info->disassembler_options,

ERROR: code indent should never use tabs
#98: FILE: disas/cris.c:2775:
+^I^I^I^I   cris_dis_v0_v10);$

ERROR: space prohibited between function name and open parenthesis '('
#111: FILE: disas/cris.c:2787:
+  cris_parse_disassembler_options (&disdata, info->disassembler_options,

ERROR: code indent should never use tabs
#112: FILE: disas/cris.c:2788:
+^I^I^I^I   cris_dis_v32);$

ERROR: space prohibited between function name and open parenthesis '('
#125: FILE: disas/cris.c:2801:
+  cris_parse_disassembler_options (&disdata, info->disassembler_options,

ERROR: code indent should never use tabs
#126: FILE: disas/cris.c:2802:
+^I^I^I^I   cris_dis_common_v10_v32);$

total: 15 errors, 0 warnings, 107 lines checked

Patch 19/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/30 Checking commit ddc831e53ac1 (lm32: do not leak memory on object_new/object_unref)
21/30 Checking commit 223539fbc024 (docker: test-debug: disable LeakSanitizer)
22/30 Checking commit 9cb898e8c1c1 (i386: Add CPUID bit for CLZERO and XSAVEERPTR)
WARNING: line over 80 characters
#35: FILE: target/i386/cpu.h:726:
+#define CPUID_8000_0008_EBX_CLZERO             (1U << 0) /* CLZERO instruction */

ERROR: code indent should never use tabs
#35: FILE: target/i386/cpu.h:726:
+#define CPUID_8000_0008_EBX_CLZERO^I^I(1U << 0) /* CLZERO instruction */$

ERROR: line over 90 characters
#36: FILE: target/i386/cpu.h:727:
+#define CPUID_8000_0008_EBX_XSAVEERPTR (1U << 2) /* Always save/restore FP error pointers */

ERROR: code indent should never use tabs
#36: FILE: target/i386/cpu.h:727:
+#define CPUID_8000_0008_EBX_XSAVEERPTR^I(1U << 2) /* Always save/restore FP error pointers */$

total: 3 errors, 1 warnings, 16 lines checked

Patch 22/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

23/30 Checking commit 31fb63bad4e1 (vfio: Turn the container error into an Error handle)
24/30 Checking commit ba6a8cbc61f9 (memory: allow memory_region_register_iommu_notifier() to fail)
25/30 Checking commit 68a87498010f (Fix wrong behavior of cpu_memory_rw_debug() function in SMM)
26/30 Checking commit 81d837865a80 (util: WSAEWOULDBLOCK on connect should map to EINPROGRESS)
27/30 Checking commit 6dc6f6766496 (tests: skip serial test on windows)
28/30 Checking commit 42bb4d8c516b (win32: work around main-loop busy loop on socket/fd event)
29/30 Checking commit f809af7acc61 (tests/docker: only enable ubsan for test-clang)
30/30 Checking commit ece968fbb77f (accel/kvm: ensure ret always set)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1570035113-56848-1-git-send-email-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

  parent reply	other threads:[~2019-10-02 18:30 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-02 16:51 [PULL 00/30] Misc patches for 2010-10-02 Paolo Bonzini
2019-10-02 16:51 ` [PULL 01/30] tests/migration: Add a test for auto converge Paolo Bonzini
2019-10-02 16:51 ` [PULL 02/30] target/i386: handle filtered_features in a new function mark_unavailable_features Paolo Bonzini
2019-10-02 16:51 ` [PULL 03/30] target/i386: introduce generic feature dependency mechanism Paolo Bonzini
2019-10-02 16:51 ` [PULL 04/30] target/i386: expand feature words to 64 bits Paolo Bonzini
2019-10-02 16:51 ` [PULL 05/30] target/i386: add VMX definitions Paolo Bonzini
2019-10-02 16:51 ` [PULL 06/30] vmxcap: correct the name of the variables Paolo Bonzini
2019-10-02 16:51 ` [PULL 07/30] target/i386: add VMX features Paolo Bonzini
2019-10-02 16:51 ` [PULL 08/30] target/i386: work around KVM_GET_MSRS bug for secondary execution controls Paolo Bonzini
2019-10-02 16:51 ` [PULL 09/30] target/i386/kvm: Silence warning from Valgrind about uninitialized bytes Paolo Bonzini
2019-10-02 16:51 ` [PULL 10/30] qemu-pr-helper: fix crash in mpath_reconstruct_sense Paolo Bonzini
2019-10-02 16:51 ` [PULL 11/30] replay: don't synchronize memory operations in replay mode Paolo Bonzini
2019-10-02 16:51 ` [PULL 12/30] Makefile: Remove generated files when doing 'distclean' Paolo Bonzini
2019-10-04 12:20   ` Peter Maydell
2019-10-04 16:48     ` Paolo Bonzini
2019-10-07  6:28       ` Thomas Huth
2019-10-07  7:13         ` Aleksandar Markovic
2019-10-02 16:51 ` [PULL 13/30] hw/isa: Introduce a CONFIG_ISA_SUPERIO switch for isa-superio.c Paolo Bonzini
2019-10-02 16:51 ` [PULL 14/30] ide: fix leak from qemu_allocate_irqs Paolo Bonzini
2019-10-02 16:51 ` [PULL 15/30] microblaze: fix leak of fdevice tree blob Paolo Bonzini
2019-10-02 16:51 ` [PULL 16/30] mcf5208: fix leak from qemu_allocate_irqs Paolo Bonzini
2019-10-02 16:51 ` [PULL 17/30] hppa: fix leak from g_strdup_printf Paolo Bonzini
2019-10-02 16:51 ` [PULL 18/30] mips: fix memory leaks in board initialization Paolo Bonzini
2019-10-02 16:51 ` [PULL 19/30] cris: do not leak struct cris_disasm_data Paolo Bonzini
2019-10-02 16:51 ` [PULL 20/30] lm32: do not leak memory on object_new/object_unref Paolo Bonzini
2019-10-02 16:51 ` [PULL 21/30] docker: test-debug: disable LeakSanitizer Paolo Bonzini
2019-10-02 16:51 ` [PULL 22/30] i386: Add CPUID bit for CLZERO and XSAVEERPTR Paolo Bonzini
2019-10-02 16:51 ` [PULL 23/30] vfio: Turn the container error into an Error handle Paolo Bonzini
2019-10-02 16:51 ` [PULL 24/30] memory: allow memory_region_register_iommu_notifier() to fail Paolo Bonzini
2019-10-02 16:51 ` [PULL 25/30] Fix wrong behavior of cpu_memory_rw_debug() function in SMM Paolo Bonzini
2019-10-07  8:29   ` Laszlo Ersek
2019-10-02 16:51 ` [PULL 26/30] util: WSAEWOULDBLOCK on connect should map to EINPROGRESS Paolo Bonzini
2019-10-02 16:51 ` [PULL 27/30] tests: skip serial test on windows Paolo Bonzini
2019-10-02 16:51 ` [PULL 28/30] win32: work around main-loop busy loop on socket/fd event Paolo Bonzini
2019-10-02 16:51 ` [PULL 29/30] tests/docker: only enable ubsan for test-clang Paolo Bonzini
2019-10-02 16:51 ` [PULL 30/30] accel/kvm: ensure ret always set Paolo Bonzini
2019-10-02 18:29 ` no-reply [this message]
2019-10-03 10:59 [PULL 00/30] Misc patches for 2010-10-02 Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=157004094479.27524.4743050765316894832@8230166b0665 \
    --to=no-reply@patchew.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).