QEMU-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: no-reply@patchew.org
To: aleksandar.markovic@rt-rk.com
Cc: aleksandar.rikalo@rt-rk.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v3 0/6] target/mips: Misc cleanups for September/October 2019 
Date: Sat, 12 Oct 2019 11:13:30 -0700 (PDT)
Message-ID: <157090400982.19705.2876310576707631292@37313f22b938> (raw)
In-Reply-To: <1570901866-9548-1-git-send-email-aleksandar.markovic@rt-rk.com>

Patchew URL: https://patchew.org/QEMU/1570901866-9548-1-git-send-email-aleksandar.markovic@rt-rk.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v3 0/6] target/mips: Misc cleanups for September/October 2019 
Type: series
Message-id: 1570901866-9548-1-git-send-email-aleksandar.markovic@rt-rk.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
bb57bcb target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D>
d75ac24 target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D>
ccb136e target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D>
ca86289 MAINTAINERS: Update mail address of Aleksandar Rikalo
8c31deb target/mips: Clean up op_helper.c
61e19fa target/mips: Clean up helper.c

=== OUTPUT BEGIN ===
1/6 Checking commit 61e19fa130a4 (target/mips: Clean up helper.c)
2/6 Checking commit 8c31deb3c4d7 (target/mips: Clean up op_helper.c)
ERROR: spaces required around that '*' (ctx:WxV)
#1058: FILE: target/mips/op_helper.c:3871:
+                                  float_status *status)              \
                                                ^

total: 1 errors, 0 warnings, 1681 lines checked

Patch 2/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/6 Checking commit ca862897070f (MAINTAINERS: Update mail address of Aleksandar Rikalo)
4/6 Checking commit ccb136eabf82 (target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D>)
5/6 Checking commit d75ac249e00b (target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D>)
6/6 Checking commit bb57bcbf0b97 (target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D>)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1570901866-9548-1-git-send-email-aleksandar.markovic@rt-rk.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

      parent reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-12 17:37 Aleksandar Markovic
2019-10-12 17:37 ` [PATCH v3 1/6] target/mips: Clean up helper.c Aleksandar Markovic
2019-10-14  7:25   ` Markus Armbruster
2019-10-14  8:22     ` Aleksandar Markovic
2019-10-12 17:37 ` [PATCH v3 2/6] target/mips: Clean up op_helper.c Aleksandar Markovic
2019-10-12 17:37 ` [PATCH v3 3/6] MAINTAINERS: Update mail address of Aleksandar Rikalo Aleksandar Markovic
2019-10-12 17:37 ` [PATCH v3 4/6] target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D> Aleksandar Markovic
2019-10-12 17:37 ` [PATCH v3 5/6] target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D> Aleksandar Markovic
2019-10-12 17:37 ` [PATCH v3 6/6] target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D> Aleksandar Markovic
2019-10-12 18:13 ` no-reply [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=157090400982.19705.2876310576707631292@37313f22b938 \
    --to=no-reply@patchew.org \
    --cc=aleksandar.markovic@rt-rk.com \
    --cc=aleksandar.rikalo@rt-rk.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

QEMU-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/qemu-devel/0 qemu-devel/git/0.git
	git clone --mirror https://lore.kernel.org/qemu-devel/1 qemu-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 qemu-devel qemu-devel/ https://lore.kernel.org/qemu-devel \
		qemu-devel@nongnu.org
	public-inbox-index qemu-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.nongnu.qemu-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git