qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: richard.henderson@linaro.org
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [PULL for-4.2 0/1] softfp patch queue
Date: Wed, 30 Oct 2019 14:14:11 -0700 (PDT)	[thread overview]
Message-ID: <157247005058.32191.18374118663755793102@37313f22b938> (raw)
In-Reply-To: <20191030180953.24180-1-richard.henderson@linaro.org>

Patchew URL: https://patchew.org/QEMU/20191030180953.24180-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL for-4.2 0/1] softfp patch queue
Type: series
Message-id: 20191030180953.24180-1-richard.henderson@linaro.org

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
756cf34 softfp: Added hardfloat conversion from float32 to float64

=== OUTPUT BEGIN ===
ERROR: spaces required around that '*' (ctx:WxV)
#31: FILE: fpu/softfloat.c:1924:
+soft_float32_to_float64(float32 a, float_status *s)
                                                 ^

ERROR: spaces required around that '*' (ctx:WxV)
#38: FILE: fpu/softfloat.c:1931:
+float64 float32_to_float64(float32 a, float_status *s)
                                                    ^

total: 2 errors, 0 warnings, 31 lines checked

Commit 756cf34c13d0 (softfp: Added hardfloat conversion from float32 to float64) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20191030180953.24180-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

  parent reply	other threads:[~2019-10-30 21:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-30 18:09 [PULL for-4.2 0/1] softfp patch queue Richard Henderson
2019-10-30 18:09 ` [PULL for-4.2 1/1] softfp: Added hardfloat conversion from float32 to float64 Richard Henderson
2019-10-30 21:14 ` no-reply [this message]
2019-10-31 10:07 ` [PULL for-4.2 0/1] softfp patch queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=157247005058.32191.18374118663755793102@37313f22b938 \
    --to=no-reply@patchew.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).