From: no-reply@patchew.org
To: chanmickyyun@gmail.com
Cc: michan@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org,
chanmickyyun@gmail.com, mst@redhat.com
Subject: Re: [PATCH v4] Implement backend program convention command for vhost-user-blk
Date: Mon, 18 Nov 2019 20:04:23 -0800 (PST) [thread overview]
Message-ID: <157413626220.27250.4280058310420645706@37313f22b938> (raw)
In-Reply-To: <20191119022640.11021-1-michan@redhat.com>
Patchew URL: https://patchew.org/QEMU/20191119022640.11021-1-michan@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v4] Implement backend program convention command for vhost-user-blk
Type: series
Message-id: 20191119022640.11021-1-michan@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
036ea45 Implement backend program convention command for vhost-user-blk
=== OUTPUT BEGIN ===
ERROR: suspect code indent for conditional statements (8, 11)
#92: FILE: contrib/vhost-user-blk/vhost-user-blk.c:630:
+ if (lsock < 0) {
+ exit(EXIT_FAILURE);
ERROR: space required before the open brace '{'
#95: FILE: contrib/vhost-user-blk/vhost-user-blk.c:633:
+ } else if(opt_fdnum < 0){
ERROR: space required before the open parenthesis '('
#95: FILE: contrib/vhost-user-blk/vhost-user-blk.c:633:
+ } else if(opt_fdnum < 0){
total: 3 errors, 0 warnings, 143 lines checked
Commit 036ea457b43a (Implement backend program convention command for vhost-user-blk) has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20191119022640.11021-1-michan@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
next prev parent reply other threads:[~2019-11-19 4:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 2:26 [PATCH v4] Implement backend program convention command for vhost-user-blk Micky Yun Chan
2019-11-19 4:04 ` no-reply [this message]
2019-11-19 7:48 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157413626220.27250.4280058310420645706@37313f22b938 \
--to=no-reply@patchew.org \
--cc=chanmickyyun@gmail.com \
--cc=michan@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).