From: yuchenlin <1849644@bugs.launchpad.net>
To: qemu-devel@nongnu.org
Subject: [Bug 1849644] Re: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol
Date: Sat, 23 Nov 2019 03:48:26 -0000 [thread overview]
Message-ID: <157448090662.22220.3432528385242789737.malone@chaenomeles.canonical.com> (raw)
In-Reply-To: 157191258679.29920.9268940625941119092.malonedeb@soybean.canonical.com
I have sent a patch about this problem.
Please see https://lists.nongnu.org/archive/html/qemu-
devel/2019-11/msg03924.html
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1849644
Title:
QEMU VNC websocket proxy requires non-standard 'binary' subprotocol
Status in QEMU:
New
Bug description:
When running a machine using "-vnc" and the "websocket" option QEMU
seems to require the subprotocol called 'binary'. This subprotocol
does not exist in the WebSocket specification. In fact it has never
existed in the spec, in one of the very early drafts of WebSockets it
was briefly mentioned but it never made it to a final version.
When the WebSocket server requires a non-standard subprotocol any
WebSocket client that works correctly won't be able to connect.
One example of such a client is noVNC, it tells the server that it
doesn't want to use any subprotocol. QEMU's WebSocket proxy doesn't
let noVNC connect. If noVNC is modified to ask for 'binary' it will
work, this is, however, incorrect behavior.
Looking at the code in "io/channel-websock.c" it seems it's quite
hard-coded to binary:
Look at line 58 and 433 here:
https://git.qemu.org/?p=qemu.git;a=blob;f=io/channel-websock.c
This code has to be made more dynamic, and shouldn't require binary.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1849644/+subscriptions
next prev parent reply other threads:[~2019-11-23 3:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 10:23 [Bug 1849644] [NEW] QEMU VNC websocket proxy requires non-standard 'binary' subprotocol Samuel
2019-10-24 17:15 ` [Bug 1849644] " Daniel Berrange
2019-10-28 12:36 ` Samuel
2019-11-23 3:48 ` yuchenlin [this message]
2020-01-02 10:41 ` Samuel
2020-01-15 1:43 ` yuchenlin
2020-01-27 8:27 ` Samuel
2020-02-10 9:52 ` Daniel Berrange
2020-03-10 9:08 ` Laurent Vivier
2020-04-30 13:36 ` Laurent Vivier
2020-09-24 9:25 ` Christian Ehrhardt
2020-09-24 10:22 ` Christian Ehrhardt
2020-09-24 13:15 ` Christian Ehrhardt
2020-09-25 5:47 ` Christian Ehrhardt
2020-09-25 6:07 ` Launchpad Bug Tracker
2020-09-25 6:09 ` Christian Ehrhardt
2020-09-29 12:59 ` Robie Basak
2020-09-30 3:53 ` [Bug 1849644] Autopkgtest regression report (qemu/1:4.2-3ubuntu6.7) Ubuntu SRU Bot
2020-09-30 8:15 ` [Bug 1849644] Re: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol Christian Ehrhardt
2020-10-12 9:44 ` Launchpad Bug Tracker
2020-10-12 9:44 ` [Bug 1849644] Update Released Łukasz Zemczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157448090662.22220.3432528385242789737.malone@chaenomeles.canonical.com \
--to=1849644@bugs.launchpad.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).