Re: [PATCH] socket: websocket refresh of max_size outside of poll

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20191205140645.6071-1-aastier@freebox.fr/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH] socket: websocket refresh of max_size outside of poll
Type: series
Message-id: 20191205140645.6071-1-aastier@freebox.fr

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
17c57dd socket: websocket refresh of max_size outside of poll

=== OUTPUT BEGIN ===
ERROR: space required before the open parenthesis '('
#31: FILE: chardev/char-socket.c:508:
+    if(s->is_websock)

WARNING: line over 80 characters
#32: FILE: chardev/char-socket.c:509:
+        /* Greedy reader does not have event loop refresh by tcp_chr_read_poll */

total: 1 errors, 1 warnings, 9 lines checked

Commit 17c57ddf8310 (socket: websocket refresh of max_size outside of poll) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20191205140645.6071-1-aastier@freebox.fr/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com