From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7203AC33CAF for ; Thu, 16 Jan 2020 22:16:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3ED122073A for ; Thu, 16 Jan 2020 22:16:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3ED122073A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=twiddle.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isDRI-000227-Aj for qemu-devel@archiver.kernel.org; Thu, 16 Jan 2020 17:16:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43411) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isDQe-0001Yr-Qb for qemu-devel@nongnu.org; Thu, 16 Jan 2020 17:15:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1isDQd-0005Ww-Ey for qemu-devel@nongnu.org; Thu, 16 Jan 2020 17:15:52 -0500 Received: from indium.canonical.com ([91.189.90.7]:43930) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1isDQd-0005Vj-9C for qemu-devel@nongnu.org; Thu, 16 Jan 2020 17:15:51 -0500 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.86_2 #2 (Debian)) id 1isDQb-0000Oj-2r for ; Thu, 16 Jan 2020 22:15:49 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id 12F422E80C7 for ; Thu, 16 Jan 2020 22:15:49 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Thu, 16 Jan 2020 22:04:18 -0000 From: Richard Henderson To: qemu-devel@nongnu.org X-Launchpad-Notification-Type: bug X-Launchpad-Bug: product=qemu; status=Confirmed; importance=Undecided; assignee=rth@twiddle.net; X-Launchpad-Bug-Tags: arm X-Launchpad-Bug-Information-Type: Public X-Launchpad-Bug-Private: no X-Launchpad-Bug-Security-Vulnerability: no X-Launchpad-Bug-Commenters: grassead rth vdehors X-Launchpad-Bug-Reporter: Adrien Grassein (grassead) X-Launchpad-Bug-Modifier: Richard Henderson (rth) References: <157903678645.2454.11578772527064917210.malonedeb@soybean.canonical.com> Message-Id: <157921225884.4224.13885199445639318230.malone@soybean.canonical.com> Subject: [Bug 1859713] Re: ARM v8.3a pauth not working X-Launchpad-Message-Rationale: Subscriber (QEMU) @qemu-devel-ml X-Launchpad-Message-For: qemu-devel-ml Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="f1052173880d8dae43faa7c2fc45da1b42227143"; Instance="production-secrets-lazr.conf" X-Launchpad-Hash: 79e5d76332b7ef371fef37a497f0ae36ceadfece X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 91.189.90.7 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Bug 1859713 <1859713@bugs.launchpad.net> Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Ooof. Good catch on the sbox error. That said, how did you test pauth_computepac? I still do not get the C5 result above, but 0x99d88f4472f3be39. The following test case sets up the parameters. ** Patch added: "test case" https://bugs.launchpad.net/qemu/+bug/1859713/+attachment/5320967/+files/= 0001-tests-tcg-aarch64-Add-pauth-3.patch -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1859713 Title: ARM v8.3a pauth not working Status in QEMU: Confirmed Bug description: Host: Ubuntu 19.10 - x86_64 machine QEMU version: 3a63b24a1bbf166e6f455fe43a6bbd8dea413d92 (master) ARMV8.3 pauth is not working well. With a test code containing two pauth instructions: - paciasp that sign LR with A key and sp as context; - autiasp that verify the signature. Test: - Run the program and corrupt LR just before autiasp (ex 0x3e00000400= 660 instead of 0x3e000000400664) Expected: - autiasp places an invalid pointer in LR Result: - autiasp successfully auth the pointer and places 0x0400660 in LR. Further explanations: Adding traces in qemu code shows that "pauth_computepac" is not robus= t enough against truncating. With 0x31000000400664 as input of pauth_auth, we obtain "0x55b1d65b2c= 138e14" for PAC, "0x30" for bot_bit and "0x38" for top_bit. With 0x310040008743ec as input of pauth (with same key), we obtain "0= x55b1d65b2c138ef4" for PAC, "0x30" for bot_bit and "0x38" for top_bit. Values of top_bit and bottom_bit are strictly the same and it should = not. To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1859713/+subscriptions