From: no-reply@patchew.org
To: mst@redhat.com
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [PULL 00/17] virtio, pc: fixes, features
Date: Tue, 21 Jan 2020 22:17:42 -0800 (PST) [thread overview]
Message-ID: <157967386115.8714.16146185353755623209@f6d1ed32ca6b> (raw)
In-Reply-To: <20200122055115.429945-1-mst@redhat.com>
Patchew URL: https://patchew.org/QEMU/20200122055115.429945-1-mst@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200122055115.429945-1-mst@redhat.com
Subject: [PULL 00/17] virtio, pc: fixes, features
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
* [new tag] patchew/20200122055115.429945-1-mst@redhat.com -> patchew/20200122055115.429945-1-mst@redhat.com
Switched to a new branch 'test'
dbbbe7b i386:acpi: Remove _HID from the SMBus ACPI entry
bd10a6b vhost: Only align sections for vhost-user
ab4696c vhost: Add names to section rounded warning
7c83ff2 vhost-vsock: delete vqs in vhost_vsock_unrealize to avoid memleaks
b7a6fa9 virtio-scsi: convert to new virtio_delete_queue
c151cac virtio-scsi: delete vqs in unrealize to avoid memleaks
43b2576 virtio-9p-device: convert to new virtio_delete_queue
233ede9 virtio-9p-device: fix memleak in virtio_9p_device_unrealize
cbca7b4 bios-tables-test: document expected file update
889245c acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command
d693954 acpi: cpuhp: spec: add typical usecases
1c967e4 acpi: cpuhp: introduce 'Command data 2' field
2c87154 acpi: cpuhp: spec: clarify store into 'Command data' when 'Command field' == 0
875e2af acpi: cpuhp: spec: fix 'Command data' description
16c15d6 acpi: cpuhp: spec: clarify 'CPU selector' register usage and endianness
b3207b3 tests: q35: MCH: add default SMBASE SMRAM lock test
02823db q35: implement 128K SMRAM at default SMBASE address
=== OUTPUT BEGIN ===
1/17 Checking commit 02823db3437d (q35: implement 128K SMRAM at default SMBASE address)
2/17 Checking commit b3207b3998a9 (tests: q35: MCH: add default SMBASE SMRAM lock test)
3/17 Checking commit 16c15d6ab057 (acpi: cpuhp: spec: clarify 'CPU selector' register usage and endianness)
4/17 Checking commit 875e2af092e9 (acpi: cpuhp: spec: fix 'Command data' description)
5/17 Checking commit 2c871544d986 (acpi: cpuhp: spec: clarify store into 'Command data' when 'Command field' == 0)
6/17 Checking commit 1c967e4c7e0a (acpi: cpuhp: introduce 'Command data 2' field)
7/17 Checking commit d693954ab6e4 (acpi: cpuhp: spec: add typical usecases)
8/17 Checking commit 889245cb021f (acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command)
9/17 Checking commit cbca7b4cc4b0 (bios-tables-test: document expected file update)
WARNING: line over 80 characters
#23: FILE: tests/qtest/bios-tables-test.c:20:
+ * Contributor or ACPI Maintainer (steps 4-7 need to be redone to resolve conflicts
total: 0 errors, 1 warnings, 38 lines checked
Patch 9/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/17 Checking commit 233ede934524 (virtio-9p-device: fix memleak in virtio_9p_device_unrealize)
11/17 Checking commit 43b25766fe8d (virtio-9p-device: convert to new virtio_delete_queue)
12/17 Checking commit c151cac0ebf8 (virtio-scsi: delete vqs in unrealize to avoid memleaks)
13/17 Checking commit b7a6fa987abb (virtio-scsi: convert to new virtio_delete_queue)
14/17 Checking commit 7c83ff29ef1f (vhost-vsock: delete vqs in vhost_vsock_unrealize to avoid memleaks)
15/17 Checking commit ab4696cfca2a (vhost: Add names to section rounded warning)
16/17 Checking commit bd10a6b17eb6 (vhost: Only align sections for vhost-user)
ERROR: trailing whitespace
#49: FILE: hw/virtio/vhost.c:554:
+ if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) { $
WARNING: line over 80 characters
#64: FILE: hw/virtio/vhost.c:569:
+ trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa, mrs_size,
total: 1 errors, 1 warnings, 43 lines checked
Patch 16/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/17 Checking commit dbbbe7b4ff3d (i386:acpi: Remove _HID from the SMBus ACPI entry)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200122055115.429945-1-mst@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
next prev parent reply other threads:[~2020-01-22 6:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 5:51 [PULL 00/17] virtio, pc: fixes, features Michael S. Tsirkin
2020-01-22 5:51 ` [PULL 01/17] q35: implement 128K SMRAM at default SMBASE address Michael S. Tsirkin
2020-01-22 5:51 ` [PULL 02/17] tests: q35: MCH: add default SMBASE SMRAM lock test Michael S. Tsirkin
2020-01-22 5:51 ` [PULL 03/17] acpi: cpuhp: spec: clarify 'CPU selector' register usage and endianness Michael S. Tsirkin
2020-01-22 5:51 ` [PULL 04/17] acpi: cpuhp: spec: fix 'Command data' description Michael S. Tsirkin
2020-01-22 5:52 ` [PULL 05/17] acpi: cpuhp: spec: clarify store into 'Command data' when 'Command field' == 0 Michael S. Tsirkin
2020-01-22 5:52 ` [PULL 06/17] acpi: cpuhp: introduce 'Command data 2' field Michael S. Tsirkin
2020-01-22 5:52 ` [PULL 07/17] acpi: cpuhp: spec: add typical usecases Michael S. Tsirkin
2020-01-22 5:52 ` [PULL 08/17] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command Michael S. Tsirkin
2020-01-22 5:52 ` [PULL 09/17] bios-tables-test: document expected file update Michael S. Tsirkin
2020-01-22 5:52 ` [PULL 10/17] virtio-9p-device: fix memleak in virtio_9p_device_unrealize Michael S. Tsirkin
2020-01-22 5:52 ` [PULL 11/17] virtio-9p-device: convert to new virtio_delete_queue Michael S. Tsirkin
2020-01-22 5:52 ` [PULL 12/17] virtio-scsi: delete vqs in unrealize to avoid memleaks Michael S. Tsirkin
2020-01-22 5:52 ` [PULL 13/17] virtio-scsi: convert to new virtio_delete_queue Michael S. Tsirkin
2020-01-22 5:52 ` [PULL 14/17] vhost-vsock: delete vqs in vhost_vsock_unrealize to avoid memleaks Michael S. Tsirkin
2020-01-22 5:52 ` [PULL 15/17] vhost: Add names to section rounded warning Michael S. Tsirkin
2020-01-22 5:52 ` [PULL 16/17] vhost: Only align sections for vhost-user Michael S. Tsirkin
2020-01-22 5:52 ` [PULL 17/17] i386:acpi: Remove _HID from the SMBus ACPI entry Michael S. Tsirkin
2020-01-22 6:17 ` no-reply [this message]
2020-01-22 6:23 ` [PULL 00/17] virtio, pc: fixes, features no-reply
2020-01-22 6:25 ` Michael S. Tsirkin
2020-01-22 6:50 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157967386115.8714.16146185353755623209@f6d1ed32ca6b \
--to=no-reply@patchew.org \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).