From: no-reply@patchew.org
To: alistair.francis@wdc.com
Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org, laurent@vivier.eu,
alistair.francis@wdc.com, alistair23@gmail.com,
palmer@dabbelt.com
Subject: Re: [PATCH v1 0/2] linux-user: generate syscall_nr.sh for RISC-V
Date: Thu, 20 Feb 2020 15:31:31 -0800 (PST) [thread overview]
Message-ID: <158224149003.31180.5954402657995887989@a1bbccc8075a> (raw)
In-Reply-To: <cover.1582240656.git.alistair.francis@wdc.com>
Patchew URL: https://patchew.org/QEMU/cover.1582240656.git.alistair.francis@wdc.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v1 0/2] linux-user: generate syscall_nr.sh for RISC-V
Message-id: cover.1582240656.git.alistair.francis@wdc.com
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/cover.1582240656.git.alistair.francis@wdc.com -> patchew/cover.1582240656.git.alistair.francis@wdc.com
Switched to a new branch 'test'
a8f95ff linux-user/riscv: Update the syscall_nr's to the 5.5 kernel
8f319fe linux-user: Protect more syscalls
=== OUTPUT BEGIN ===
1/2 Checking commit 8f319fe4044f (linux-user: Protect more syscalls)
ERROR: space prohibited between function name and open parenthesis '('
#75: FILE: linux-user/syscall.c:1088:
+#if defined(TARGET_NR_getrlimit) || defined (TARGET_NR_ugetrlimit)
total: 1 errors, 0 warnings, 121 lines checked
Patch 1/2 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/2 Checking commit a8f95ff78d20 (linux-user/riscv: Update the syscall_nr's to the 5.5 kernel)
WARNING: Block comments use a leading /* on a separate line
#377: FILE: linux-user/riscv/syscall_nr.h:442:
+/* Alias some of the older pre 64-bit time_t syscalls to the 64-bit
WARNING: Block comments use a trailing */ on a separate line
#378: FILE: linux-user/riscv/syscall_nr.h:443:
+ * ones for RV32. This is based on the list used by glibc. */
total: 0 errors, 2 warnings, 370 lines checked
Patch 2/2 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/cover.1582240656.git.alistair.francis@wdc.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
prev parent reply other threads:[~2020-02-20 23:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 23:18 [PATCH v1 0/2] linux-user: generate syscall_nr.sh for RISC-V Alistair Francis
2020-02-20 23:18 ` [PATCH v1 1/2] linux-user: Protect more syscalls Alistair Francis
2020-02-21 8:55 ` Philippe Mathieu-Daudé
2020-02-20 23:18 ` [PATCH v1 2/2] linux-user/riscv: Update the syscall_nr's to the 5.5 kernel Alistair Francis
2020-02-22 11:29 ` Laurent Vivier
2020-02-24 19:30 ` Alistair Francis
2020-02-20 23:31 ` no-reply [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158224149003.31180.5954402657995887989@a1bbccc8075a \
--to=no-reply@patchew.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=laurent@vivier.eu \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).