QEMU-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: no-reply@patchew.org
To: bbhushan2@marvell.com
Cc: yang.zhong@intel.com, peter.maydell@linaro.org,
	kevin.tian@intel.com, tnowicki@marvell.com, mst@redhat.com,
	drjones@redhat.com, peterx@redhat.com, qemu-devel@nongnu.org,
	alex.williamson@redhat.com, qemu-arm@nongnu.org,
	bharatb.linux@gmail.com, jean-philippe@linaro.org,
	linuc.decode@gmail.com, bbhushan2@marvell.com,
	eric.auger.pro@gmail.com
Subject: Re: [PATCH v9 0/9] virtio-iommu: VFIO integration
Date: Mon, 23 Mar 2020 02:52:27 -0700 (PDT)
Message-ID: <158495714567.4794.13061570154282709223@39012742ff91> (raw)
In-Reply-To: <20200323084617.1782-1-bbhushan2@marvell.com>

Patchew URL: https://patchew.org/QEMU/20200323084617.1782-1-bbhushan2@marvell.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v9 0/9] virtio-iommu: VFIO integration
Message-id: 20200323084617.1782-1-bbhushan2@marvell.com
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   9b26a61..29e0855  master     -> master
 - [tag update]      patchew/20200320160622.8040-1-richard.henderson@linaro.org -> patchew/20200320160622.8040-1-richard.henderson@linaro.org
Switched to a new branch 'test'
8eeb60c virtio-iommu: add iommu notifier memory-region
176e083 virtio-iommu: Implement probe request
221f4ba virtio-iommu: add iommu replay
30211fd virtio-iommu: Call iommu notifier for attach/detach
84f316d virtio-iommu: Add iommu notifier for map/unmap
8cc559f virtio-iommu: set supported page size mask
d4062a9 vfio: set iommu page size as per host supported page size
cc9310f memory: Add interface to set iommu page size mask
2b43555 hw/vfio/common: Remove error print on mmio region translation by viommu

=== OUTPUT BEGIN ===
1/9 Checking commit 2b43555a2f62 (hw/vfio/common: Remove error print on mmio region translation by viommu)
2/9 Checking commit cc9310f32d06 (memory: Add interface to set iommu page size mask)
3/9 Checking commit d4062a953cef (vfio: set iommu page size as per host supported page size)
4/9 Checking commit 8cc559f025ae (virtio-iommu: set supported page size mask)
5/9 Checking commit 84f316d68429 (virtio-iommu: Add iommu notifier for map/unmap)
6/9 Checking commit 30211fdb36cd (virtio-iommu: Call iommu notifier for attach/detach)
7/9 Checking commit 221f4ba0d125 (virtio-iommu: add iommu replay)
8/9 Checking commit 176e0834bcee (virtio-iommu: Implement probe request)
ERROR: code indent should never use tabs
#93: FILE: hw/virtio/virtio-iommu.c:539:
+^I}$

ERROR: code indent should never use tabs
#122: FILE: hw/virtio/virtio-iommu.c:568:
+^Ibreak;$

total: 2 errors, 0 warnings, 250 lines checked

Patch 8/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

9/9 Checking commit 8eeb60c12ace (virtio-iommu: add iommu notifier memory-region)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200323084617.1782-1-bbhushan2@marvell.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

  parent reply index

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-23  8:46 Bharat Bhushan
2020-03-23  8:46 ` [PATCH v9 1/9] hw/vfio/common: Remove error print on mmio region translation by viommu Bharat Bhushan
2020-03-23 23:08   ` Alex Williamson
2020-03-26 17:35     ` Auger Eric
2020-03-26 17:53       ` Alex Williamson
2020-03-27  5:50         ` [EXT] " Bharat Bhushan
2020-04-02  9:01         ` Bharat Bhushan
2020-04-24 14:17           ` Auger Eric
2020-05-05  9:25             ` Bharat Bhushan
2020-05-05  9:30               ` Auger Eric
2020-05-05  9:46                 ` Bharat Bhushan
2020-05-05 10:18                   ` Bharat Bhushan
2020-05-05 12:05                     ` Auger Eric
2020-05-07 14:40                     ` Auger Eric
2020-03-23  8:46 ` [PATCH v9 2/9] memory: Add interface to set iommu page size mask Bharat Bhushan
2020-03-26 16:06   ` Auger Eric
2020-03-27  5:33     ` [EXT] " Bharat Bhushan
2020-03-27  8:27       ` Auger Eric
2020-03-23  8:46 ` [PATCH v9 3/9] vfio: set iommu page size as per host supported page size Bharat Bhushan
2020-03-23  8:46 ` [PATCH v9 4/9] virtio-iommu: set supported page size mask Bharat Bhushan
2020-03-26 15:51   ` Auger Eric
2020-03-27  5:13     ` [EXT] " Bharat Bhushan
2020-03-27  8:28       ` Auger Eric
2020-03-23  8:46 ` [PATCH v9 5/9] virtio-iommu: Add iommu notifier for map/unmap Bharat Bhushan
2020-03-23  8:46 ` [PATCH v9 6/9] virtio-iommu: Call iommu notifier for attach/detach Bharat Bhushan
2020-03-23  8:46 ` [PATCH v9 7/9] virtio-iommu: add iommu replay Bharat Bhushan
2020-03-23  8:46 ` [PATCH v9 8/9] virtio-iommu: Implement probe request Bharat Bhushan
2020-03-26 15:48   ` Auger Eric
2020-03-27  5:40     ` [EXT] " Bharat Bhushan
2020-03-27  8:34       ` Auger Eric
2020-04-23 16:09   ` Jean-Philippe Brucker
2020-04-24 13:51     ` Auger Eric
2020-05-05  9:06       ` Bharat Bhushan
2020-05-07 14:42         ` Auger Eric
2020-03-23  8:46 ` [PATCH v9 9/9] virtio-iommu: add iommu notifier memory-region Bharat Bhushan
2020-03-23  9:52 ` no-reply [this message]
2020-03-23  9:59 ` [PATCH v9 0/9] virtio-iommu: VFIO integration no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=158495714567.4794.13061570154282709223@39012742ff91 \
    --to=no-reply@patchew.org \
    --cc=alex.williamson@redhat.com \
    --cc=bbhushan2@marvell.com \
    --cc=bharatb.linux@gmail.com \
    --cc=drjones@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=jean-philippe@linaro.org \
    --cc=kevin.tian@intel.com \
    --cc=linuc.decode@gmail.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=tnowicki@marvell.com \
    --cc=yang.zhong@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

QEMU-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/qemu-devel/0 qemu-devel/git/0.git
	git clone --mirror https://lore.kernel.org/qemu-devel/1 qemu-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 qemu-devel qemu-devel/ https://lore.kernel.org/qemu-devel \
		qemu-devel@nongnu.org
	public-inbox-index qemu-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.nongnu.qemu-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git