Re: [PATCH 0/9] Record/replay acceptance tests

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/159040554265.2615.8993443700754452381.stgit@pasha-ThinkPad-X280/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 159040554265.2615.8993443700754452381.stgit@pasha-ThinkPad-X280
Subject: [PATCH 0/9] Record/replay acceptance tests
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20200525134101.24740-1-kraxel@redhat.com -> patchew/20200525134101.24740-1-kraxel@redhat.com
Switched to a new branch 'test'
a859b96 tests/acceptance: Linux boot test for record/replay
14e5ce4 tests/acceptance: record/replay tests with advcal images
5cdf4d3 tests/acceptance: add record/replay test for m68k
0dc5c81 tests/acceptance: add record/replay test for ppc64
ec0d080 tests/acceptance: add record/replay test for arm
7a0dd72 tests/acceptance: add record/replay test for aarch64
3025aed tests/acceptance: add kernel record/replay test for x86_64
9971ff6 tests/acceptance: add base class record/replay kernel tests
2042d8d tests/acceptance: allow console interaction with specific VMs

=== OUTPUT BEGIN ===
1/9 Checking commit 2042d8dddac8 (tests/acceptance: allow console interaction with specific VMs)
WARNING: line over 80 characters
#43: FILE: tests/acceptance/avocado_qemu/__init__.py:120:
+def wait_for_console_pattern(test, success_message, failure_message=None, vm=None):

total: 0 errors, 1 warnings, 34 lines checked

Patch 1/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/9 Checking commit 9971ff6fbc70 (tests/acceptance: add base class record/replay kernel tests)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
new file mode 100644

ERROR: line over 90 characters
#94: FILE: tests/acceptance/replay_kernel.py:58:
+    def run_vm(self, kernel_path, kernel_command_line, console_pattern, record, shift, args):

WARNING: line over 80 characters
#114: FILE: tests/acceptance/replay_kernel.py:78:
+    def run_rr(self, kernel_path, kernel_command_line, console_pattern, shift=7, args=()):

WARNING: line over 80 characters
#115: FILE: tests/acceptance/replay_kernel.py:79:
+        self.run_vm(kernel_path, kernel_command_line, console_pattern, True, shift, args)

WARNING: line over 80 characters
#116: FILE: tests/acceptance/replay_kernel.py:80:
+        self.run_vm(kernel_path, kernel_command_line, console_pattern, False, shift, args)

total: 1 errors, 4 warnings, 87 lines checked

Patch 2/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/9 Checking commit 3025aedc97d7 (tests/acceptance: add kernel record/replay test for x86_64)
4/9 Checking commit 7a0dd72514f7 (tests/acceptance: add record/replay test for aarch64)
5/9 Checking commit ec0d0808a993 (tests/acceptance: add record/replay test for arm)
6/9 Checking commit 0dc5c81830b7 (tests/acceptance: add record/replay test for ppc64)
7/9 Checking commit 5cdf4d3ab6fa (tests/acceptance: add record/replay test for m68k)
8/9 Checking commit 14e5ce4abb6e (tests/acceptance: record/replay tests with advcal images)
9/9 Checking commit a859b96e665d (tests/acceptance: Linux boot test for record/replay)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

ERROR: line over 90 characters
#84: FILE: tests/acceptance/replay_linux.py:42:
+        vm.add_args('-drive', 'driver=blkreplay,id=disk%s-rr,if=none,image=disk%s' % (id, id))

WARNING: line over 80 characters
#85: FILE: tests/acceptance/replay_linux.py:43:
+        vm.add_args('-device', '%s,drive=disk%s-rr%s' % (device, id, bus_string))

WARNING: line over 80 characters
#147: FILE: tests/acceptance/replay_linux.py:105:
+                                                 logger=self.log.getChild('console'),

ERROR: line over 90 characters
#148: FILE: tests/acceptance/replay_linux.py:106:
+                                                 stop_check=(lambda : not vm.is_running()))

WARNING: line over 80 characters
#151: FILE: tests/acceptance/replay_linux.py:109:
+            self.log.info('VM launched, waiting for boot confirmation from guest')

WARNING: line over 80 characters
#152: FILE: tests/acceptance/replay_linux.py:110:
+            cloudinit.wait_for_phone_home(('0.0.0.0', self.phone_home_port), self.name)

WARNING: line over 80 characters
#155: FILE: tests/acceptance/replay_linux.py:113:
+            self.log.info('VM launched, waiting the recorded execution to be replayed')

total: 2 errors, 6 warnings, 147 lines checked

Patch 9/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/159040554265.2615.8993443700754452381.stgit@pasha-ThinkPad-X280/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com