From: no-reply@patchew.org
To: frankja@linux.ibm.com
Cc: thuth@redhat.com, david@redhat.com, cohuck@redhat.com,
qemu-devel@nongnu.org, borntraeger@de.ibm.com,
qemu-s390x@nongnu.org
Subject: Re: [PATCH v3 0/9] pc-bios: s390x: Cleanup part 1
Date: Wed, 27 May 2020 03:30:37 -0700 (PDT) [thread overview]
Message-ID: <159057543622.16318.7152853717183910673@45ef0f9c86ae> (raw)
In-Reply-To: <20200527074920.43669-1-frankja@linux.ibm.com>
Patchew URL: https://patchew.org/QEMU/20200527074920.43669-1-frankja@linux.ibm.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20200527074920.43669-1-frankja@linux.ibm.com
Subject: [PATCH v3 0/9] pc-bios: s390x: Cleanup part 1
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
799f5f1 pc-bios: s390x: Make u32 ptr check explicit
64c8922 pc-bios: s390x: Use ebcdic2ascii table
3e12724 pc-bios: s390x: Move panic() into header and add infinite loop
49db366 pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDR
1370a46 pc-bios: s390x: Rename and use PSW_MASK_ZMODE constant
9f1140a pc-bios: s390x: Get rid of magic offsets into the lowcore
dba1abc pc-bios: s390x: Move sleep and yield to helper.h
f694d50 pc-bios: s390x: Consolidate timing functions into time.h
ec7ac62 pc-bios: s390x: cio.c cleanup and compile fix
=== OUTPUT BEGIN ===
1/9 Checking commit ec7ac623cb81 (pc-bios: s390x: cio.c cleanup and compile fix)
2/9 Checking commit f694d5005ea2 (pc-bios: s390x: Consolidate timing functions into time.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#77:
new file mode 100644
total: 0 errors, 1 warnings, 127 lines checked
Patch 2/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/9 Checking commit dba1abc5f5c8 (pc-bios: s390x: Move sleep and yield to helper.h)
4/9 Checking commit 9f1140afc2da (pc-bios: s390x: Get rid of magic offsets into the lowcore)
ERROR: spaces required around that ':' (ctx:VxV)
#30: FILE: pc-bios/s390-ccw/cio.h:127:
+ __u16 cssid:8;
^
ERROR: spaces required around that ':' (ctx:VxV)
#31: FILE: pc-bios/s390-ccw/cio.h:128:
+ __u16 reserved:4;
^
ERROR: spaces required around that ':' (ctx:VxV)
#32: FILE: pc-bios/s390-ccw/cio.h:129:
+ __u16 m:1;
^
ERROR: spaces required around that ':' (ctx:VxV)
#33: FILE: pc-bios/s390-ccw/cio.h:130:
+ __u16 ssid:2;
^
ERROR: spaces required around that ':' (ctx:VxV)
#34: FILE: pc-bios/s390-ccw/cio.h:131:
+ __u16 one:1;
^
total: 5 errors, 0 warnings, 37 lines checked
Patch 4/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/9 Checking commit 1370a46cdd57 (pc-bios: s390x: Rename and use PSW_MASK_ZMODE constant)
6/9 Checking commit 49db366a3248 (pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDR)
7/9 Checking commit 3e12724946c3 (pc-bios: s390x: Move panic() into header and add infinite loop)
8/9 Checking commit 64c89223f1f8 (pc-bios: s390x: Use ebcdic2ascii table)
9/9 Checking commit 799f5f138abb (pc-bios: s390x: Make u32 ptr check explicit)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200527074920.43669-1-frankja@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
prev parent reply other threads:[~2020-05-27 10:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 7:49 [PATCH v3 0/9] pc-bios: s390x: Cleanup part 1 Janosch Frank
2020-05-27 7:49 ` [PATCH v3 1/9] pc-bios: s390x: cio.c cleanup and compile fix Janosch Frank
2020-05-27 8:24 ` Christian Borntraeger
2020-05-27 8:34 ` Janosch Frank
2020-05-27 7:49 ` [PATCH v3 2/9] pc-bios: s390x: Consolidate timing functions into time.h Janosch Frank
2020-05-27 8:36 ` Christian Borntraeger
2020-05-27 8:41 ` Janosch Frank
2020-05-27 7:49 ` [PATCH v3 3/9] pc-bios: s390x: Move sleep and yield to helper.h Janosch Frank
2020-05-27 8:34 ` Christian Borntraeger
2020-05-27 8:35 ` Janosch Frank
2020-05-27 7:49 ` [PATCH v3 4/9] pc-bios: s390x: Get rid of magic offsets into the lowcore Janosch Frank
2020-05-27 8:50 ` Christian Borntraeger
2020-05-27 11:23 ` Janosch Frank
2020-05-27 7:49 ` [PATCH v3 5/9] pc-bios: s390x: Rename and use PSW_MASK_ZMODE constant Janosch Frank
2020-05-27 7:49 ` [PATCH v3 6/9] pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDR Janosch Frank
2020-05-27 7:49 ` [PATCH v3 7/9] pc-bios: s390x: Move panic() into header and add infinite loop Janosch Frank
2020-05-27 7:49 ` [PATCH v3 8/9] pc-bios: s390x: Use ebcdic2ascii table Janosch Frank
2020-05-27 7:49 ` [PATCH v3 9/9] pc-bios: s390x: Make u32 ptr check explicit Janosch Frank
2020-05-27 10:30 ` no-reply [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159057543622.16318.7152853717183910673@45ef0f9c86ae \
--to=no-reply@patchew.org \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).