From: no-reply@patchew.org
To: mst@redhat.com
Cc: imammedo@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v2] tests: disassemble-aml.sh: generate AML in readable format
Date: Wed, 1 Jul 2020 07:24:52 -0700 (PDT) [thread overview]
Message-ID: <159361349123.26405.13886207944377670259@d1fd068a5071> (raw)
In-Reply-To: <20200701121349.50523-1-mst@redhat.com>
Patchew URL: https://patchew.org/QEMU/20200701121349.50523-1-mst@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v2] tests: disassemble-aml.sh: generate AML in readable format
Type: series
Message-id: 20200701121349.50523-1-mst@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
* [new tag] patchew/20200701121349.50523-1-mst@redhat.com -> patchew/20200701121349.50523-1-mst@redhat.com
Switched to a new branch 'test'
ab54232 tests: disassemble-aml.sh: generate AML in readable format
=== OUTPUT BEGIN ===
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16:
new file mode 100755
WARNING: line over 80 characters
#30: FILE: tests/data/acpi/disassemle-aml.sh:10:
+ echo "Usage: ./tests/data/acpi/disassemle-aml.sh [-o <output-directory>]"
ERROR: line over 90 characters
#81: FILE: tests/data/acpi/rebuild-expected-aml.sh:39:
+echo "You can use ${SRC_PATH}/tests/data/acpi/disassemle-aml.sh to disassemble them to ASL."
total: 1 errors, 2 warnings, 59 lines checked
Commit ab5423293da2 (tests: disassemble-aml.sh: generate AML in readable format) has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200701121349.50523-1-mst@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
prev parent reply other threads:[~2020-07-01 14:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 12:14 [PATCH v2] tests: disassemble-aml.sh: generate AML in readable format Michael S. Tsirkin
2020-07-01 14:24 ` no-reply [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159361349123.26405.13886207944377670259@d1fd068a5071 \
--to=no-reply@patchew.org \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).