From: Babu Moger <babu.moger@amd.com>
To: pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com,
imammedo@redhat.com
Cc: qemu-devel@nongnu.org, mst@redhat.com
Subject: [PATCH v3 0/3] Fix couple of issues with AMD topology
Date: Fri, 07 Aug 2020 11:32:38 -0500 [thread overview]
Message-ID: <159681772267.9679.1334429994189974662.stgit@naples-babu.amd.com> (raw)
This series fixes couple of issues with recent topology related code.
1. Warn users to pass the dies information if EPYC cpu is numa configured.
2. Remove the node_id references in topology and use die_id instead.
3. With node_id removed in topology the uninitialized memory issue
with -device and CPU hotplug will be fixed.
Link: https://bugzilla.redhat.com/show_bug.cgi?id=1828750
---
v3:
Added a new check to pass the dies for EPYC numa configuration.
Added Simplify CPUID_8000_001E patch with some changes suggested by Igor.
Dropped the patch to build the topology from CpuInstanceProperties.
TODO: Not sure if we still need the Autonuma changes Igor mentioned.
Needs more clarity on that.
v2:
https://lore.kernel.org/qemu-devel/159362436285.36204.986406297373871949.stgit@naples-babu.amd.com/
- Used the numa information from CpuInstanceProperties for building
the apic_id suggested by Igor.
- Also did some minor code re-aarangement to take care of changes.
- Dropped the patch "Simplify CPUID_8000_001E" from v1. Will send
it later.
v1:
https://lore.kernel.org/qemu-devel/159164739269.20543.3074052993891532749.stgit@naples-babu.amd.com
Babu Moger (3):
i386: Simplify CPUID_8000_001E for AMD
hw/i386: Add a new check to configure smp dies for EPYC
hw/i386: Remove node_id, nr_nodes and nodes_per_pkg from topology
hw/i386/pc.c | 1 -
hw/i386/x86.c | 8 ++++
include/hw/i386/topology.h | 40 +++++---------------
target/i386/cpu.c | 86 +++++++++++++++++++-------------------------
target/i386/cpu.h | 1 -
5 files changed, 54 insertions(+), 82 deletions(-)
--
next reply other threads:[~2020-08-07 16:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 16:32 Babu Moger [this message]
2020-08-07 16:32 ` [PATCH v3 1/3] i386: Simplify CPUID_8000_001E for AMD Babu Moger
2020-08-07 18:11 ` Igor Mammedov
2020-08-07 16:32 ` [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC Babu Moger
2020-08-07 16:52 ` Daniel P. Berrangé
2020-08-07 17:23 ` Babu Moger
2020-08-07 19:11 ` Igor Mammedov
2020-08-11 21:03 ` Babu Moger
2020-08-13 13:56 ` Igor Mammedov
2020-08-13 21:10 ` Babu Moger
2020-08-07 19:27 ` Igor Mammedov
2020-08-11 21:04 ` Babu Moger
2020-08-07 16:32 ` [PATCH v3 3/3] hw/i386: Remove node_id, nr_nodes and nodes_per_pkg from topology Babu Moger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159681772267.9679.1334429994189974662.stgit@naples-babu.amd.com \
--to=babu.moger@amd.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).