From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
David Hildenbrand <david@redhat.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] memory: Have 'info mtree' remove duplicated Address Space information
Date: Sat, 21 Aug 2021 00:50:25 +0200 [thread overview]
Message-ID: <15b14de0-40e9-835b-5734-71602a29b329@redhat.com> (raw)
In-Reply-To: <YSANtgAah4THaxub@t490s>
On 8/20/21 10:16 PM, Peter Xu wrote:
> Phil,
>
> On Fri, Aug 20, 2021 at 12:58:05PM +0200, Philippe Mathieu-Daudé wrote:
>>> (qemu) info mtree
>>> address-space: I/O
>>> 0000000000000000-000000000000ffff (prio 0, i/o): io
>>>
>>> address-space shared 9 times:
>>> - cpu-memory-0
>>> - cpu-memory-1
>>> - cpu-memory-2
>>> - cpu-memory-3
>>> - cpu-secure-memory-0
>>> - cpu-secure-memory-1
>>> - cpu-secure-memory-2
>>> - cpu-secure-memory-3
>>> - memory
>
> Do you think below would look better?
>
> address-space cpu-memory-0:
> address-space cpu-memory-1:
> address-space cpu-memory-3:
> ...
> address-space memory:
> [memory ranges]
OK.
> "info mtree -f" has something similar:
>
> FlatView #2
> AS "ich9-ahci", root: bus master container
> AS "vtd-root", root: vtd-00.0
> AS "virtio-blk-pci", root: bus master container
> AS "vtd-root", root: vtd-01.0
> AS "vtd-root", root: vtd-02.0
> AS "vtd-root", root: vtd-03.0
> AS "vtd-root", root: vtd-04.0
> AS "vtd-root", root: vtd-1f.0
> AS "vtd-root", root: vtd-1f.2
> AS "vtd-root", root: vtd-1f.3
> Root memory region: vtd-nodmar
> [memory ranges]
>
> [...]
>
>>> +struct AddressSpaceInfo {
>>> + MemoryRegionListHead *ml_head;
>>> + int counter;
>>
>> Doh this field is unused :/
>
> Looks good to me otherwise.
Thanks!
Phil.
next prev parent reply other threads:[~2021-08-20 22:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 10:54 [PATCH] memory: Have 'info mtree' remove duplicated Address Space information Philippe Mathieu-Daudé
2021-08-20 10:58 ` Philippe Mathieu-Daudé
2021-08-20 20:16 ` Peter Xu
2021-08-20 22:50 ` Philippe Mathieu-Daudé [this message]
2021-08-23 8:39 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15b14de0-40e9-835b-5734-71602a29b329@redhat.com \
--to=philmd@redhat.com \
--cc=david@redhat.com \
--cc=kraxel@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).