From: no-reply@patchew.org
To: lizhengui@huawei.com
Cc: kwolf@redhat.com, xieyingtai@huawei.com, lizhengui@huawei.com,
qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com,
stefanha@redhat.com, pbonzini@redhat.com
Subject: Re: [PATCH] qemu-img: add support for offline rate limit in qemu-img commit
Date: Sat, 17 Oct 2020 22:36:38 -0700 (PDT) [thread overview]
Message-ID: <160299939685.17996.17478045721149283378@66eaa9a8a123> (raw)
In-Reply-To: <1602999097-24744-1-git-send-email-lizhengui@huawei.com>
Patchew URL: https://patchew.org/QEMU/1602999097-24744-1-git-send-email-lizhengui@huawei.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1602999097-24744-1-git-send-email-lizhengui@huawei.com
Subject: [PATCH] qemu-img: add support for offline rate limit in qemu-img commit
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/1602999097-24744-1-git-send-email-lizhengui@huawei.com -> patchew/1602999097-24744-1-git-send-email-lizhengui@huawei.com
Switched to a new branch 'test'
ffdac92 qemu-img: add support for offline rate limit in qemu-img commit
=== OUTPUT BEGIN ===
ERROR: consider using qemu_strtoull in preference to strtoull
#59: FILE: qemu-img.c:1032:
+ unsigned long long sval = strtoull(optarg, &end, 10);
total: 1 errors, 0 warnings, 49 lines checked
Commit ffdac92f0f39 (qemu-img: add support for offline rate limit in qemu-img commit) has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/1602999097-24744-1-git-send-email-lizhengui@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
prev parent reply other threads:[~2020-10-18 5:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-18 5:31 [PATCH] qemu-img: add support for offline rate limit in qemu-img commit Zhengui li
2020-10-18 5:36 ` no-reply [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160299939685.17996.17478045721149283378@66eaa9a8a123 \
--to=no-reply@patchew.org \
--cc=kwolf@redhat.com \
--cc=lizhengui@huawei.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=xieyingtai@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).