qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: stefanha@redhat.com
Cc: kwolf@redhat.com, peter.maydell@linaro.org, berrange@redhat.com,
	ehabkost@redhat.com, qemu-block@nongnu.org, armbru@redhat.com,
	qemu-devel@nongnu.org, Coiby.Xu@gmail.com, dgilbert@redhat.com,
	stefanha@redhat.com, pbonzini@redhat.com, fam@euphon.net,
	mreitz@redhat.com
Subject: Re: [PULL v2 00/28] Block patches
Date: Thu, 22 Oct 2020 05:12:52 -0700 (PDT)	[thread overview]
Message-ID: <160336876996.26284.4541047192746309850@66eaa9a8a123> (raw)
In-Reply-To: <20201022112726.736757-1-stefanha@redhat.com>

Patchew URL: https://patchew.org/QEMU/20201022112726.736757-1-stefanha@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201022112726.736757-1-stefanha@redhat.com
Subject: [PULL v2 00/28] Block patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20201022112726.736757-1-stefanha@redhat.com -> patchew/20201022112726.736757-1-stefanha@redhat.com
Switched to a new branch 'test'
070cb87 iotests: add commit top->base cases to 274
2381a9d block/io: fix bdrv_is_allocated_above
5314155 block/io: bdrv_common_block_status_above: support bs == base
824d6f6 block/io: bdrv_common_block_status_above: support include_base
8f13830 block/io: fix bdrv_co_block_status_above
384ba22 block/export: add vhost-user-blk multi-queue support
e10972d block/export: add iothread and fixed-iothread options
531d73b block: move block exports to libblockdev
13e8546 qemu-storage-daemon: avoid compiling blockdev_ss twice
9144c2b util/vhost-user-server: use static library in meson.build
9afaa76 util/vhost-user-server: move header to include/
1ded925 block/export: convert vhost-user-blk server to block export API
5bfa726 block/export: report flush errors
4565966 util/vhost-user-server: rework vu_client_trip() coroutine lifecycle
7d3e499 util/vhost-user-server: check EOF when reading payload
719ab6d util/vhost-user-server: fix memory leak in vu_message_read()
0afbb2c util/vhost-user-server: drop unused DevicePanicNotifier
9c3a1b30 block/export: consolidate request structs into VuBlockReq
d7f9068 util/vhost-user-server: drop unnecessary watch deletion
eb038288 util/vhost-user-server: drop unnecessary QOM cast
b6a8c41 util/vhost-user-server: s/fileds/fields/ typo fix
ef06bf4 MAINTAINERS: Add vhost-user block device backend server maintainer
3fed4d9 block/export: vhost-user block device backend server
5570b61 block: move logical block size check function to a common utility function
b03a5d2 util/vhost-user-server: generic vhost user server
a940b88 libvhost-user: remove watch for kick_fd when de-initialize vu-dev
b367b3a libvhost-user: Allow vu_message_read to be replaced
d61af88 block/nvme: Add driver statistics for access alignment and hw errors

=== OUTPUT BEGIN ===
1/28 Checking commit d61af8856e1d (block/nvme: Add driver statistics for access alignment and hw errors)
2/28 Checking commit b367b3a0c954 (libvhost-user: Allow vu_message_read to be replaced)
WARNING: Block comments use a leading /* on a separate line
#130: FILE: contrib/libvhost-user/libvhost-user.h:395:
+    /* @read_msg: custom method to read vhost-user message

total: 0 errors, 1 warnings, 139 lines checked

Patch 2/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/28 Checking commit a940b885ebfc (libvhost-user: remove watch for kick_fd when de-initialize vu-dev)
4/28 Checking commit b03a5d2b5417 (util/vhost-user-server: generic vhost user server)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35: 
new file mode 100644

WARNING: line over 80 characters
#87: FILE: util/vhost-user-server.c:48:
+    /* When this is set vu_client_trip will stop new processing vhost-user message */

total: 0 errors, 2 warnings, 500 lines checked

Patch 4/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/28 Checking commit 5570b616e366 (block: move logical block size check function to a common utility function)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#85: 
new file mode 100644

total: 0 errors, 1 warnings, 129 lines checked

Patch 5/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/28 Checking commit 3fed4d90a1a6 (block/export: vhost-user block device backend server)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

WARNING: line over 80 characters
#476: FILE: block/export/vhost-user-blk-server.c:442:
+        blk_remove_aio_context_notifier(vu_block_device->backend, blk_aio_attached,

ERROR: g_free(NULL) is safe this check is probably not required
#536: FILE: block/export/vhost-user-blk-server.c:502:
+    if (vus->node_name) {
+        g_free(vus->node_name);

total: 1 errors, 2 warnings, 714 lines checked

Patch 6/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/28 Checking commit ef06bf498ce0 (MAINTAINERS: Add vhost-user block device backend server maintainer)
8/28 Checking commit b6a8c411bd0e (util/vhost-user-server: s/fileds/fields/ typo fix)
9/28 Checking commit eb03828873e5 (util/vhost-user-server: drop unnecessary QOM cast)
10/28 Checking commit d7f9068b77a3 (util/vhost-user-server: drop unnecessary watch deletion)
11/28 Checking commit 9c3a1b306de4 (block/export: consolidate request structs into VuBlockReq)
12/28 Checking commit 0afbb2c21554 (util/vhost-user-server: drop unused DevicePanicNotifier)
13/28 Checking commit 719ab6d69a12 (util/vhost-user-server: fix memory leak in vu_message_read())
14/28 Checking commit 7d3e49977472 (util/vhost-user-server: check EOF when reading payload)
15/28 Checking commit 4565966a008b (util/vhost-user-server: rework vu_client_trip() coroutine lifecycle)
16/28 Checking commit 5bfa726b1746 (block/export: report flush errors)
17/28 Checking commit 1ded9250e89e (block/export: convert vhost-user-blk server to block export API)
WARNING: line over 80 characters
#848: FILE: util/vhost-user-server.c:415:
+        error_setg(errp, "Only socket address types 'unix' and 'fd' are supported");

total: 0 errors, 1 warnings, 750 lines checked

Patch 17/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/28 Checking commit 9afaa765314b (util/vhost-user-server: move header to include/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#46: 
rename from util/vhost-user-server.h

total: 0 errors, 1 warnings, 28 lines checked

Patch 18/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/28 Checking commit 9144c2b466f1 (util/vhost-user-server: use static library in meson.build)
20/28 Checking commit 13e85467224b (qemu-storage-daemon: avoid compiling blockdev_ss twice)
21/28 Checking commit 531d73bc6cf8 (block: move block exports to libblockdev)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#127: 
new file mode 100644

total: 0 errors, 1 warnings, 86 lines checked

Patch 21/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/28 Checking commit e10972d76a6d (block/export: add iothread and fixed-iothread options)
23/28 Checking commit 384ba2206146 (block/export: add vhost-user-blk multi-queue support)
24/28 Checking commit 8f13830a0ff0 (block/io: fix bdrv_co_block_status_above)
25/28 Checking commit 824d6f661b42 (block/io: bdrv_common_block_status_above: support include_base)
26/28 Checking commit 53141557f415 (block/io: bdrv_common_block_status_above: support bs == base)
27/28 Checking commit 2381a9dbe034 (block/io: fix bdrv_is_allocated_above)
28/28 Checking commit 070cb8780309 (iotests: add commit top->base cases to 274)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20201022112726.736757-1-stefanha@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

  parent reply	other threads:[~2020-10-22 12:18 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-22 11:26 [PULL v2 00/28] Block patches Stefan Hajnoczi
2020-10-22 11:26 ` [PULL v2 01/28] block/nvme: Add driver statistics for access alignment and hw errors Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 02/28] libvhost-user: Allow vu_message_read to be replaced Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 03/28] libvhost-user: remove watch for kick_fd when de-initialize vu-dev Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 04/28] util/vhost-user-server: generic vhost user server Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 05/28] block: move logical block size check function to a common utility function Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 06/28] block/export: vhost-user block device backend server Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 07/28] MAINTAINERS: Add vhost-user block device backend server maintainer Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 08/28] util/vhost-user-server: s/fileds/fields/ typo fix Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 09/28] util/vhost-user-server: drop unnecessary QOM cast Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 10/28] util/vhost-user-server: drop unnecessary watch deletion Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 11/28] block/export: consolidate request structs into VuBlockReq Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 12/28] util/vhost-user-server: drop unused DevicePanicNotifier Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 13/28] util/vhost-user-server: fix memory leak in vu_message_read() Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 14/28] util/vhost-user-server: check EOF when reading payload Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 15/28] util/vhost-user-server: rework vu_client_trip() coroutine lifecycle Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 16/28] block/export: report flush errors Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 17/28] block/export: convert vhost-user-blk server to block export API Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 18/28] util/vhost-user-server: move header to include/ Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 19/28] util/vhost-user-server: use static library in meson.build Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 20/28] qemu-storage-daemon: avoid compiling blockdev_ss twice Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 21/28] block: move block exports to libblockdev Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 22/28] block/export: add iothread and fixed-iothread options Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 23/28] block/export: add vhost-user-blk multi-queue support Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 24/28] block/io: fix bdrv_co_block_status_above Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 25/28] block/io: bdrv_common_block_status_above: support include_base Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 26/28] block/io: bdrv_common_block_status_above: support bs == base Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 27/28] block/io: fix bdrv_is_allocated_above Stefan Hajnoczi
2020-10-22 11:27 ` [PULL v2 28/28] iotests: add commit top->base cases to 274 Stefan Hajnoczi
2020-10-22 12:12 ` no-reply [this message]
2020-10-22 14:09 ` [PULL v2 00/28] Block patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160336876996.26284.4541047192746309850@66eaa9a8a123 \
    --to=no-reply@patchew.org \
    --cc=Coiby.Xu@gmail.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=fam@euphon.net \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).