From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8B4EC56202 for ; Thu, 26 Nov 2020 03:02:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B39FC21534 for ; Thu, 26 Nov 2020 03:02:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B39FC21534 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bugs.launchpad.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ki7YC-0002YI-3J for qemu-devel@archiver.kernel.org; Wed, 25 Nov 2020 22:02:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45768) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ki7Wi-00026e-Tb for qemu-devel@nongnu.org; Wed, 25 Nov 2020 22:00:56 -0500 Received: from indium.canonical.com ([91.189.90.7]:34836) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ki7Wg-0004AJ-EK for qemu-devel@nongnu.org; Wed, 25 Nov 2020 22:00:56 -0500 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.86_2 #2 (Debian)) id 1ki7We-0001Rn-G5 for ; Thu, 26 Nov 2020 03:00:52 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id 73C5D2E8042 for ; Thu, 26 Nov 2020 03:00:52 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Thu, 26 Nov 2020 02:47:49 -0000 From: Doug Evans <1905651@bugs.launchpad.net> To: qemu-devel@nongnu.org X-Launchpad-Notification-Type: bug X-Launchpad-Bug: product=qemu; status=New; importance=Undecided; assignee=None; X-Launchpad-Bug-Information-Type: Public X-Launchpad-Bug-Private: no X-Launchpad-Bug-Security-Vulnerability: no X-Launchpad-Bug-Commenters: dje X-Launchpad-Bug-Reporter: Doug Evans (dje) X-Launchpad-Bug-Modifier: Doug Evans (dje) Message-Id: <160635886967.28413.180075874214780604.malonedeb@chaenomeles.canonical.com> Subject: [Bug 1905651] [NEW] Tests cannot call g_error X-Launchpad-Message-Rationale: Subscriber (QEMU) @qemu-devel-ml X-Launchpad-Message-For: qemu-devel-ml Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="3bd564e52ed9790394c5663a77af1e834fc2d372"; Instance="production" X-Launchpad-Hash: b1bbcd3b0a50119c8991116af9fe8f0b211b549c Received-SPF: none client-ip=91.189.90.7; envelope-from=bounces@canonical.com; helo=indium.canonical.com X-Spam_score_int: -65 X-Spam_score: -6.6 X-Spam_bar: ------ X-Spam_report: (-6.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Bug 1905651 <1905651@bugs.launchpad.net> Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Public bug reported: I stumbled on this writing a new test, using tests/qtest/e1000e-test.c as a template. g_error() causes SIGTRAP, not SIGABRT, and thus the abort handler doesn't g= et run. This in turn means qemu is not killed, which hangs the test because the tap= -driver.pl script hangs waiting for more input. There are a few tests that call g_error(). The SIGABRT handler explicitly kills qemu, e.g.: qos-test.c: qtest_add_abrt_handler(kill_qemu_hook_func, s); ref: https://git.qemu.org/?p=3Dqemu.git;a=3Dblob;f=3Dtests/qtest/libqtest.c;h=3D= e49f3a1e45f4cd96279241fdb2bbe231029ab922;hb=3DHEAD#l272 But not unexpectedly there's no such handler for SIGTRAP. Apply this patch to trigger a repro: diff --git a/tests/qtest/e1000e-test.c b/tests/qtest/e1000e-test.c index fc226fdfeb..e83ace1b5c 100644 --- a/tests/qtest/e1000e-test.c +++ b/tests/qtest/e1000e-test.c @@ -87,6 +87,9 @@ static void e1000e_send_verify(QE1000E *d, int *test_sock= ets, QGuestAllocator *a /* Wait for TX WB interrupt */ e1000e_wait_isr(d, E1000E_TX0_MSG_ID); + g_message("Test g_error hang ..."); + g_error("Pretend something timed out"); + /* Check DD bit */ g_assert_cmphex(le32_to_cpu(descr.upper.data) & dsta_dd, =3D=3D, dsta_= dd); Then: configure make make check-qtest-i386 check-qtest-i386 will take awhile. To repro faster: $ grep qtest-i386/qos-test Makefile.mtest .test.name.229 :=3D qtest-i386/qos-test $ make run-test-229 Running test qtest-i386/qos-test ** Message: 18:40:49.821: Test g_error hang ... ** (tests/qtest/qos-test:3820728): ERROR **: 18:40:49.821: Pretend somethin= g timed out ERROR qtest-i386/qos-test - Bail out! FATAL-ERROR: Pretend something timed = out At this point things are hung because tap-driver.pl is still waiting for input because qemu is still running. ** Affects: qemu Importance: Undecided Status: New -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1905651 Title: Tests cannot call g_error Status in QEMU: New Bug description: I stumbled on this writing a new test, using tests/qtest/e1000e-test.c as a template. g_error() causes SIGTRAP, not SIGABRT, and thus the abort handler doesn't= get run. This in turn means qemu is not killed, which hangs the test because the t= ap-driver.pl script hangs waiting for more input. There are a few tests that call g_error(). The SIGABRT handler explicitly kills qemu, e.g.: qos-test.c: qtest_add_abrt_handler(kill_qemu_hook_func, s); ref: https://git.qemu.org/?p=3Dqemu.git;a=3Dblob;f=3Dtests/qtest/libqtest.c;h= =3De49f3a1e45f4cd96279241fdb2bbe231029ab922;hb=3DHEAD#l272 But not unexpectedly there's no such handler for SIGTRAP. Apply this patch to trigger a repro: diff --git a/tests/qtest/e1000e-test.c b/tests/qtest/e1000e-test.c index fc226fdfeb..e83ace1b5c 100644 --- a/tests/qtest/e1000e-test.c +++ b/tests/qtest/e1000e-test.c @@ -87,6 +87,9 @@ static void e1000e_send_verify(QE1000E *d, int *test_so= ckets, QGuestAllocator *a /* Wait for TX WB interrupt */ e1000e_wait_isr(d, E1000E_TX0_MSG_ID); + g_message("Test g_error hang ..."); + g_error("Pretend something timed out"); + /* Check DD bit */ g_assert_cmphex(le32_to_cpu(descr.upper.data) & dsta_dd, =3D=3D, dst= a_dd); Then: configure make make check-qtest-i386 check-qtest-i386 will take awhile. To repro faster: $ grep qtest-i386/qos-test Makefile.mtest .test.name.229 :=3D qtest-i386/qos-test $ make run-test-229 Running test qtest-i386/qos-test ** Message: 18:40:49.821: Test g_error hang ... ** (tests/qtest/qos-test:3820728): ERROR **: 18:40:49.821: Pretend someth= ing timed out ERROR qtest-i386/qos-test - Bail out! FATAL-ERROR: Pretend something time= d out At this point things are hung because tap-driver.pl is still waiting for input because qemu is still running. To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1905651/+subscriptions