From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B08D2C4361B for ; Thu, 10 Dec 2020 09:06:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 372D923B99 for ; Thu, 10 Dec 2020 09:06:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 372D923B99 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bugs.launchpad.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knHuV-0007L0-6x for qemu-devel@archiver.kernel.org; Thu, 10 Dec 2020 04:06:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41374) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knHp2-0001it-3F for qemu-devel@nongnu.org; Thu, 10 Dec 2020 04:01:12 -0500 Received: from indium.canonical.com ([91.189.90.7]:59728) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1knHp0-0000dR-7t for qemu-devel@nongnu.org; Thu, 10 Dec 2020 04:01:11 -0500 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.86_2 #2 (Debian)) id 1knHow-0004ft-QN for ; Thu, 10 Dec 2020 09:01:06 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id C2C1F2E8047 for ; Thu, 10 Dec 2020 09:01:06 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Thu, 10 Dec 2020 08:49:59 -0000 From: Thomas Huth <1904486@bugs.launchpad.net> To: qemu-devel@nongnu.org X-Launchpad-Notification-Type: bug X-Launchpad-Bug: product=qemu; status=Fix Released; importance=Undecided; assignee=None; X-Launchpad-Bug-Information-Type: Public X-Launchpad-Bug-Private: no X-Launchpad-Bug-Security-Vulnerability: no X-Launchpad-Bug-Commenters: pmaydell th-huth yjruc zdchen X-Launchpad-Bug-Reporter: yuanjungong (yjruc) X-Launchpad-Bug-Modifier: Thomas Huth (th-huth) References: <160557932327.14164.11613670931205353723.malonedeb@soybean.canonical.com> Message-Id: <160759019974.11599.7996984647460438411.malone@wampee.canonical.com> Subject: [Bug 1904486] Re: resource leak in /net/tap.c X-Launchpad-Message-Rationale: Subscriber (QEMU) @qemu-devel-ml X-Launchpad-Message-For: qemu-devel-ml Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="4853cb86c14c5a9e513816c8a61121c639b30835"; Instance="production" X-Launchpad-Hash: 0d1782ea8e7011baf67b7bd0db61f83a1f843ccd Received-SPF: none client-ip=91.189.90.7; envelope-from=bounces@canonical.com; helo=indium.canonical.com X-Spam_score_int: -65 X-Spam_score: -6.6 X-Spam_bar: ------ X-Spam_report: (-6.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Bug 1904486 <1904486@bugs.launchpad.net> Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Released with QEMU v5.2.0. ** Changed in: qemu Status: Fix Committed =3D> Fix Released -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1904486 Title: resource leak in /net/tap.c Status in QEMU: Fix Released Bug description: Hi,there might be a resource leak in function net_init_tap in /net/tap.c. The version is 5.1.91. = =C2=A0811 fd =3D monitor_fd_param(monitor_cur(), tap->fd, errp); =C2=A0812 if (fd =3D=3D -1) { =C2=A0813 return -1; =C2=A0814 } =C2=A0815 =C2=A0816 ret =3D qemu_try_set_nonblock(fd); =C2=A0817 if (ret < 0) { =C2=A0818 error_setg_errno(errp, -ret, "%s: Can't use file de= scriptor %d", =C2=A0819 name, fd); =C2=A0820 return -1; =C2=A0821 } =C2=A0822 =C2=A0823 vnet_hdr =3D tap_probe_vnet_hdr(fd, errp); =C2=A0824 if (vnet_hdr < 0) { =C2=A0825 close(fd); =C2=A0826 return -1; =C2=A0827 } =C2=A0828 =C2=A0829 net_init_tap_one(tap, peer, "tap", name, NULL, =C2=A0830 script, downscript, =C2=A0831 vhostfdname, vnet_hdr, fd, &err); =C2=A0832 if (err) { =C2=A0833 error_propagate(errp, err); =C2=A0834 return -1; =C2=A0835 } fd should be closed before return in line 820 and line 834, similar to the implementation in line 825. To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1904486/+subscriptions