Re: [PULL 00/20] NBD patches for 2021-02-02

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20210202224529.642055-1-eblake@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210202224529.642055-1-eblake@redhat.com
Subject: [PULL 00/20] NBD patches for 2021-02-02

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210202191207.4103973-1-ehabkost@redhat.com -> patchew/20210202191207.4103973-1-ehabkost@redhat.com
 - [tag update]      patchew/20210202205824.1085853-1-philmd@redhat.com -> patchew/20210202205824.1085853-1-philmd@redhat.com
 * [new tag]         patchew/20210202224529.642055-1-eblake@redhat.com -> patchew/20210202224529.642055-1-eblake@redhat.com
Switched to a new branch 'test'
b4fc744 nbd: make nbd_read* return -EIO on error
509be46 block/nbd: only enter connection coroutine if it's present
606d6b3 block/nbd: only detach existing iochannel from aio_context
b9ebab5 block/io: use int64_t bytes in copy_range
4d2c686 block/io: support int64_t bytes in read/write wrappers
0f83114 block/io: support int64_t bytes in bdrv_co_p{read, write}v_part()
51bfadf block/io: support int64_t bytes in bdrv_aligned_preadv()
5ddf9ea block/io: support int64_t bytes in bdrv_co_do_copy_on_readv()
cf35854 block/io: support int64_t bytes in bdrv_aligned_pwritev()
53fd620 block/io: support int64_t bytes in bdrv_co_do_pwrite_zeroes()
df70398 block/io: use int64_t bytes in driver wrappers
f9b30ef block: use int64_t as bytes type in tracked requests
184c8b8 block/io: improve bdrv_check_request: check qiov too
848d7be block/throttle-groups: throttle_group_co_io_limits_intercept(): 64bit bytes
2958d9e block/io: bdrv_pad_request(): support qemu_iovec_init_extended failure
12700c1 block/io: refactor bdrv_pad_request(): move bdrv_pad_request() up
ff808b0 block: fix theoretical overflow in bdrv_init_padding()
e0a4e42 util/iov: make qemu_iovec_init_extended() honest
fe22159 block: refactor bdrv_check_request: add errp
cae9e91 iotests: Fix expected whitespace for 185

=== OUTPUT BEGIN ===
1/20 Checking commit cae9e912680e (iotests: Fix expected whitespace for 185)
2/20 Checking commit fe2215907a78 (block: refactor bdrv_check_request: add errp)
3/20 Checking commit e0a4e42b0947 (util/iov: make qemu_iovec_init_extended() honest)
4/20 Checking commit ff808b00c095 (block: fix theoretical overflow in bdrv_init_padding())
5/20 Checking commit 12700c18a28d (block/io: refactor bdrv_pad_request(): move bdrv_pad_request() up)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#73: 
new file mode 100644

ERROR: trailing whitespace
#82: FILE: block/io.c.rej:5:
+ $

ERROR: trailing whitespace
#100: FILE: block/io.c.rej:23:
+ $

ERROR: trailing whitespace
#106: FILE: block/io.c.rej:29:
+ $

total: 3 errors, 1 warnings, 85 lines checked

Patch 5/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/20 Checking commit 2958d9edb34e (block/io: bdrv_pad_request(): support qemu_iovec_init_extended failure)
7/20 Checking commit 848d7be2eda3 (block/throttle-groups: throttle_group_co_io_limits_intercept(): 64bit bytes)
8/20 Checking commit 184c8b8c73d6 (block/io: improve bdrv_check_request: check qiov too)
9/20 Checking commit f9b30ef24e63 (block: use int64_t as bytes type in tracked requests)
10/20 Checking commit df70398f87e5 (block/io: use int64_t bytes in driver wrappers)
11/20 Checking commit 53fd620fa30f (block/io: support int64_t bytes in bdrv_co_do_pwrite_zeroes())
12/20 Checking commit cf358543ec81 (block/io: support int64_t bytes in bdrv_aligned_pwritev())
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#134: 
deleted file mode 100644

total: 0 errors, 1 warnings, 73 lines checked

Patch 12/20 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/20 Checking commit 5ddf9eaa98f0 (block/io: support int64_t bytes in bdrv_co_do_copy_on_readv())
14/20 Checking commit 51bfadf931ed (block/io: support int64_t bytes in bdrv_aligned_preadv())
15/20 Checking commit 0f8311495774 (block/io: support int64_t bytes in bdrv_co_p{read, write}v_part())
16/20 Checking commit 4d2c686f09f5 (block/io: support int64_t bytes in read/write wrappers)
17/20 Checking commit b9ebab53f292 (block/io: use int64_t bytes in copy_range)
18/20 Checking commit 606d6b399708 (block/nbd: only detach existing iochannel from aio_context)
19/20 Checking commit 509be463b54f (block/nbd: only enter connection coroutine if it's present)
20/20 Checking commit b4fc744f9b07 (nbd: make nbd_read* return -EIO on error)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210202224529.642055-1-eblake@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com