qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: huangy81@chinatelecom.cn
Cc: crosa@redhat.com, huangy81@chinatelecom.cn,
	qemu-devel@nongnu.org, ehabkost@redhat.com
Subject: Re: [RFC] tests/migration: introduce multifd into guestperf toolkit
Date: Wed, 10 Mar 2021 10:24:43 -0800 (PST)	[thread overview]
Message-ID: <161540068259.3874.1699795445911271818@f3770d8ad632> (raw)
In-Reply-To: <726fc52e2f4ae6914ae43263bc02721a6c0eb6e7.1615398669.git.huangy81@chinatelecom.cn>

Patchew URL: https://patchew.org/QEMU/726fc52e2f4ae6914ae43263bc02721a6c0eb6e7.1615398669.git.huangy81@chinatelecom.cn/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 726fc52e2f4ae6914ae43263bc02721a6c0eb6e7.1615398669.git.huangy81@chinatelecom.cn
Subject: [RFC] tests/migration: introduce multifd into guestperf toolkit

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210310173004.420190-1-stefanha@redhat.com -> patchew/20210310173004.420190-1-stefanha@redhat.com
 * [new tag]         patchew/726fc52e2f4ae6914ae43263bc02721a6c0eb6e7.1615398669.git.huangy81@chinatelecom.cn -> patchew/726fc52e2f4ae6914ae43263bc02721a6c0eb6e7.1615398669.git.huangy81@chinatelecom.cn
Switched to a new branch 'test'
424fad7 tests/migration: introduce multifd into guestperf toolkit

=== OUTPUT BEGIN ===
ERROR: line over 90 characters
#119: FILE: tests/migration/guestperf/shell.py:125:
+        parser.add_argument("--multifd", dest="multifd", default=False, action="store_true")

ERROR: line over 90 characters
#120: FILE: tests/migration/guestperf/shell.py:126:
+        parser.add_argument("--multifd-channels", dest="multifd_channels", default=2, type=int)

total: 2 errors, 0 warnings, 93 lines checked

Commit 424fad7fbc3f (tests/migration: introduce multifd into guestperf toolkit) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/726fc52e2f4ae6914ae43263bc02721a6c0eb6e7.1615398669.git.huangy81@chinatelecom.cn/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

  reply	other threads:[~2021-03-10 18:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 17:57 [RFC] tests/migration: introduce multifd into guestperf toolkit huangy81
2021-03-10 18:24 ` no-reply [this message]
2021-03-11  0:30 huangy81

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161540068259.3874.1699795445911271818@f3770d8ad632 \
    --to=no-reply@patchew.org \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=huangy81@chinatelecom.cn \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).