Re: [PATCH 00/11] Add support for Blob resources feature

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20210331031001.1564125-1-vivek.kasireddy@intel.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210331031001.1564125-1-vivek.kasireddy@intel.com
Subject: [PATCH 00/11] Add support for Blob resources feature

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210331031001.1564125-1-vivek.kasireddy@intel.com -> patchew/20210331031001.1564125-1-vivek.kasireddy@intel.com
Switched to a new branch 'test'
b446fd9 virtio-gpu: Update cursor data using blob
3239ca7 virtio-gpu: Add virtio_gpu_set_scanout_blob
f52199e virtio-gpu: Add helpers to create and destroy dmabuf objects
1dcd341 virtio-gpu: Add virtio_gpu_resource_create_blob
6550dc7 virtio-gpu: Add initial definitions for blob resources
d394612 virtio-gpu: Refactor virtio_gpu_create_mapping_iov
372d98c virtio-gpu: Refactor virtio_gpu_set_scanout
43aa8d5 virtio-gpu: Add virtio_gpu_find_check_resource
4ebddba virtio-gpu: Add udmabuf helpers
969da42 ui/pixman: Add qemu_pixman_to_drm_format()
d33ad11 ui: Get the fd associated with udmabuf driver

=== OUTPUT BEGIN ===
1/11 Checking commit d33ad11ce69f (ui: Get the fd associated with udmabuf driver)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#44: 
new file mode 100644

total: 0 errors, 1 warnings, 54 lines checked

Patch 1/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/11 Checking commit 969da423dd95 (ui/pixman: Add qemu_pixman_to_drm_format())
3/11 Checking commit 4ebddba7f74b (virtio-gpu: Add udmabuf helpers)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39: 
new file mode 100644

ERROR: use qemu_real_host_page_size instead of getpagesize()
#119: FILE: hw/display/virtio-gpu-udmabuf.c:76:
+    res->remapsz = QEMU_ALIGN_UP(res->remapsz, getpagesize());

ERROR: braces {} are necessary for all arms of this statement
#169: FILE: hw/display/virtio-gpu-udmabuf.c:126:
+    if (udmabuf < 0)
[...]

total: 2 errors, 1 warnings, 265 lines checked

Patch 3/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/11 Checking commit 43aa8d5eb5dd (virtio-gpu: Add virtio_gpu_find_check_resource)
5/11 Checking commit 372d98ca604a (virtio-gpu: Refactor virtio_gpu_set_scanout)
6/11 Checking commit d3946125fd9b (virtio-gpu: Refactor virtio_gpu_create_mapping_iov)
7/11 Checking commit 6550dc790eef (virtio-gpu: Add initial definitions for blob resources)
8/11 Checking commit 1dcd3417ed0f (virtio-gpu: Add virtio_gpu_resource_create_blob)
9/11 Checking commit f52199e64d16 (virtio-gpu: Add helpers to create and destroy dmabuf objects)
WARNING: line over 80 characters
#51: FILE: hw/display/virtio-gpu-udmabuf.c:195:
+                                            struct virtio_gpu_simple_resource *res,

total: 0 errors, 1 warnings, 131 lines checked

Patch 9/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/11 Checking commit 3239ca755628 (virtio-gpu: Add virtio_gpu_set_scanout_blob)
WARNING: line over 80 characters
#104: FILE: hw/display/virtio-gpu.c:744:
+                                          ss.r.width, ss.r.height, ss.r.x, ss.r.y);

total: 0 errors, 1 warnings, 155 lines checked

Patch 10/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/11 Checking commit b446fd91fd53 (virtio-gpu: Update cursor data using blob)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210331031001.1564125-1-vivek.kasireddy@intel.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com