qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: iii@linux.ibm.com
Cc: borntraeger@de.ibm.com, laurent@vivier.eu, iii@linux.ibm.com,
	qemu-devel@nongnu.org
Subject: Re: [PATCH] linux-user/elfload: fix filling psinfo->pr_psargs
Date: Tue, 13 Apr 2021 14:03:44 -0700 (PDT)	[thread overview]
Message-ID: <161834782308.14712.5847960601396362593@72b6d80f974b> (raw)
In-Reply-To: <20210413205814.22821-1-iii@linux.ibm.com>

Patchew URL: https://patchew.org/QEMU/20210413205814.22821-1-iii@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210413205814.22821-1-iii@linux.ibm.com
Subject: [PATCH] linux-user/elfload: fix filling psinfo->pr_psargs

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210413205814.22821-1-iii@linux.ibm.com -> patchew/20210413205814.22821-1-iii@linux.ibm.com
Switched to a new branch 'test'
01536fa linux-user/elfload: fix filling psinfo->pr_psargs

=== OUTPUT BEGIN ===
ERROR: braces {} are necessary for all arms of this statement
#35: FILE: linux-user/elfload.c:3635:
+    if (copy_from_user(&psinfo->pr_psargs, ts->info->arg_strings, len))
[...]

total: 1 errors, 0 warnings, 12 lines checked

Commit 01536fa0c80b (linux-user/elfload: fix filling psinfo->pr_psargs) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210413205814.22821-1-iii@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

  reply	other threads:[~2021-04-13 21:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13 20:58 [PATCH] linux-user/elfload: fix filling psinfo->pr_psargs Ilya Leoshkevich
2021-04-13 21:03 ` no-reply [this message]
2021-05-15 19:59 ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161834782308.14712.5847960601396362593@72b6d80f974b \
    --to=no-reply@patchew.org \
    --cc=borntraeger@de.ibm.com \
    --cc=iii@linux.ibm.com \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).