From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0DC3C433ED for ; Thu, 22 Apr 2021 05:36:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 589F06144D for ; Thu, 22 Apr 2021 05:36:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 589F06144D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bugs.launchpad.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZS0r-0007bk-6T for qemu-devel@archiver.kernel.org; Thu, 22 Apr 2021 01:36:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZRzE-0006aQ-22 for qemu-devel@nongnu.org; Thu, 22 Apr 2021 01:34:48 -0400 Received: from indium.canonical.com ([91.189.90.7]:51134) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lZRzC-0004l7-Ay for qemu-devel@nongnu.org; Thu, 22 Apr 2021 01:34:47 -0400 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.86_2 #2 (Debian)) id 1lZRzB-0003KS-5U for ; Thu, 22 Apr 2021 05:34:45 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id 2892F2E802A for ; Thu, 22 Apr 2021 05:34:45 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Thu, 22 Apr 2021 05:21:19 -0000 From: Thomas Huth <1618122@bugs.launchpad.net> To: qemu-devel@nongnu.org X-Launchpad-Notification-Type: bug X-Launchpad-Bug: product=qemu; status=Incomplete; importance=Undecided; assignee=None; X-Launchpad-Bug-Information-Type: Public X-Launchpad-Bug-Private: no X-Launchpad-Bug-Security-Vulnerability: no X-Launchpad-Bug-Commenters: th-huth vans-163 X-Launchpad-Bug-Reporter: vans163 (vans-163) X-Launchpad-Bug-Modifier: Thomas Huth (th-huth) References: <20160829160030.27613.81837.malonedeb@gac.canonical.com> Message-Id: <161906888005.9724.14402377473786998660.malone@wampee.canonical.com> Subject: [Bug 1618122] Re: qemu-monitor screendump very slow X-Launchpad-Message-Rationale: Subscriber (QEMU) @qemu-devel-ml X-Launchpad-Message-For: qemu-devel-ml Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="1552fceb1603b3da6cfa437575d9c9fc4b2e683a"; Instance="production" X-Launchpad-Hash: 2181b4a3b8cd61f358d869cb18af10c7983cf945 Received-SPF: none client-ip=91.189.90.7; envelope-from=bounces@canonical.com; helo=indium.canonical.com X-Spam_score_int: -65 X-Spam_score: -6.6 X-Spam_bar: ------ X-Spam_report: (-6.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Bug 1618122 <1618122@bugs.launchpad.net> Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the state back to "New" within the next 60 days, otherwise this report will be marked as "Expired". Or please mark it as "Fix Released" if the problem has been solved with a newer version of QEMU already. Thank you and sorry for the inconvenience. ** Changed in: qemu Status: New =3D> Incomplete -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1618122 Title: qemu-monitor screendump very slow Status in QEMU: Incomplete Bug description: qemu-monitor screendump often using 10-20% cpu usage of one core to take a small capture. Most of the CPU usage seems to come from libpixman. There were many reports of libpixman becoming 8 times slower in newer releases. https://github.com/qemu/qemu/blob/0c56c6ab68902281094c7aac6305e2321c34c18= 7/ui/console.c#L285 Simple Valgrind Ir report. -------------------------------------------------------------------------= ------- =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Ir -------------------------------------------------------------------------= ------- 9,994,313,959 PROGRAM TOTALS -------------------------------------------------------------------------= ------- =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Ir fil= e:function -------------------------------------------------------------------------= ------- 4,883,603,360 /usr/src/debug/pixman-0.34.0/pixman/pixman-access.c:store_= scanline_b8g8r8 [/usr/lib64/libpixman-1.so.0.34.0] =C2=A0=C2=A0282,312,800 /usr/src/debug/pixman-0.34.0/pixman/pixman-imple= mentation.c:_pixman_implementation_iter_init [/usr/lib64/libpixman-1.so.0.3= 4.0] =C2=A0=C2=A0267,394,160 /usr/src/debug/pixman-0.34.0/pixman/pixman-sse2.= c:sse2_fetch_x8r8g8b8 [/usr/lib64/libpixman-1.so.0.34.0] =C2=A0=C2=A0256,761,600 /usr/src/debug/pixman-0.34.0/pixman/pixman-priva= te.h:store_scanline_b8g8r8 =C2=A0=C2=A0254,676,199 ???:0x0000000000011f40 [/usr/lib64/libjemalloc.s= o.2] =C2=A0=C2=A0199,990,526 ???:0x0000000000011a10 [/usr/lib64/libjemalloc.s= o.2] Calls to there start from. qemu_pixman_linebuf_fill pixman_image_composite ???? pixman_image_composite32 general_composite_rect I tried taking a look on how to fix this, but it seems pixman is deeply enrooted inside the monitor. I wanted to try to simply take whats on the display and memcpy it into .ppm format manually creating the file header, but the image is all broken with colors being off or its smeared. For example this is DisplaySurface: struct DisplaySurface { =C2=A0=C2=A0=C2=A0=C2=A0pixman_format_code_t format; =C2=A0=C2=A0=C2=A0=C2=A0pixman_image_t *image; =C2=A0=C2=A0=C2=A0=C2=A0uint8_t flags; #ifdef CONFIG_OPENGL =C2=A0=C2=A0=C2=A0=C2=A0GLenum glformat; =C2=A0=C2=A0=C2=A0=C2=A0GLenum gltype; =C2=A0=C2=A0=C2=A0=C2=A0GLuint texture; #endif }; = It appears graphic_hw_update(con) renders the vram to a pixman_image. Th= en ppm_save(filename, surface, errp) goes over it yet again, mutates the by= tes in an expensive way to another pixman_image, and saves that row by row = to a ppm. Using sdl graphics (the default) the drawing starts in https://github.com/qemu/qemu/blob/7fa124b273acd22a808e742ead78c065ccd9b4c= 4/hw/display/vga.c#L1466 To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1618122/+subscriptions