* [Qemu-devel] [Bug 1294227] [NEW] migration wrong handling of KVM_GET_DIRTY_LOG ioctl
@ 2014-03-18 17:24 Mario Smarduch
2014-09-29 13:59 ` [Qemu-devel] [Bug 1294227] " Christoffer Dall
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: Mario Smarduch @ 2014-03-18 17:24 UTC (permalink / raw)
To: qemu-devel
Public bug reported:
In the code below kvm_vm_ioctl(...) can return --errno != -1 from ioctl call, but return only checks for -1.
Found during KVM-ARM migration which apperead to go through but was actually failing getting
memslot dirty bitmap.
static int kvm_physical_sync_dirty_bitmap(....)
{
....
if(kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d) == -1) {
- err out
}
... continue
}
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1294227
Title:
migration wrong handling of KVM_GET_DIRTY_LOG ioctl
Status in QEMU:
New
Bug description:
In the code below kvm_vm_ioctl(...) can return --errno != -1 from ioctl call, but return only checks for -1.
Found during KVM-ARM migration which apperead to go through but was actually failing getting
memslot dirty bitmap.
static int kvm_physical_sync_dirty_bitmap(....)
{
....
if(kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d) == -1) {
- err out
}
... continue
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1294227/+subscriptions
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Qemu-devel] [Bug 1294227] Re: migration wrong handling of KVM_GET_DIRTY_LOG ioctl
2014-03-18 17:24 [Qemu-devel] [Bug 1294227] [NEW] migration wrong handling of KVM_GET_DIRTY_LOG ioctl Mario Smarduch
@ 2014-09-29 13:59 ` Christoffer Dall
2014-09-29 14:08 ` Christoffer Dall
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Christoffer Dall @ 2014-09-29 13:59 UTC (permalink / raw)
To: qemu-devel
** Changed in: qemu
Status: New => In Progress
** Changed in: qemu
Assignee: (unassigned) => Christoffer Dall (cdall)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1294227
Title:
migration wrong handling of KVM_GET_DIRTY_LOG ioctl
Status in QEMU:
In Progress
Bug description:
In the code below kvm_vm_ioctl(...) can return --errno != -1 from ioctl call, but return only checks for -1.
Found during KVM-ARM migration which apperead to go through but was actually failing getting
memslot dirty bitmap.
static int kvm_physical_sync_dirty_bitmap(....)
{
....
if(kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d) == -1) {
- err out
}
... continue
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1294227/+subscriptions
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Qemu-devel] [Bug 1294227] Re: migration wrong handling of KVM_GET_DIRTY_LOG ioctl
2014-03-18 17:24 [Qemu-devel] [Bug 1294227] [NEW] migration wrong handling of KVM_GET_DIRTY_LOG ioctl Mario Smarduch
2014-09-29 13:59 ` [Qemu-devel] [Bug 1294227] " Christoffer Dall
@ 2014-09-29 14:08 ` Christoffer Dall
2020-11-04 22:46 ` John Snow
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Christoffer Dall @ 2014-09-29 14:08 UTC (permalink / raw)
To: qemu-devel
Sent patch for error handling:
http://lists.nongnu.org/archive/html/qemu-devel/2014-09/msg05633.html
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1294227
Title:
migration wrong handling of KVM_GET_DIRTY_LOG ioctl
Status in QEMU:
In Progress
Bug description:
In the code below kvm_vm_ioctl(...) can return --errno != -1 from ioctl call, but return only checks for -1.
Found during KVM-ARM migration which apperead to go through but was actually failing getting
memslot dirty bitmap.
static int kvm_physical_sync_dirty_bitmap(....)
{
....
if(kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d) == -1) {
- err out
}
... continue
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1294227/+subscriptions
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug 1294227] Re: migration wrong handling of KVM_GET_DIRTY_LOG ioctl
2014-03-18 17:24 [Qemu-devel] [Bug 1294227] [NEW] migration wrong handling of KVM_GET_DIRTY_LOG ioctl Mario Smarduch
2014-09-29 13:59 ` [Qemu-devel] [Bug 1294227] " Christoffer Dall
2014-09-29 14:08 ` Christoffer Dall
@ 2020-11-04 22:46 ` John Snow
2021-01-29 8:54 ` Thomas Huth
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: John Snow @ 2020-11-04 22:46 UTC (permalink / raw)
To: qemu-devel
Moving this bug back to Confirmed to move it out of "In progress" state.
We still check for only -1 upstream.
** Changed in: qemu
Status: In Progress => Confirmed
** Changed in: qemu
Assignee: Christoffer Dall (cdall) => (unassigned)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1294227
Title:
migration wrong handling of KVM_GET_DIRTY_LOG ioctl
Status in QEMU:
Confirmed
Bug description:
In the code below kvm_vm_ioctl(...) can return --errno != -1 from ioctl call, but return only checks for -1.
Found during KVM-ARM migration which apperead to go through but was actually failing getting
memslot dirty bitmap.
static int kvm_physical_sync_dirty_bitmap(....)
{
....
if(kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d) == -1) {
- err out
}
... continue
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1294227/+subscriptions
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug 1294227] Re: migration wrong handling of KVM_GET_DIRTY_LOG ioctl
2014-03-18 17:24 [Qemu-devel] [Bug 1294227] [NEW] migration wrong handling of KVM_GET_DIRTY_LOG ioctl Mario Smarduch
` (2 preceding siblings ...)
2020-11-04 22:46 ` John Snow
@ 2021-01-29 8:54 ` Thomas Huth
2021-02-09 14:25 ` Thomas Huth
2021-04-30 8:54 ` Thomas Huth
5 siblings, 0 replies; 7+ messages in thread
From: Thomas Huth @ 2021-01-29 8:54 UTC (permalink / raw)
To: qemu-devel
Yet another try to fix this issue:
https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg07557.html
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1294227
Title:
migration wrong handling of KVM_GET_DIRTY_LOG ioctl
Status in QEMU:
Confirmed
Bug description:
In the code below kvm_vm_ioctl(...) can return --errno != -1 from ioctl call, but return only checks for -1.
Found during KVM-ARM migration which apperead to go through but was actually failing getting
memslot dirty bitmap.
static int kvm_physical_sync_dirty_bitmap(....)
{
....
if(kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d) == -1) {
- err out
}
... continue
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1294227/+subscriptions
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug 1294227] Re: migration wrong handling of KVM_GET_DIRTY_LOG ioctl
2014-03-18 17:24 [Qemu-devel] [Bug 1294227] [NEW] migration wrong handling of KVM_GET_DIRTY_LOG ioctl Mario Smarduch
` (3 preceding siblings ...)
2021-01-29 8:54 ` Thomas Huth
@ 2021-02-09 14:25 ` Thomas Huth
2021-04-30 8:54 ` Thomas Huth
5 siblings, 0 replies; 7+ messages in thread
From: Thomas Huth @ 2021-02-09 14:25 UTC (permalink / raw)
To: qemu-devel
Patch has been merged here:
https://gitlab.com/qemu-project/qemu/-/commit/38e0b7904eca7cd32
** Changed in: qemu
Status: Confirmed => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1294227
Title:
migration wrong handling of KVM_GET_DIRTY_LOG ioctl
Status in QEMU:
Fix Committed
Bug description:
In the code below kvm_vm_ioctl(...) can return --errno != -1 from ioctl call, but return only checks for -1.
Found during KVM-ARM migration which apperead to go through but was actually failing getting
memslot dirty bitmap.
static int kvm_physical_sync_dirty_bitmap(....)
{
....
if(kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d) == -1) {
- err out
}
... continue
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1294227/+subscriptions
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug 1294227] Re: migration wrong handling of KVM_GET_DIRTY_LOG ioctl
2014-03-18 17:24 [Qemu-devel] [Bug 1294227] [NEW] migration wrong handling of KVM_GET_DIRTY_LOG ioctl Mario Smarduch
` (4 preceding siblings ...)
2021-02-09 14:25 ` Thomas Huth
@ 2021-04-30 8:54 ` Thomas Huth
5 siblings, 0 replies; 7+ messages in thread
From: Thomas Huth @ 2021-04-30 8:54 UTC (permalink / raw)
To: qemu-devel
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1294227
Title:
migration wrong handling of KVM_GET_DIRTY_LOG ioctl
Status in QEMU:
Fix Released
Bug description:
In the code below kvm_vm_ioctl(...) can return --errno != -1 from ioctl call, but return only checks for -1.
Found during KVM-ARM migration which apperead to go through but was actually failing getting
memslot dirty bitmap.
static int kvm_physical_sync_dirty_bitmap(....)
{
....
if(kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d) == -1) {
- err out
}
... continue
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1294227/+subscriptions
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-04-30 9:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-18 17:24 [Qemu-devel] [Bug 1294227] [NEW] migration wrong handling of KVM_GET_DIRTY_LOG ioctl Mario Smarduch
2014-09-29 13:59 ` [Qemu-devel] [Bug 1294227] " Christoffer Dall
2014-09-29 14:08 ` Christoffer Dall
2020-11-04 22:46 ` John Snow
2021-01-29 8:54 ` Thomas Huth
2021-02-09 14:25 ` Thomas Huth
2021-04-30 8:54 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).