qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Bug 1882497] [NEW] Missing 'cmp' utility makes build take 10 times as long
@ 2020-06-08  7:01 Adam Baxter
  2020-06-08  7:30 ` [Bug 1882497] " Laurent Vivier
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Adam Baxter @ 2020-06-08  7:01 UTC (permalink / raw)
  To: qemu-devel

Public bug reported:

I have been doing some work cross compiling qemu for Windows using a
minimal Fedora container. Recently I started hitting some timeouts on
the CI service and noticed a build of all targets was going over 1 hour.

It seems like the 'cmp' utility from diffutils is used somewhere in the
process and if it's missing, either a configure or a make gets run way
too many times - I'll try to pull logs from the CI system at some stage
soon.

Could a warning or error be added if cmp is missing?

** Affects: qemu
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1882497

Title:
  Missing 'cmp' utility makes build take 10 times as long

Status in QEMU:
  New

Bug description:
  I have been doing some work cross compiling qemu for Windows using a
  minimal Fedora container. Recently I started hitting some timeouts on
  the CI service and noticed a build of all targets was going over 1
  hour.

  It seems like the 'cmp' utility from diffutils is used somewhere in
  the process and if it's missing, either a configure or a make gets run
  way too many times - I'll try to pull logs from the CI system at some
  stage soon.

  Could a warning or error be added if cmp is missing?

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1882497/+subscriptions


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug 1882497] Re: Missing 'cmp' utility makes build take 10 times as long
  2020-06-08  7:01 [Bug 1882497] [NEW] Missing 'cmp' utility makes build take 10 times as long Adam Baxter
@ 2020-06-08  7:30 ` Laurent Vivier
  2021-05-06 16:10 ` Thomas Huth
  2021-07-06  4:17 ` Launchpad Bug Tracker
  2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2020-06-08  7:30 UTC (permalink / raw)
  To: qemu-devel

cmp is used in the makefiles.

And there is some kind of warning during build if it is missing:

/bin/sh: cmp: command not found

But perhaps it should abort the build in this case.

Something like that helps:

diff --git a/Makefile b/Makefile
index 40e4f7677bde..05e029bd99db 100644
--- a/Makefile
+++ b/Makefile
@@ -482,6 +482,7 @@ include $(SRC_PATH)/tests/Makefile.include
 all: $(DOCS) $(if $(BUILD_DOCS),sphinxdocs) $(TOOLS) $(HELPERS-y) recurse-all modules $(vhost-user-json-y)
 
 qemu-version.h: FORCE
+       @type cmp
        $(call quiet-command, \
                 (printf '#define QEMU_PKGVERSION "$(QEMU_PKGVERSION)"\n'; \
                printf '#define QEMU_FULL_VERSION "$(FULL_VERSION)"\n'; \

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1882497

Title:
  Missing 'cmp' utility makes build take 10 times as long

Status in QEMU:
  New

Bug description:
  I have been doing some work cross compiling qemu for Windows using a
  minimal Fedora container. Recently I started hitting some timeouts on
  the CI service and noticed a build of all targets was going over 1
  hour.

  It seems like the 'cmp' utility from diffutils is used somewhere in
  the process and if it's missing, either a configure or a make gets run
  way too many times - I'll try to pull logs from the CI system at some
  stage soon.

  Could a warning or error be added if cmp is missing?

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1882497/+subscriptions


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Bug 1882497] Re: Missing 'cmp' utility makes build take 10 times as long
  2020-06-08  7:01 [Bug 1882497] [NEW] Missing 'cmp' utility makes build take 10 times as long Adam Baxter
  2020-06-08  7:30 ` [Bug 1882497] " Laurent Vivier
@ 2021-05-06 16:10 ` Thomas Huth
  2021-07-06  4:17 ` Launchpad Bug Tracker
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2021-05-06 16:10 UTC (permalink / raw)
  To: qemu-devel

Does this problem still persist with the latest version of QEMU (since
we switched the build system mostly to meson now)?

** Changed in: qemu
       Status: New => Incomplete

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1882497

Title:
  Missing 'cmp' utility makes build take 10 times as long

Status in QEMU:
  Incomplete

Bug description:
  I have been doing some work cross compiling qemu for Windows using a
  minimal Fedora container. Recently I started hitting some timeouts on
  the CI service and noticed a build of all targets was going over 1
  hour.

  It seems like the 'cmp' utility from diffutils is used somewhere in
  the process and if it's missing, either a configure or a make gets run
  way too many times - I'll try to pull logs from the CI system at some
  stage soon.

  Could a warning or error be added if cmp is missing?

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1882497/+subscriptions


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug 1882497] Re: Missing 'cmp' utility makes build take 10 times as long
  2020-06-08  7:01 [Bug 1882497] [NEW] Missing 'cmp' utility makes build take 10 times as long Adam Baxter
  2020-06-08  7:30 ` [Bug 1882497] " Laurent Vivier
  2021-05-06 16:10 ` Thomas Huth
@ 2021-07-06  4:17 ` Launchpad Bug Tracker
  2 siblings, 0 replies; 4+ messages in thread
From: Launchpad Bug Tracker @ 2021-07-06  4:17 UTC (permalink / raw)
  To: qemu-devel

[Expired for QEMU because there has been no activity for 60 days.]

** Changed in: qemu
       Status: Incomplete => Expired

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1882497

Title:
  Missing 'cmp' utility makes build take 10 times as long

Status in QEMU:
  Expired

Bug description:
  I have been doing some work cross compiling qemu for Windows using a
  minimal Fedora container. Recently I started hitting some timeouts on
  the CI service and noticed a build of all targets was going over 1
  hour.

  It seems like the 'cmp' utility from diffutils is used somewhere in
  the process and if it's missing, either a configure or a make gets run
  way too many times - I'll try to pull logs from the CI system at some
  stage soon.

  Could a warning or error be added if cmp is missing?

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1882497/+subscriptions


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-07-06  4:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-08  7:01 [Bug 1882497] [NEW] Missing 'cmp' utility makes build take 10 times as long Adam Baxter
2020-06-08  7:30 ` [Bug 1882497] " Laurent Vivier
2021-05-06 16:10 ` Thomas Huth
2021-07-06  4:17 ` Launchpad Bug Tracker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).