From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF608C433B4 for ; Wed, 12 May 2021 11:12:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCEA160720 for ; Wed, 12 May 2021 11:12:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCEA160720 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bugs.launchpad.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46196 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgmnQ-0000Fc-Iz for qemu-devel@archiver.kernel.org; Wed, 12 May 2021 07:12:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42290) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgmlZ-0006eU-0O for qemu-devel@nongnu.org; Wed, 12 May 2021 07:11:01 -0400 Received: from indium.canonical.com ([91.189.90.7]:60000) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lgmlW-0007hN-Pk for qemu-devel@nongnu.org; Wed, 12 May 2021 07:11:00 -0400 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.93 #5 (Debian)) id 1lgmlT-0000U0-Un for ; Wed, 12 May 2021 11:10:55 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id CC23B2E8193 for ; Wed, 12 May 2021 11:10:55 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Wed, 12 May 2021 11:02:37 -0000 From: Thomas Huth <1888818@bugs.launchpad.net> To: qemu-devel@nongnu.org X-Launchpad-Notification-Type: bug X-Launchpad-Bug: product=qemu; status=Expired; importance=Undecided; assignee=None; X-Launchpad-Bug-Information-Type: Public X-Launchpad-Bug-Private: no X-Launchpad-Bug-Security-Vulnerability: no X-Launchpad-Bug-Commenters: th-huth xavier-ding X-Launchpad-Bug-Reporter: xuan (xavier-ding) X-Launchpad-Bug-Modifier: Thomas Huth (th-huth) References: <159558183424.11837.7512442025195132206.malonedeb@wampee.canonical.com> Message-Id: <162081735724.31075.17380265348196779838.malone@gac.canonical.com> Subject: [Bug 1888818] Re: Multi-queue vhost-user fails to reconnect with qemu version >=4.2 X-Launchpad-Message-Rationale: Subscriber (QEMU) @qemu-devel-ml X-Launchpad-Message-For: qemu-devel-ml Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="37ef8bff8cdf61b994f9b61bc9239663cb29cec9"; Instance="production" X-Launchpad-Hash: d93ef7cf79c0bfa05b5d52ea72ae8d6c5f40539b Received-SPF: none client-ip=91.189.90.7; envelope-from=bounces@canonical.com; helo=indium.canonical.com X-Spam_score_int: -65 X-Spam_score: -6.6 X-Spam_bar: ------ X-Spam_report: (-6.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Bug 1888818 <1888818@bugs.launchpad.net> Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/277 ** Changed in: qemu Status: New =3D> Expired ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #277 https://gitlab.com/qemu-project/qemu/-/issues/277 -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1888818 Title: Multi-queue vhost-user fails to reconnect with qemu version >=3D4.2 Status in QEMU: Expired Bug description: Test Environment: DPDK version: DPDK v20.08 Other software versions: qemu4.2.0, qemu5.0.0. OS: Linux 4.15.0-20-generic Compiler: gcc (Ubuntu 7.3.0-16ubuntu3) 8.4.0 Hardware platform: Purley. Test Setup Steps to reproduce List the steps to reproduce the issue. Test flow =3D=3D=3D=3D=3D=3D=3D=3D=3D 1. Launch vhost-user testpmd as port0 with 2 queues: ./x86_64-native-linuxapp-gcc/app/testpmd -l 2-4 -n 4 \ =C2=A0=C2=A0=C2=A0=C2=A0--file-prefix=3Dvhost --vdev 'net_vhost0,iface=3D= vhost-net,queues=3D2,client=3D1' -- -i --txd=3D1024 --rxd=3D1024 --txq=3D2 = --rxq=3D2 testpmd>start 3. Launch qemu with virtio-net: =C2=A0taskset -c 13 \ =C2=A0=C2=A0=C2=A0=C2=A0qemu-system-x86_64 -name us-vhost-vm1 \ =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-cpu host -enable-kvm -m 2048 -= object memory-backend-file,id=3Dmem,size=3D2048M,mem-path=3D/mnt/huge,share= =3Don \ =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-numa node,memdev=3Dmem \ =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-mem-prealloc -monitor unix:/tm= p/vm2_monitor.sock,server,nowait -netdev user,id=3Dyinan,hostfwd=3Dtcp:127.= 0.0.1:6005-:22 -device e1000,netdev=3Dyinan \ =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-smp cores=3D1,sockets=3D1 -dri= ve file=3D/home/osimg/ubuntu16.img \ =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-chardev socket,id=3Dchar0,path= =3D./vhost-net,server \ =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-netdev type=3Dvhost-user,id=3D= mynet1,chardev=3Dchar0,vhostforce,queues=3D2 \ =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-device virtio-net-pci,mac=3D52= :54:00:00:00:01,netdev=3Dmynet1,mrg_rxbuf=3Don,csum=3Don,gso=3Don,host_tso4= =3Don,guest_tso4=3Don,mq=3Don,vectors=3D15 \ =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-vnc :10 -daemonize 6. Quit testpmd and restart vhost-user : testpmd>quit ./x86_64-native-linuxapp-gcc/app/testpmd -l 2-4 -n 4 \ =C2=A0=C2=A0=C2=A0=C2=A0--file-prefix=3Dvhost --vdev 'net_vhost0,iface=3D= vhost-net,queues=3D2,client=3D1' -- -i --txd=3D1024 --rxd=3D1024 --txq=3D2 = --rxq=3D2 Expected Result: After the vhost-user is killed then re-launched, the virtio-net can conne= ct back to vhost-user again. Actual Result: Vhost-user relaunch failed with continous log printed"VHOST_CONFIG: Proce= ssing VHOST_USER_SET_FEATURES failed. Analysis: This is a regression bug, bad commit: c6beefd674f When vhost-user quits, QEMU doesnot save acked features for each virtio-n= et after vhost-user quits. When vhost-user reconnects to QEMU, QEMU sends t= wo different features(one is the true acked feature while the another is 0x= 40000000) to vhost-user successively which causing vhost-user exits abnorma= lly. To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1888818/+subscriptions